From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-amlogic@lists.infradead.org
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
khilman@baylibre.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: [PATCH RESEND v2 0/2] pinctrl-meson: two small improvements
Date: Fri, 17 Apr 2020 20:33:47 +0200 [thread overview]
Message-ID: <20200417183349.1283092-1-martin.blumenstingl@googlemail.com> (raw)
While playing with audio output on Meson8b I found out that the
vendor kernel uses a custom version of the GPIO_PULL_UP flag. I
suspect that we will need this for audio support on Meson8b and/or
Meson8m2 but I don't see it hurt other platforms.
Also while comparing the register bits with the GPIO direction (of
GPIOs exported to sysfs) I sometimes had a mismatch. This also wires
up gpio_chip.get_direction to have sysfs and the actual registers in
sync.
Changes since v1 from [0]:
- re-send as non-"RFC" because I only got one comment in the past week
for patch #2. Jerome pointed out an alternative way to GPIO_PULL_UP
and GPIO_PULL_DOWN. However, this doesn't invalidate the patch, it
just means that there are two ways to achieve the same goal.
[0] https://patchwork.kernel.org/cover/11484185/
Martin Blumenstingl (2):
pinctrl: meson: implement the gpio_chip get_direction callback
pinctrl: meson: wire up the gpio_chip's set_config callback
drivers/pinctrl/meson/pinctrl-meson.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
--
2.26.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next reply other threads:[~2020-04-17 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 18:33 Martin Blumenstingl [this message]
2020-04-17 18:33 ` [PATCH RESEND v2 1/2] pinctrl: meson: implement the gpio_chip get_direction callback Martin Blumenstingl
2020-04-17 18:33 ` [PATCH RESEND v2 2/2] pinctrl: meson: wire up the gpio_chip's set_config callback Martin Blumenstingl
2020-04-28 10:01 ` [PATCH RESEND v2 0/2] pinctrl-meson: two small improvements Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417183349.1283092-1-martin.blumenstingl@googlemail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®