From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E47BC6369E for ; Tue, 17 Nov 2020 02:02:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C089F24695 for ; Tue, 17 Nov 2020 02:02:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DxNxUJOW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C089F24695 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QsRE37dG0sa4PtgF0OB9Hl+fsr97DYmDzK0mRIOmgHU=; b=DxNxUJOWY+TqutHK+YMVODBtE ALokvSSzBYrhRJg/cEgPP8zTXp2JOe6lLt+yIPJ38KVH27+4Q2xphzEIRY6GTa9yfwzmdv4AoCeiH 2aBuL7++6kyM0FewXHqChKS2g9hBUhJ4tlYLsQyyUzkeyMsF4bAwCDldciGE/kfbJTU4xuWd33uNz X3tXkgo6P4hTNhcCYe9D0UmsQyC2i/DxaHCiM/hYfqWIkRpvBL313ihs7UusmXXKILTNVfNnL29b/ R4pD9lo2nm5svlbHlYF5w6nRybVdXD8RtTmd8XiYRY+RNP8lcZ41XPQxAENjf/bnQp0Eu0oV25ctj ml6aMxOYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1keqKK-0007lX-1i; Tue, 17 Nov 2020 02:02:36 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1keqKH-0007ku-CN; Tue, 17 Nov 2020 02:02:33 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1keqKA-007S5K-FA; Tue, 17 Nov 2020 03:02:26 +0100 Date: Tue, 17 Nov 2020 03:02:26 +0100 From: Andrew Lunn To: Martin Blumenstingl Subject: Re: [PATCH RFC v2 2/5] net: stmmac: dwmac-meson8b: fix enabling the timing-adjustment clock Message-ID: <20201117020226.GB1752213@lunn.ch> References: <20201115185210.573739-1-martin.blumenstingl@googlemail.com> <20201115185210.573739-3-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201115185210.573739-3-martin.blumenstingl@googlemail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_210233_455416_598178F0 X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com, jianxin.pan@amlogic.com, narmstrong@baylibre.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, khilman@baylibre.com, linux-amlogic@lists.infradead.org, kuba@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sun, Nov 15, 2020 at 07:52:07PM +0100, Martin Blumenstingl wrote: > The timing-adjustment clock only has to be enabled when a) there is a > 2ns RX delay configured using device-tree and b) the phy-mode indicates > that the RX delay should be enabled. > > Only enable the RX delay if both are true, instead of (by accident) also > enabling it when there's the 2ns RX delay configured but the phy-mode > incicates that the RX delay is not used. > > Fixes: 9308c47640d515 ("net: stmmac: dwmac-meson8b: add support for the RX delay configuration") > Reported-by: Andrew Lunn > Signed-off-by: Martin Blumenstingl Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic