From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Matt Mackall <mpm@selenic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-crypto@vger.kernel.org, kernel@pengutronix.de,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v2] hwrng: meson - Improve error handling for core clock
Date: Fri, 1 Oct 2021 14:43:58 +0800 [thread overview]
Message-ID: <20211001064358.GA13451@gondor.apana.org.au> (raw)
In-Reply-To: <20210920074405.252477-1-u.kleine-koenig@pengutronix.de>
On Mon, Sep 20, 2021 at 09:44:05AM +0200, Uwe Kleine-König wrote:
> -ENOENT (ie. "there is no clock") is fine to ignore for an optional
> clock, other values are not supposed to be ignored and should be
> escalated to the caller (e.g. -EPROBE_DEFER). Ignore -ENOENT by using
> devm_clk_get_optional().
>
> While touching this code also add an error message for the fatal errors.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> compared to (implicit) v1
> (https://lore.kernel.org/r/20210914142428.57099-1-u.kleine-koenig@pengutronix.de)
> this used dev_err_probe() as suggested by Martin Blumenstingl.
>
> v1 got a "Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>", I didn't add
> that because of the above change.
>
> (Hmm, my setup is broken, the b4 patch signature was done before I added this
> message. I wonder if this will break the signature ...)
>
> Best regards
> Uwe
>
> drivers/char/hw_random/meson-rng.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2021-10-01 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 7:44 Uwe Kleine-König
2021-09-20 8:16 ` Neil Armstrong
2021-09-20 20:24 ` Martin Blumenstingl
2021-10-01 6:43 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211001064358.GA13451@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=jbrunet@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mpm@selenic.com \
--cc=narmstrong@baylibre.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®