From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1544DC4167B for ; Tue, 18 Oct 2022 17:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mgYlr8emUFQu0RkRmE8zc0HUxVtaDhF0cK0KYkU7sf0=; b=KgYX1erB4cfIA7 GbDD94YqJSr9xO67LYmTmOA02n4AVD65PZmFJjQ5cr+OxcvVmNu6zxcdlIsKtKssq7BbMc9ZW7H0j EwxvlNs5FQ7Psk6abto5kgCxR/ttjbSfFTYADg5p1S3CcyHEdvo6VObD450pBQWoLqxQ/3BO37wUE 2HIyQLJ3CoS5LOz34HcgjX29IXFOsOL3FJn/JvMndauY7VE5M3AIv6Itp6Zat+YUd8TdwsqPT8awI giKPkAa1hX+1tN0j011MJngr9aS7ffzkNyuvAWUikinjHOAWBtyx6u016l9f1esxJ5Z3j+2EBfpjN ZxLm5BWBQU/VHcYos6uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okqXG-009TF6-2Q; Tue, 18 Oct 2022 17:37:50 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okQE8-00C7cP-Ff; Mon, 17 Oct 2022 13:32:22 +0000 Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4MrdB34gj5z686tl; Mon, 17 Oct 2022 21:28:59 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.31; Mon, 17 Oct 2022 15:32:04 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 14:32:03 +0100 Date: Mon, 17 Oct 2022 14:32:02 +0100 From: Jonathan Cameron To: Amit Kumar Mahapatra CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 05/10] iio: imu: Replace spi->chip_select references to spi->chip_select[0] Message-ID: <20221017143202.00003b1d@huawei.com> In-Reply-To: <20221017121249.19061-6-amit.kumar-mahapatra@amd.com> References: <20221017121249.19061-1-amit.kumar-mahapatra@amd.com> <20221017121249.19061-6-amit.kumar-mahapatra@amd.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221017_063220_856167_18727AD4 X-CRM114-Status: GOOD ( 12.29 ) X-Mailman-Approved-At: Tue, 18 Oct 2022 10:37:44 -0700 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, 17 Oct 2022 17:42:44 +0530 Amit Kumar Mahapatra wrote: > For adding multi CS support & to prevent any existing driver from > breaking, replaced all spi->chip_select references to spi->chip_slect[0]. > > Signed-off-by: Amit Kumar Mahapatra Hmm. No particular reason why that print should exist at all. The warning above it covers the case where there is a mismatch in IDs so this adds nothing useful. So patch is fine, but I'd be equally happy with just dropping the print. Acked-by: Jonathan Cameron > --- > drivers/iio/imu/adis16400.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c > index 17bb0c40a149..aa7bfcee3510 100644 > --- a/drivers/iio/imu/adis16400.c > +++ b/drivers/iio/imu/adis16400.c > @@ -466,7 +466,7 @@ static int adis16400_initial_setup(struct iio_dev *indio_dev) > > dev_info(&indio_dev->dev, "%s: prod_id 0x%04x at CS%d (irq %d)\n", > indio_dev->name, prod_id, > - st->adis.spi->chip_select, st->adis.spi->irq); > + st->adis.spi->chip_select[0], st->adis.spi->irq); > } > /* use high spi speed if possible */ > if (st->variant->flags & ADIS16400_HAS_SLOW_MODE) { _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic