From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alexey Romanov <avromanov@sberdevices.ru>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <neil.armstrong@linaro.org>,
<khilman@baylibre.com>, <jbrunet@baylibre.com>,
<martin.blumenstingl@googlemail.com>, <linus.walleij@linaro.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kernel@sberdevices.ru>
Subject: Re: [PATCH v1 3/3] arch/arm: dts: introduce meson-a1 device tree
Date: Mon, 27 Feb 2023 17:39:29 +0300 [thread overview]
Message-ID: <20230227143929.h2lppesdiaj7l3gn@CAB-WSD-L081021> (raw)
In-Reply-To: <d5d9a1fe-2f66-66e3-d88a-76a12f2ec55e@linaro.org>
Hello Krzysztof!
On Thu, Feb 23, 2023 at 10:09:25AM +0100, Krzysztof Kozlowski wrote:
[...]
> >> describes following compontents: CPU, GIC, IRQ, Timer, UART,
> >> PIN controller. It's capable of booting up into
> >> the serial console.
> >>
> >> This is based on arm64 version of meson-a1.dtsi.
> >>
> >> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> >> ---
> >> arch/arm/boot/dts/meson-a1.dtsi | 151 ++++++++++++++++++++++++++++++++
> >
> > There is such file and there is such DTS/hardware support. I don't see
> > any reason why entire DTSI should be duplicated. What's more, your
> > commit does not explain it - does not justify duplication.
>
> One more comment - I think you just added dead code. It's
> uncompilable/untestable. Otherwise, please share how to build this DTSI
> without DTS.
You are right, Alexey doesn't provide any exact *.dts file for any
board, and *.dtsi file should be included somewhere, otherwise this is
dead code.
Unfortunately, our internal board *.dts file is useless for kernel
community, cause there is not any chance to burn locally compiled kernel
to our product due to secureboot protection.
But I think there is one possible option. We have reference Amlogic
boards somewhere in the office. So we can test 32-bit configuration on
it and prepare proper *.dts file for that. What do you think, it
reasanoble?
--
Thank you,
Dmitry
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-02-27 14:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 11:50 [PATCH v1 0/3] Meson A1 32-bit support Alexey Romanov
2023-02-22 11:50 ` [PATCH v1 1/3] meson: pinctrl: use CONFIG_PINCTRL_A1 with CONFIG_ARM Alexey Romanov
2023-03-06 13:45 ` Linus Walleij
2023-03-06 13:49 ` neil.armstrong
2023-03-06 13:52 ` Linus Walleij
2023-02-22 11:50 ` [PATCH v1 2/3] firmware: meson: use CONFIG_MESON_SM " Alexey Romanov
2023-02-22 11:50 ` [PATCH v1 3/3] arch/arm: dts: introduce meson-a1 device tree Alexey Romanov
2023-02-23 9:08 ` Krzysztof Kozlowski
2023-02-23 9:09 ` Krzysztof Kozlowski
2023-02-27 14:39 ` Dmitry Rokosov [this message]
2023-02-27 14:41 ` Krzysztof Kozlowski
2023-02-27 8:15 ` [PATCH v1 0/3] Meson A1 32-bit support neil.armstrong
2023-02-27 14:28 ` Dmitry Rokosov
2023-02-27 14:46 ` neil.armstrong
2023-02-27 16:01 ` Dmitry Rokosov
2023-02-27 14:58 ` Arnd Bergmann
2023-02-27 15:51 ` Dmitry Rokosov
2023-02-27 16:15 ` Arnd Bergmann
2023-02-27 16:37 ` Dmitry Rokosov
2023-02-27 16:38 ` Neil Armstrong
2023-02-27 16:50 ` Dmitry Rokosov
2023-02-27 18:19 ` Arnd Bergmann
2023-02-28 8:49 ` Dmitry Rokosov
2023-03-09 21:52 ` Kevin Hilman
2023-03-10 15:20 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227143929.h2lppesdiaj7l3gn@CAB-WSD-L081021 \
--to=ddrokosov@sberdevices.ru \
--cc=avromanov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®