From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38B45C74A5B for ; Fri, 17 Mar 2023 20:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OBYYsDbBqisqyNaMT0VNsyS83cm5pnSAMecux8GODHA=; b=yr6FWyGlMj8WV2 mwje34dl/FAkPUfE6GUWr5D0vlOKDoT583KSC5l3fYNvwSaBHlhn2N7V20QZ2nlRE7Ko8SxYfHujN 5koX99DwboGa28RsLL0DL0cNpEGTGZbfTJEKeGoC16kO9n70W/ludet/PBC2us6+cOLiPrxfqupA8 kaDvQeNWyrbcMSPL5G+S1cIus6ldbCwGnwiTCmTzTGkgtb3iFg20zqU8ZYsS7dVI4dJ5xnIgObM4o X9DYeYij4qT4ke8G4cMkxFKJcx1nUrXvlnS8uBRAO9aLo3ej0XKi9sIZA4UTpJdQqmlJOA90nXOSF +Co77jr8qdmMF6JR0DTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdGgF-003Idj-0D; Fri, 17 Mar 2023 20:28:03 +0000 Received: from mx.sberdevices.ru ([45.89.227.171]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdGgB-003Ic6-2q; Fri, 17 Mar 2023 20:28:01 +0000 Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 539265FD4F; Fri, 17 Mar 2023 23:27:52 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1679084872; bh=9klZq5XNmdsCI8Jf4BIs+c2sADGKOJ1gBsYtYIHMRbs=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=XZLGSNSDmTYCZb7s7O8f3ZHMIYyHbCaPHo56b39hLpJh8r2PPMyPdt6JZf/f58gS6 348VQBGsQwgKna4KcBjfocVat4Lqe47Se+jPzZVU/R2rBfpLoY1XV5J9SdDnY/MhuD nEQmoM7C4NtEflIqujh+NYYR6c0/dYiZ2pSZIDpWO/wkYg9ssjJ8UCokIFIKbMHW4O wrMnu9VEuqIb6kJwYg6uDZFbq4+xVLkxvqCB/1BdyNc2QmNUJgg2jzPqIkAyQSsUIV 4ehY8/Xe9OvmJIHSZFZWjeQXbTyfcDZK5fT93/oA8Zjv4VhwxaKfF9gR7OjPIoDThE zH5yyfYc2Jekg== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Fri, 17 Mar 2023 23:27:49 +0300 (MSK) Date: Fri, 17 Mar 2023 23:27:48 +0300 From: Dmitry Rokosov To: Rob Herring , Krzysztof Kozlowski CC: , , , , , , , , , , , , , , Subject: Re: [PATCH v10 3/5] dt-bindings: clock: meson: add A1 PLL and Peripherals clkcs bindings Message-ID: <20230317202748.7ctqhswettiemwi7@CAB-WSD-L081021> References: <20230313201259.19998-1-ddrokosov@sberdevices.ru> <20230313201259.19998-4-ddrokosov@sberdevices.ru> <20230314114825.yiv4vcszr6b7m45w@CAB-WSD-L081021> <20230317185317.GA2608140-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230317185317.GA2608140-robh@kernel.org> User-Agent: NeoMutt/20220415 X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/03/17 17:26:00 #20964929 X-KSMG-AntiVirus-Status: Clean, skipped X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_132800_298877_40D3AB8E X-CRM114-Status: GOOD ( 23.67 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 01:53:17PM -0500, Rob Herring wrote: > On Tue, Mar 14, 2023 at 02:48:25PM +0300, Dmitry Rokosov wrote: > > On Tue, Mar 14, 2023 at 12:28:40PM +0100, Krzysztof Kozlowski wrote: > > > On 13/03/2023 21:12, Dmitry Rokosov wrote: > > > > [...] > > > > > > +#define CLKID_SPIFC 84 > > > > +#define CLKID_USB_BUS 85 > > > > +#define CLKID_SD_EMMC 86 > > > > +#define CLKID_PSRAM 87 > > > > +#define CLKID_DMC 88 > > > > > > And what is here? Between 88 and 121? > > > > > > > Explained below. > > > > > > +#define CLKID_GEN_SEL 121 > > > > + > > > > +#endif /* __A1_CLKC_H */ > > > > diff --git a/include/dt-bindings/clock/amlogic,a1-pll-clkc.h b/include/dt-bindings/clock/amlogic,a1-pll-clkc.h > > > > new file mode 100644 > > > > index 000000000000..8e97d3fb9d30 > > > > --- /dev/null > > > > +++ b/include/dt-bindings/clock/amlogic,a1-pll-clkc.h > > > > @@ -0,0 +1,20 @@ > > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > > > I found in changelog: > > > "fix license issue, it's GPL-2.0+ only in the current version" > > > and I do not understand. > > > > > > The license is wrong, so what did you fix? > > > > > > > Sorry don't get you. Why is it wrong? > > I've changed all new source files to GPL-2.0+ except yaml, because yaml > > dt bindings schemas require the following license: > > Why 2.0+? The kernel's default license is 2.0-only. Are you (and > your lawyer) okay with GPL v4? > > But this is still part of the DT binding and has the same license > preference: > > > # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > However, the header licenses are complicated due to .dts licenses which > are all over the place. The requirement is dual licensed and matching > what includes it. Agree with you. As we discussed with Krzysztof, checkpatch must verify such wrong license tags. I've introduced the patchset for that, please take a look: https://lore.kernel.org/all/20230317201621.15518-1-ddrokosov@sberdevices.ru/ -- Thank you, Dmitry _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic