From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 645B0C77B6F for ; Tue, 11 Apr 2023 11:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jKDoaBHcG/zk3IZi6OWxYq4h0IHhNNqbry8XQ2vdBXg=; b=1CyWGItIVp+1eghSaSWeBv8d9d ROiFa6r8OUJfa4YIDT+UFMNVBUphBWKyIOMDurGIVXBhVoQ1WORPCezd8sJx37xkGwKUourjKm8T7 F86rxgEmcCcT/GTOurs5H60fXz2VDRtgYzbsIWD+Wg+9qna7+PntBjpQgQkl/O+OLo5UbTi9WxS9b GUwxqDj3ue/rrZ3tI/IlwF41ZinCbm7u39xZNtemcZgjGCHFBdQU9GT31dVcL+y0UByMaJy8b/1pJ vRTVjKq3ntVWfC/v5nNT9I+N7OsTjsb7GpY10L07vLq6hyTAPyarf9gzf2QBJtc4WFUyUNuIJaPey AtuG/PEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmBvz-00HQ8P-36; Tue, 11 Apr 2023 11:13:11 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmBvx-00HQ6q-08 for linux-amlogic@lists.infradead.org; Tue, 11 Apr 2023 11:13:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmBv0-0004gl-Lm; Tue, 11 Apr 2023 13:12:10 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pmBuf-00AURe-AU; Tue, 11 Apr 2023 13:11:49 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pmBue-00CH5H-AL; Tue, 11 Apr 2023 13:11:48 +0200 Date: Tue, 11 Apr 2023 13:11:48 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Miquel Raynal Cc: Alexandre Belloni , Valentin Korenblit , Lucas Stach , Vignesh Raghavendra , Linus Walleij , Alexandre Torgue , Stefan Agner , Nicolas Ferre , Paul Cercueil , Matthias Brugger , Liang Yang , Naga Sureshkumar Relli , Christophe Leroy , Han Xu , Chuanhong Guo , linux-stm32@st-md-mailman.stormreply.com, Heiko Stuebner , Marek =?utf-8?B?QmVow7pu?= , Samuel Holland , Kevin Hilman , Chen-Yu Tsai , Jernej Skrabec , Jonathan Hunter , linux-rockchip@lists.infradead.org, Tudor Ambarus , Geert Uytterhoeven , Miaoqian Lin , Yang Yingliang , Kyungmin Park , Jack Wang , Jerome Brunet , linux-sunxi@lists.linux.dev, ye xingchen , Maxime Coquelin , Arnd Bergmann , Manivannan Sadhasivam , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Vladimir Zapolskiy , Roger Quadros , Wang Weiyang , Harvey Hunt , linux-mediatek@lists.infradead.org, linux-mtd@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Neil Armstrong , Christophe Kerello , Stephen Boyd , Dmitry Torokhov , linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Krzysztof Kozlowski , Thierry Reding , kernel@pengutronix.de, Richard Weinberger , Christophe JAILLET , linux-oxnas@groups.io, Pali =?utf-8?B?Um9ow6Fy?= , Claudiu Beznea Subject: Re: [PATCH] mtd: nand: Convert to platform remove callback returning void Message-ID: <20230411111148.yefmzohsvk3facq3@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> <20230407101043.299f5e22@xps-13> <20230408185332.d2g2ao4tdp6ltm4i@pengutronix.de> <20230411102025.6b2fdc9e@xps-13> MIME-Version: 1.0 In-Reply-To: <20230411102025.6b2fdc9e@xps-13> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-amlogic@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_041309_085133_BEBFE616 X-CRM114-Status: GOOD ( 36.48 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5838830913231948659==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============5838830913231948659== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="he6vq5knkogtd7j7" Content-Disposition: inline --he6vq5knkogtd7j7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Miquel, On Tue, Apr 11, 2023 at 10:20:25AM +0200, Miquel Raynal wrote: > > On Fri, Apr 07, 2023 at 10:10:43AM +0200, Miquel Raynal wrote: > > > I've looked at the different patches, they look good to me but as they > > > are all trivial and exactly identical, would you mind sending this > > > again all squashed in a single patch? A subsystem-wide conversion see= ms > > > appropriate. In all cases I plan to take this for the next merge > > > window. =20 > >=20 > > I slightly prefer them separately, because I like small patches and > > because the Acks and Reviews only apply to the individual drivers. > > But I don't mind seriously, so here comes the series squashed into one. >=20 > For any non trivial change, I would definitely do that as well. A patch is only trivial as long as it doesn't do anything wrong. I don't assume any problem, but it wouldn't be the first. The first was bcm2835_spi_remove() being used in bcm2835_spi_shutdown(). > The thing is, by collecting the tags with b4, you lost all the Acks and > Reviews targets, while we could prevent this, see below. >=20 > > While going through the changed, probably the s3c24xx driver (which > > isn't exactly identical to the other changes) could benefit from an > > additional change throwing out the early exit (which---I guess---cannot > > be hit). >=20 > Yes, I believe the 'info =3D=3D NULL' condition is useless, feel free to > drop it in a second patch if you wish. Yeah. > > BTW, I constructed the lists of acks/reviews myself and found the same > > set. However b4 wailed about each patch claiming: > >=20 > > =E2=9C=97 BADSIG: DKIM/infradead.org >=20 > No idea what this means, any pointer? lists.infradead.org signs all outgoing mail and something between these outgoing mails and b4 consuming them breaks the signature. I didn't debug, but depending on where the problem is, either postmaster@lists.infradead.org or the admins of lore.kernel.org or the maintainer of b4 might want to know and fix. > > And it didn't like you producing the tags, saying: > >=20 > > NOTE: some trailers ignored due to from/email mismatches: > > ! Trailer: Acked-by: Roger Quadros > > Msg From: Miquel Raynal > > [...] >=20 > Well, yes, I don't expect b4 to read plain english when I say "I > collected them for you" ^^ But at least my list had a '# ' suffix > for each of the Acked and Reviewed changes, which is now missing. I > don't know how useful they actually are, but it seems to me that the > information was lost between v1 and v2? That's right. I will resend in a separate thread with the annotations fixed. Sorry for the noise. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=C3=B6nig = | Industrial Linux Solutions | https://www.pengutronix.de/ | --he6vq5knkogtd7j7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmQ1QHMACgkQj4D7WH0S /k59PQgApmYCdD89s3AZJOYu84R1sSO13lJD2sW2YG/826FnsTQ8v5JAAMkZRhMV k+MCufvC25ennRcrXR5Uv8O1rreswBF1+9WhnWNEGGzaOsRqvVjkbsrMHgpJUsh3 FMlNyvjm6KpNJhqF46lITimOhkWph7CAmCq1OMnfs5D1/biK19XqlwyNlOrka0XW 8dwB13fYwc9PnEdLkyfmzqtcQbGBezwBjXzPkAls4+2qwIJkinKwMZACrpKd1VUr VOROg0xogL+KfIkaVvPu4UQTs2jpIf13YnyBfynr+pg81qKqHh6lHeS9zaMbTEhM JRbE//97QsOix1ZjsQHXvFD4zk8yjQ== =LsjF -----END PGP SIGNATURE----- --he6vq5knkogtd7j7-- --===============5838830913231948659== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============5838830913231948659==--