From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: "Vignesh Raghavendra" <vigneshr@ti.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Naga Sureshkumar Relli" <nagasure@xilinx.com>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Yang Yingliang" <yangyingliang@huawei.com>,
"ye xingchen" <ye.xingchen@zte.com.cn>,
"Valentin Korenblit" <vkorenblit@sequans.com>,
"Wang Weiyang" <wangweiyang2@huawei.com>,
"Pali Rohár" <pali@kernel.org>, "Marek Behún" <kabel@kernel.org>,
"Han Xu" <han.xu@nxp.com>,
"Harvey Hunt" <harveyhuntnexus@gmail.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Liang Yang" <liang.yang@amlogic.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Phil Edworthy" <phil.edworthy@renesas.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Chuanhong Guo" <gch981213@gmail.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miaoqian Lin" <linmq006@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Christophe Kerello" <christophe.kerello@foss.st.com>,
"Jack Wang" <jinpu.wang@ionos.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Stefan Agner" <stefan@agner.ch>, "Lucas Stach" <dev@lynxeye.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Richard Weinberger" <richard@nod.at>,
linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org,
linux-sunxi@lists.linux.dev, linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-mtd@lists.infradead.org, kernel@pengutronix.de,
linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-amlogic@lists.infradead.org,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Thierry Reding" <treding@nvidia.com>
Subject: Re: [PATCH v3] mtd: nand: Convert to platform remove callback returning void
Date: Tue, 11 Apr 2023 15:43:04 +0200 [thread overview]
Message-ID: <20230411134305.445759-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20230411113816.3472237-1-u.kleine-koenig@pengutronix.de>
On Tue, 2023-04-11 at 11:38:16 UTC, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Acked-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> # atmel
> Reviewed-by: Paul Cercueil <paul@crapouillou.net> # ingenic
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> # ingenic
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> # intel
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> # meson
> Acked-by: Roger Quadros <rogerq@kernel.org> # omap_elm
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> # renesas
> Reviewed-by: Heiko Stuebner <heiko@sntech.de> # rockchip
> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> # sunxi
> Acked-by: Thierry Reding <treding@nvidia.com> # tegra
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2023-04-11 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 11:38 Uwe Kleine-König
2023-04-11 13:43 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411134305.445759-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=christophe.kerello@foss.st.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.beznea@microchip.com \
--cc=dev@lynxeye.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gch981213@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=han.xu@nxp.com \
--cc=harveyhuntnexus@gmail.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jinpu.wang@ionos.com \
--cc=jonathanh@nvidia.com \
--cc=kabel@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=liang.yang@amlogic.com \
--cc=linmq006@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nagasure@xilinx.com \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=pali@kernel.org \
--cc=paul@crapouillou.net \
--cc=phil.edworthy@renesas.com \
--cc=philmd@linaro.org \
--cc=richard@nod.at \
--cc=rogerq@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=tudor.ambarus@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
--cc=vkorenblit@sequans.com \
--cc=vz@mleia.com \
--cc=wangweiyang2@huawei.com \
--cc=wens@csie.org \
--cc=yangyingliang@huawei.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®