From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8FC4C7EE26 for ; Mon, 22 May 2023 13:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cKGo0PXz76uVhnAHoNU7UpeuLE/cvtHqtk2GbnNlVI4=; b=Z2Z2A+qxz2jXtH aiJExxelxTVaqoEvp8GDcYV3dDVZzfLkgb28n6mEganvVShxUZm2qrpNzgCLO8l62T74BTCk1IClH TIa4fliCPiNmiRUNCRwulwYxB/x3vNuMDer7Fu8ByS3BR9OpgMoK4kS619TqsqbJk2Bk6866VhwrC 4mXWeg6w/CrjB+NTm/IY4Kzf7yLESKfJsP06C//72Mlx2J98AiikqHV38C9NCgmkgit4pYIoOy4oQ Wnmx9/wHLN/CAvzwD/e+NXvWivj9InMCPCzSTqh10EpxXxRD7MWN+e0jjCI9GA4yAUp8dstiX+051 5z9aKJBuN/TY98PWTTFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q15jO-006gsw-39; Mon, 22 May 2023 13:37:46 +0000 Received: from mx.sberdevices.ru ([45.89.227.171]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q15jM-006gsF-1Z; Mon, 22 May 2023 13:37:46 +0000 Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 8EF5F5FD55; Mon, 22 May 2023 16:37:41 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1684762661; bh=AKNZnZ3MIqRpo1EsWlSggyW5gd6htKVBAOKl55rHHWg=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=lHGSWGOwIBtr+SOagZxDHlp1TiuCpz/CVQCo1VezIdnJ2eKee1HdvrrEfaUeUv2eh S9H7PlIe+IdomzPSJiPU81hbl+pl4Exs2K9EhX37v0TEI05CXfESFJs9ZracunGyJq CJlk/B5N5oZO6G/t5gQfhZiFUQvDxSSkdNUbEVS2An7R+y/A5ha5StQJ78NFTxiAO5 99z+lmI4R5AZGFyVAZcoU3S5qGtgNWKj6uNuuZuy+GzS6/6tOUqxvjLG2A1uYMbedy 1/QGLZf58tCTHEbuaiDmJnUmKVcf4c0dgRAx9Y/GnA4eOmqP5yzeaePECPL7O/XLQs BKraRKcDOUVMQ== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Mon, 22 May 2023 16:37:41 +0300 (MSK) Date: Mon, 22 May 2023 16:37:39 +0300 From: Dmitry Rokosov To: Heiner Kallweit CC: Jerome Brunet , Martin Blumenstingl , Neil Armstrong , Kevin Hilman , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "thierry.reding@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." , "linux-pwm@vger.kernel.org" , "rockosov@gmail.com" , kernel Subject: Re: [PATCH v4 4/4] pwm: meson: make full use of common clock framework Message-ID: <20230522133739.7tc35zr2npsysopd@CAB-WSD-L081021> References: <9faca2e6-b7a1-4748-7eb0-48f8064e323e@gmail.com> <29961a2e-5367-0685-0f3a-1910328ad3ab@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <29961a2e-5367-0685-0f3a-1910328ad3ab@gmail.com> User-Agent: NeoMutt/20220415 X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/05/22 08:14:00 #21365129 X-KSMG-AntiVirus-Status: Clean, skipped X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230522_063744_875084_8A317981 X-CRM114-Status: GOOD ( 45.07 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Heiner, On Fri, May 19, 2023 at 06:53:30PM +0200, Heiner Kallweit wrote: > On 19.05.2023 17:30, Dmitry Rokosov wrote: > > Hello Heiner, > > > > Thank you for the patch series! > > > > I am currently working on the Amlogic A1 clock driver and other > > peripheral devices, including PWM. During a discussion about the clock > > driver with Martin Blumenstingl, we found an intersection between the > > clock driver and your PWM CCF support patch series. Please see my > > comments below. > > > > On Thu, Apr 13, 2023 at 07:54:46AM +0200, Heiner Kallweit wrote: > >> Newer versions of the PWM block use a core clock with external mux, > >> divider, and gate. These components either don't exist any longer in > >> the PWM block, or they are bypassed. > >> To minimize needed changes for supporting the new version, the internal > >> divider and gate should be handled by CCF too. > >> > >> I didn't see a good way to split the patch, therefore it's somewhat > >> bigger. What it does: > >> > >> - The internal mux is handled by CCF already. Register also internal > >> divider and gate with CCF, so that we have one representation of the > >> input clock: [mux] parent of [divider] parent of [gate] > >> > >> - Now that CCF selects an appropriate mux parent, we don't need the > >> DT-provided default parent any longer. Accordingly we can also omit > >> setting the mux parent directly in the driver. > >> > >> - Instead of manually handling the pre-div divider value, let CCF > >> set the input clock. Targeted input clock frequency is > >> 0xffff * 1/period for best precision. > >> > >> - For the "inverted pwm disabled" scenario target an input clock > >> frequency of 1GHz. This ensures that the remaining low pulses > >> have minimum length. > >> > >> I don't have hw with the old PWM block, therefore I couldn't test this > >> patch. With the not yet included extension for the new PWM block > >> (channel->clk coming directly from get_clk(external_clk)) I didn't > >> notice any problem. My system uses PWM for the CPU voltage regulator > >> and for the SDIO 32kHz clock. > >> > >> Note: The clock gate in the old PWM block is permanently disabled. > >> This seems to indicate that it's not used by the new PWM block. > >> > >> Tested-by: Martin Blumenstingl > >> Signed-off-by: Heiner Kallweit > >> --- > >> Changes to RFT/RFC version: > >> - use parent_hws instead of parent_names for div/gate clock > >> - use devm_clk_hw_register where the struct clk * returned by > >> devm_clk_register isn't needed > >> > >> v2: > >> - add patch 1 > >> - add patch 3 > >> - switch to using clk_parent_data in all relevant places > >> v3: > >> - add flag CLK_IGNORE_UNUSED > >> v4: > >> - remove variable tmp in meson_pwm_get_state > >> - don't use deprecated function devm_clk_register > > > > [...] > > > >> @@ -166,7 +158,11 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm, > >> if (state->polarity == PWM_POLARITY_INVERSED) > >> duty = period - duty; > >> > >> - fin_freq = clk_get_rate(channel->clk); > >> + freq = div64_u64(NSEC_PER_SEC * (u64)0xffff, period); > >> + if (freq > ULONG_MAX) > >> + freq = ULONG_MAX; > >> + > >> + fin_freq = clk_round_rate(channel->clk, freq); > >> if (fin_freq == 0) { > >> dev_err(meson->chip.dev, "invalid source clock frequency\n"); > >> return -EINVAL; > > > > As mentioned previously, we have discussed one optimization for PWM > > parent clock calculation. Many modern Amlogic SoCs include an RTC clock > > within the clock tree. This clock provides a stable and efficient 32kHz > > input for several clock objects that can be inherited through the muxes > > from the RTC clock. > > > > In short, we aim to use the RTC clock parent directly for PWM to > > generate a 32kHz clock on the PWM lines. Martin has suggested one way to > > do so, which is described in [0]. You can also refer to our IRC > > discussion in [1]. > > > > I would appreciate your thoughts on this. Please let me know what you > > think. > > > > Requesting a frequency of (NSEC_PER_SEC * 0xffffULL / period) is based > on the assumption that the highest possible input frequency always > allows to generate a period that is close enough to the requested period. > > To find the best parent you'd need a somewhat more complex logic outside CCF. > What you want is the parent where (f_parent * period / NSEC_PER_SEC) is > closest to an integer in the range 1 .. 0xffff. > IOW: max(abs((f_parent * period) % 10^9 - 5 * 10^8)) > > This can be done, question is whether it's needed and worth the effort. > > This would be the generic solution. If you just want to handle the case > that period 1/32.768Hz is requested, an adjusted version of Martins's > pseudo-code formula should do. > Best I think as follow-up to my series. > Certainly, if possible, please include this special case in the next version of your series. Appreciate it! [...] -- Thank you, Dmitry _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic