Re: [PATCH 17/97] usb: dwc3-meson-g12a: Convert to platform remove callback returning void

[Thinh Nguyen <Thinh.Nguyen@synopsys.com>]

On Thu, May 18, 2023, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/usb/dwc3/dwc3-meson-g12a.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
> index b282ad0e69c6..7ed5a21fb441 100644
> --- a/drivers/usb/dwc3/dwc3-meson-g12a.c
> +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
> @@ -835,7 +835,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int dwc3_meson_g12a_remove(struct platform_device *pdev)
> +static void dwc3_meson_g12a_remove(struct platform_device *pdev)
>  {
>  	struct dwc3_meson_g12a *priv = platform_get_drvdata(pdev);
>  	struct device *dev = &pdev->dev;
> @@ -859,8 +859,6 @@ static int dwc3_meson_g12a_remove(struct platform_device *pdev)
>  
>  	clk_bulk_disable_unprepare(priv->drvdata->num_clks,
>  				   priv->drvdata->clks);
> -
> -	return 0;
>  }
>  
>  static int __maybe_unused dwc3_meson_g12a_runtime_suspend(struct device *dev)
> @@ -971,7 +969,7 @@ MODULE_DEVICE_TABLE(of, dwc3_meson_g12a_match);
>  
>  static struct platform_driver dwc3_meson_g12a_driver = {
>  	.probe		= dwc3_meson_g12a_probe,
> -	.remove		= dwc3_meson_g12a_remove,
> +	.remove_new	= dwc3_meson_g12a_remove,
>  	.driver		= {
>  		.name	= "dwc3-meson-g12a",
>  		.of_match_table = dwc3_meson_g12a_match,
> -- 
> 2.39.2
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

Thanks,
Thinh
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic