From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3E4EEB64DC for ; Fri, 30 Jun 2023 16:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xGomHMCIR5clL1EmDiOiYRCsRCmmt9rumK1NdLWav1Y=; b=MzIy7BIrqvg1k7 WE3aBhcEsIaqhNPLnwctZPIm2Ixll+Mfq/hEW77L5qoBblYKpKiqwkEWjEDMJ0Jjr6BjFMKFGWDy7 9VeQdQ4zG0Atg1VhZr9WWYdWim6hYbSUF4LBv2FAlXX5v0Qbcpz7+KLTMbec9oxPpD/xKrY8EeB4M OXmp+HwsB8q+itWhiifE+fc9cepxkzVbntdawL1+zKfzPLGDzJ0H1HcJ1e5OVdgDpgGAon6Gnt7cj 47h5qy41vjnnonqjHpJ5LiunRx3a1okwSxZNNgEW/XBm/yDXuwO/qVXKlshl8t4Cc0RaqHdkkHMDO bUAmxnZiDXDXq54iefgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qFGg7-0041AB-01; Fri, 30 Jun 2023 16:08:59 +0000 Received: from mx2.sberdevices.ru ([45.89.224.132] helo=mx1.sberdevices.ru) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qFGg2-00419a-1R; Fri, 30 Jun 2023 16:08:56 +0000 Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id C2A76120003; Fri, 30 Jun 2023 19:08:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru C2A76120003 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1688141296; bh=tew1tnZO8hwm+JrVklOoMpSXLzjwa5EjAV/R8Wtp73k=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=J+azTb6wPZrcjtN/J0pNJNcdV8bnSyUWdQ/M7stqZInQ54dnD74H2F2Sb/pLRUqA7 gjDcYw5JXb65CvoG+j0HLmJuWUBLc9NXCpSDMYQ4NVwlHo4iHyjYCkeUK25wT+uI2o LvWCZuXS4443SLRkghj8ucY6cyyTu528xS1jt+PtKOH4IPbnF0iTrLptoVI82Lb+YB nl4PQ6PUzwQG1nNbB9v6wMaqjcOmaoVfvUAtEod+cfYIn+nw8RbtvwTLDc2Q2Ir0mg vN9X4rRR8Hd4YWgLGGqjepCovnq2lJTSgUigeBumooc0fOL/te1KqETyiE2k5MCnOJ smxeDjHrYEuQA== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Fri, 30 Jun 2023 19:08:15 +0300 (MSK) Received: from localhost (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 30 Jun 2023 19:08:02 +0300 Date: Fri, 30 Jun 2023 19:08:15 +0300 From: Dmitry Rokosov To: zelong dong CC: , , , Rob Herring , , , , , , , Subject: Re: [PATCH 1/3] dt-bindings: reset: Add compatible and DT bindings for Meson-C3 Reset Controller Message-ID: <20230630160815.ayhuixn3pzbgmqlw@CAB-WSD-L081021> References: <20230630121059.28748-1-zelong.dong@amlogic.com> <20230630121059.28748-2-zelong.dong@amlogic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230630121059.28748-2-zelong.dong@amlogic.com> User-Agent: NeoMutt/20220415 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 178380 [Jun 30 2023] X-KSMG-AntiSpam-Version: 5.9.59.0 X-KSMG-AntiSpam-Envelope-From: DDRokosov@sberdevices.ru X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 517 517 b0056c19d8e10afbb16cb7aad7258dedb0179a79, {Tracking_uf_ne_domains}, {Track_E25351}, {Tracking_from_domain_doesnt_match_to}, p-i-exch-sc-m01.sberdevices.ru:5.0.1,7.1.1;100.64.160.123:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;sberdevices.ru:5.0.1,7.1.1;lists.infradead.org:7.1.1;127.0.0.199:7.1.2, FromAlignment: s, {Tracking_white_helo}, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean, bases: 2023/06/30 14:28:00 X-KSMG-LinksScanning: Clean, bases: 2023/06/30 14:28:00 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/06/30 12:24:00 #21606311 X-KSMG-AntiVirus-Status: Clean, skipped X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230630_090854_850401_CD26A83A X-CRM114-Status: GOOD ( 23.63 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hello Zelong, Thank you for the patch! Please find my notes below. On Fri, Jun 30, 2023 at 08:10:57PM +0800, zelong dong wrote: > From: Zelong Dong > > Add new compatible and DT bindings for Amlogic's Meson-C3 Reset Controller > > Change-Id: Ie8941818bde5b736689e43367f66827c5bc0449e > Signed-off-by: Zelong Dong > --- > .../bindings/reset/amlogic,meson-reset.yaml | 1 + > .../reset/amlogic,meson-c3-reset.h | 119 ++++++++++++++++++ > 2 files changed, 120 insertions(+) > create mode 100644 include/dt-bindings/reset/amlogic,meson-c3-reset.h > > diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml > index d3fdee89d4f8..cf1da9f7bc51 100644 > --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml > +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml > @@ -18,6 +18,7 @@ properties: > - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs > - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs > - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs > + - amlogic,meson-c3-reset # Reset Controller on C3 and compatible SoCs > > reg: > maxItems: 1 > diff --git a/include/dt-bindings/reset/amlogic,meson-c3-reset.h b/include/dt-bindings/reset/amlogic,meson-c3-reset.h > new file mode 100644 > index 000000000000..24b39d60b2f7 > --- /dev/null > +++ b/include/dt-bindings/reset/amlogic,meson-c3-reset.h > @@ -0,0 +1,119 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ Please fix the license issue, you can get it from checkpatch: $ scripts/checkpatch.pl --strict include/dt-bindings/reset/amlogic,meson-c3-reset.h WARNING: DT binding headers should be licensed (GPL-2.0-only OR .*) #1: FILE: include/dt-bindings/reset/amlogic,meson-c3-reset.h:1: +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ total: 0 errors, 1 warnings, 0 checks, 119 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. include/dt-bindings/reset/amlogic,meson-c3-reset.h has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. > +/* > + * Copyright (c) 2023 Amlogic, Inc. All rights reserved. > + */ > + > +#ifndef _DT_BINDINGS_AMLOGIC_MESON_C3_RESET_H > +#define _DT_BINDINGS_AMLOGIC_MESON_C3_RESET_H > + > +/* RESET0 */ > +/* 0-3 */ > +#define RESET_USBCTRL 4 > +/* 5-7 */ > +#define RESET_USBPHY20 8 > +/* 9 */ > +#define RESET_USB2DRD 10 > +#define RESET_MIPI_DSI_HOST 11 > +#define RESET_MIPI_DSI_PHY 12 > +/* 13-20 */ > +#define RESET_GE2D 21 > +#define RESET_DWAP 22 > +/* 23-31 */ > + > +/* RESET1 */ > +#define RESET_AUDIO 32 > +/* 33-34 */ > +#define RESET_DDRAPB 35 > +#define RESET_DDR 36 > +#define RESET_DOS_CAPB3 37 > +#define RESET_DOS 38 > +/* 39-46 */ > +#define RESET_NNA 47 > +#define RESET_ETHERNET 48 > +#define RESET_ISP 49 > +#define RESET_VC9000E_APB 50 > +#define RESET_VC9000E_A 51 > +/* 52 */ > +#define RESET_VC9000E_CORE 53 > +/* 54-63 */ > + > +/* RESET2 */ > +#define RESET_ABUS_ARB 64 > +#define RESET_IRCTRL 65 > +/* 66 */ > +#define RESET_TEMP_PII 67 > +/* 68-72 */ > +#define RESET_SPICC_0 73 > +#define RESET_SPICC_1 74 > +#define RESET_RSA 75 > + > +/* 76-79 */ > +#define RESET_MSR_CLK 80 > +#define RESET_SPIFC 81 > +#define RESET_SAR_ADC 82 > +/* 83-87 */ > +#define RESET_ACODEC 88 > +/* 89-90 */ > +#define RESET_WATCHDOG 91 > +/* 92-95 */ > + > +/* RESET3 */ > +#define RESET_ISP_NIC_GPV 96 > +#define RESET_ISP_NIC_MAIN 97 > +#define RESET_ISP_NIC_VCLK 98 > +#define RESET_ISP_NIC_VOUT 99 > +#define RESET_ISP_NIC_ALL 100 > +#define RESET_VOUT 101 > +#define RESET_VOUT_VENC 102 > +/* 103 */ > +#define RESET_CVE_NIC_GPV 104 > +#define RESET_CVE_NIC_MAIN 105 > +#define RESET_CVE_NIC_GE2D 106 > +#define RESET_CVE_NIC_DW 106 > +#define RESET_CVE_NIC_CVE 108 > +#define RESET_CVE_NIC_ALL 109 > +#define RESET_CVE 110 > +/* 112-127 */ > + > +/* RESET4 */ > +#define RESET_RTC 128 > +#define RESET_PWM_AB 129 > +#define RESET_PWM_CD 130 > +#define RESET_PWM_EF 131 > +#define RESET_PWM_GH 132 > +#define RESET_PWM_IJ 133 > +#define RESET_PWM_KL 134 > +#define RESET_PWM_MN 135 > +/* 136-137 */ > +#define RESET_UART_A 138 > +#define RESET_UART_B 139 > +#define RESET_UART_C 140 > +#define RESET_UART_D 141 > +#define RESET_UART_E 142 > +#define RESET_UART_F 143 > +#define RESET_I2C_S_A 144 > +#define RESET_I2C_M_A 145 > +#define RESET_I2C_M_B 146 > +#define RESET_I2C_M_C 147 > +#define RESET_I2C_M_D 148 > +/* 149-151 */ > +#define RESET_SD_EMMC_A 152 > +#define RESET_SD_EMMC_B 153 > +#define RESET_SD_EMMC_C 154 > + > +/* RESET5 */ > +/* 160-172 */ > +#define RESET_BRG_NIC_NNA 173 > +#define RESET_BRG_MUX_NIC_MAIN 174 > +#define RESET_BRG_AO_NIC_ALL 175 > +/* 176-183 */ > +#define RESET_BRG_NIC_VAPB 184 > +#define RESET_BRG_NIC_SDIO_B 185 > +#define RESET_BRG_NIC_SDIO_A 186 > +#define RESET_BRG_NIC_EMMC 187 > +#define RESET_BRG_NIC_DSU 188 > +#define RESET_BRG_NIC_SYSCLK 189 > +#define RESET_BRG_NIC_MAIN 190 > +#define RESET_BRG_NIC_ALL 191 > + > +#endif > -- > 2.35.1 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic -- Thank you, Dmitry _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic