From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
To: zelong dong <zelong.dong@amlogic.com>
Cc: <narmstrong@baylibre.com>, <p.zabel@pengutronix.de>,
<khilman@baylibre.com>, Rob Herring <robh+dt@kernel.org>,
<martin.blumenstingl@googlemail.com>,
<linux-kernel@vger.kernel.org>,
<linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>, <jbrunet@baylibre.com>,
<devicetree@vger.kernel.org>, <kelvin.zhang@amlogic.com>
Subject: Re: [PATCH 3/3] arm64: dts: meson: add reset controller for Meson-C3 SoC
Date: Fri, 30 Jun 2023 19:16:33 +0300 [thread overview]
Message-ID: <20230630161633.eym2dhxaffn2uxfv@CAB-WSD-L081021> (raw)
In-Reply-To: <20230630121059.28748-4-zelong.dong@amlogic.com>
Hello Zelong,
Thanks a lot for the patch, please find my comments below.
On Fri, Jun 30, 2023 at 08:10:59PM +0800, zelong dong wrote:
> From: Zelong Dong <zelong.dong@amlogic.com>
>
> Add the reset controller device of Meson-C3 SoC family
>
> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
> ---
> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> index 60ad4f3eef9d..62684b7a684c 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> @@ -6,6 +6,7 @@
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/reset/amlogic,meson-c3-reset.h>
>
> / {
> cpus {
> @@ -82,6 +83,12 @@ uart_b: serial@7a000 {
> clock-names = "xtal", "pclk", "baud";
> };
>
> + reset: reset-controller@0x2000 {
> + compatible = "amlogic,meson-c3-reset";
> + reg = <0x0 0x2000 0x0 0x98>;
> + #reset-cells = <1>;
> + };
> +
As Martin mentioned in the my review, internal apb entries should be
sorted by base reg offset. So reset-controller must be located before
uart_b.
Please refer to:
https://lore.kernel.org/linux-amlogic/CAFBinCAO14zcgY66UyJO9UxuCWf1N-Lsx=iYNTJL=cwXoJv__Q@mail.gmail.com/
> };
> };
> };
> --
> 2.35.1
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
--
Thank you,
Dmitry
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-06-30 16:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 12:10 [PATCH 0/3] reset: meson-c3: add reset driver zelong dong
2023-06-30 12:10 ` [PATCH 1/3] dt-bindings: reset: Add compatible and DT bindings for Meson-C3 Reset Controller zelong dong
2023-06-30 16:08 ` Dmitry Rokosov
2023-06-30 16:31 ` Neil Armstrong
2023-07-02 9:33 ` Krzysztof Kozlowski
2023-06-30 12:10 ` [PATCH 2/3] reset: reset-meson: add support for the Meson-C3 SoC " zelong dong
2023-06-30 15:59 ` Dmitry Rokosov
2023-07-03 19:42 ` Martin Blumenstingl
2023-06-30 12:10 ` [PATCH 3/3] arm64: dts: meson: add reset controller for Meson-C3 SoC zelong dong
2023-06-30 16:16 ` Dmitry Rokosov [this message]
2023-06-30 16:32 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630161633.eym2dhxaffn2uxfv@CAB-WSD-L081021 \
--to=ddrokosov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kelvin.zhang@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=zelong.dong@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®