From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED60CC4332F for ; Thu, 2 Nov 2023 22:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kumPnNE98lMPy7DWunonn2VnEvg1JAFjXtGIYXbg4BM=; b=2EPLoUcUstDxLL 3agISD44AT99uSJzhOytVRg6BK2vEY4M+6s0ilPhmtcIKGMg+dXNyNGRVRXfq+CU2iTYLhrgwXXk/ fHVJD84LkFXnuuvuCcQ/0aWfSSW1m5ZIu/8PnkT1XoYcuMGIJ+5UxWEKW9oO27VfZOgjIq0Nw8VkH 2sK3lVPK/mP1lgfPROM9J7BDX8ZRNKIFQaY4CWLMYjlp6ZaRhwYqJ/2cfuiRCrISbB+DPI2NCqaM8 HeFAQFkZzbDL/HedL9s39BWrwPkdBkTBnJeHCXkLmgO4b+zntiY7wcdGPeZjx0dGx2wgajqF/Y/Wv tU9Gq9j84OwO8NTiUQvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyg2n-00ANbx-3D; Thu, 02 Nov 2023 22:20:06 +0000 Received: from mgamail.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qyg2h-00ANb1-1l; Thu, 02 Nov 2023 22:20:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698963599; x=1730499599; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pOomK60vReoHoxtpV622grZQ+xKJAZalF61nf6xRPAw=; b=H6F7YkNw/Mhq2Byof84dcD/Iu0t6CjQKz7WJepF0tQjdPjIypLyvgqHn XhW1sf3YQboM1nFky2QJboMuFyYub3eGPoMWsMYq2Zkc+4POf09N3ot2h sr+yi2Z9xF7zobcvMIewfqxhP/Soe3jxnykcWEUFiNKxhmNEeQhMoT7Ll Mscit4JztGmDUU0ZpntVl1p0X3LsJ1OqYI7FgAFM9FChk1/L9EMI0Peiu gxkgrPniAvS2AkF8pqd57NEKldR1NhG5O2t/S0Hb/tvi4bPwPQE3x5qlu L6c4WSF5JV8Us+DckiebjNhBvIgcliv6jp4mu2goTJHUF+sVXVj1IjT4y w==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="387718235" X-IronPort-AV: E=Sophos;i="6.03,272,1694761200"; d="scan'208";a="387718235" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 15:11:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="885020179" X-IronPort-AV: E=Sophos;i="6.03,272,1694761200"; d="scan'208";a="885020179" Received: from lkp-server01.sh.intel.com (HELO 17d9e85e5079) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 02 Nov 2023 15:11:37 -0700 Received: from kbuild by 17d9e85e5079 with local (Exim 4.96) (envelope-from ) id 1qyfuX-0001ui-02; Thu, 02 Nov 2023 22:11:33 +0000 Date: Fri, 3 Nov 2023 06:11:11 +0800 From: kernel test robot To: Viacheslav Bocharov , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev Subject: Re: [PATCH 2/4] firmware: meson_sm: Add chipid number sysfs entry Message-ID: <202311030513.HxyDUCuc-lkp@intel.com> References: <20231102074916.3280809-3-adeep@lexina.in> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231102074916.3280809-3-adeep@lexina.in> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231102_151959_599898_D694CB8B X-CRM114-Status: GOOD ( 18.15 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Viacheslav, kernel test robot noticed the following build errors: [auto build test ERROR on soc/for-next] [also build test ERROR on linus/master v6.6 next-20231102] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Viacheslav-Bocharov/firmware-meson-sm-change-sprintf-to-scnprintf/20231102-172556 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next patch link: https://lore.kernel.org/r/20231102074916.3280809-3-adeep%40lexina.in patch subject: [PATCH 2/4] firmware: meson_sm: Add chipid number sysfs entry config: arm64-randconfig-003-20231103 (https://download.01.org/0day-ci/archive/20231103/202311030513.HxyDUCuc-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231103/202311030513.HxyDUCuc-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311030513.HxyDUCuc-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/firmware/meson/meson_sm.c: In function 'chipid_show': >> drivers/firmware/meson/meson_sm.c:315:17: error: 'ch' undeclared (first use in this function) 315 | ch = (uint8_t *)(id_buf + 4); | ^~ drivers/firmware/meson/meson_sm.c:315:17: note: each undeclared identifier is reported only once for each function it appears in >> drivers/firmware/meson/meson_sm.c:316:22: error: 'i' undeclared (first use in this function) 316 | for (i = 0; i < 12; i++) | ^ vim +/ch +315 drivers/firmware/meson/meson_sm.c 277 278 static ssize_t chipid_show(struct device *dev, struct device_attribute *attr, 279 char *buf) 280 { 281 struct platform_device *pdev = to_platform_device(dev); 282 struct meson_sm_firmware *fw; 283 uint8_t *id_buf; 284 int ret; 285 286 fw = platform_get_drvdata(pdev); 287 288 id_buf = kmalloc(SM_CHIP_ID_LENGTH, GFP_KERNEL); 289 if (!id_buf) 290 return -ENOMEM; 291 292 ret = meson_sm_call_read(fw, id_buf, SM_CHIP_ID_LENGTH, SM_GET_CHIP_ID, 293 2, 0, 0, 0, 0); 294 if (ret < 0) { 295 kfree(id_buf); 296 return ret; 297 } 298 299 int version = *((unsigned int *)id_buf); 300 301 if (version == 2) 302 ret = scnprintf(buf, PAGE_SIZE, "%16phN\n", &id_buf[SM_CHIP_ID_OFFSET]); 303 else { 304 /** 305 * Legacy 12-byte chip ID read out, transform data 306 * to expected order format. 307 */ 308 uint8_t *buff; 309 310 buff = kmalloc(SM_CHIP_ID_LENGTH, GFP_KERNEL); 311 if (!buff) 312 return -ENOMEM; 313 ((uint32_t *)buff)[0] = 0; // CPU_ID is empty 314 /* Transform into expected order for display */ > 315 ch = (uint8_t *)(id_buf + 4); > 316 for (i = 0; i < 12; i++) 317 buff[i + 4] = ch[11 - i]; 318 ret = scnprintf(buf, PAGE_SIZE, "%16phN\n", &buff); 319 kfree(buff); 320 } 321 322 kfree(id_buf); 323 return ret; 324 } 325 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic