mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Dmitry Rokosov <ddrokosov@salutedevices.com>
To: Viacheslav Bocharov <adeep@lexina.in>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	<linux-amlogic@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [DMARC error][DKIM error] [PATCH 5/5] arm64: dts: meson: add dts links to secure-monitor for soc driver in a1, axg, gx, g12
Date: Wed, 22 Nov 2023 21:45:02 +0300	[thread overview]
Message-ID: <20231122184502.x4rxzvgmoaxbmhlr@CAB-WSD-L081021> (raw)
In-Reply-To: <20231122125643.1717160-6-adeep@lexina.in>

Hello Viacheslav,

On Wed, Nov 22, 2023 at 03:56:43PM +0300, Viacheslav Bocharov wrote:
> Add links to secure-monitor in soc driver section for A1, AXG, GX, G12
> Amlogic family.
> 
> Signed-off-by: Viacheslav Bocharov <adeep@lexina.in>
> ---
>  arch/arm64/boot/dts/amlogic/meson-a1.dtsi         | 1 +
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 1 +
>  arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 1 +
>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi         | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index 648e7f49424f..449b328d62b1 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -407,6 +407,7 @@ hwrng: rng@5118 {
>  			sec_AO: ao-secure@5a20 {
>  				compatible = "amlogic,meson-gx-ao-secure", "syscon";
>  				reg = <0x0 0x5a20 0x0 0x140>;
> +				secure-monitor = <&sm>;

I suppose it's better and more consistent to use the same hierarchy
pattern as Secure PWRC uses: to be a child of Secure Monitor.

Please see the example below from meson-a1.dtsi:


	sm: secure-monitor {
		compatible = "amlogic,meson-gxbb-sm";

		pwrc: power-controller {
			compatible = "amlogic,meson-a1-pwrc";
			#power-domain-cells = <1>;
		};
	};

>  				amlogic,has-chip-id;
>  			};
>  
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index a49aa62e3f9f..6e80bdc525e5 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -1660,6 +1660,7 @@ mux {
>  			sec_AO: ao-secure@140 {
>  				compatible = "amlogic,meson-gx-ao-secure", "syscon";
>  				reg = <0x0 0x140 0x0 0x140>;
> +				secure-monitor = <&sm>;
>  				amlogic,has-chip-id;
>  			};
>  
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index ff68b911b729..0a6b703b0dc0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -2026,6 +2026,7 @@ cec_AO: cec@100 {
>  			sec_AO: ao-secure@140 {
>  				compatible = "amlogic,meson-gx-ao-secure", "syscon";
>  				reg = <0x0 0x140 0x0 0x140>;
> +				secure-monitor = <&sm>;
>  				amlogic,has-chip-id;
>  			};
>  
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index 2673f0dbafe7..656e08b3d872 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -471,6 +471,7 @@ cec_AO: cec@100 {
>  			sec_AO: ao-secure@140 {
>  				compatible = "amlogic,meson-gx-ao-secure", "syscon";
>  				reg = <0x0 0x140 0x0 0x140>;
> +				secure-monitor = <&sm>;
>  				amlogic,has-chip-id;
>  			};
>  
> -- 
> 2.34.1
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

-- 
Thank you,
Dmitry

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2023-11-22 18:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 12:56 [PATCH 0/5] soc: amlogic: add new meson-gx-socinfo-sm driver Viacheslav Bocharov
2023-11-22 12:56 ` [PATCH 1/5] soc: amlogic: meson-gx-socinfo: move common code to header file Viacheslav Bocharov
2023-11-22 12:56 ` [PATCH 2/5] soc: amlogic: meson-gx-socinfo: move common code to exported function Viacheslav Bocharov
2023-11-22 12:56 ` [PATCH 3/5] firmware: meson_sm: move common definitions to header file Viacheslav Bocharov
2024-02-16 21:16   ` Evgeny Bachinin
2023-11-22 12:56 ` [PATCH 4/5] soc: amlogic: Add Amlogic secure-monitor SoC Information driver Viacheslav Bocharov
2023-11-24 15:42   ` kernel test robot
2024-02-16 21:53   ` Evgeny Bachinin
2023-11-22 12:56 ` [PATCH 5/5] arm64: dts: meson: add dts links to secure-monitor for soc driver in a1, axg, gx, g12 Viacheslav Bocharov
2023-11-22 18:45   ` Dmitry Rokosov [this message]
2024-02-16  7:47 ` [DMARC error][DKIM error] [PATCH 0/5] soc: amlogic: add new meson-gx-socinfo-sm driver Dmitry Rokosov
2024-02-19  8:36   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231122184502.x4rxzvgmoaxbmhlr@CAB-WSD-L081021 \
    --to=ddrokosov@salutedevices.com \
    --cc=adeep@lexina.in \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®