From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F557C4167B for ; Fri, 8 Dec 2023 19:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fs10eBS2vFU+q80GnW6uBhYhU+dl0WKnyDe+dwdr2NA=; b=5FUHGaxhtmDn1z/SomeMW5dNl7 dB/teYxigm4uQ4/jDw1EwSfIKxTc5WXFcBftYJWg5497KJIL+8Er6DI6KcpAQ+TRXNDvgn++OJUP2 4E/vDi7SD/QdZ0yz/qLbFsuuazr0ppx4v+IGhs6MoiiVahSFSMnyMGVyzPPuuIcOdVAsJlFyqhAz1 UzSJu2h10CHzsdSLiMi5RrabASRHB3ks2JtEw1UsnNmZFrW4A0rzQsihdyJP7H2Laoq+qHSDZHA1s SJ9pyBBLATDmdWebmUhmV74Vny+RkUpYv7J6CIYEiCVOj39XDRGOMjzVRE551bqT4utZ+SZ/HuvZf YZ9VByig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBgB9-00GM7J-0J; Fri, 08 Dec 2023 19:06:27 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBgB6-00GM6h-1n for linux-amlogic@lists.infradead.org; Fri, 08 Dec 2023 19:06:25 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBgB3-0000wA-G5; Fri, 08 Dec 2023 20:06:21 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBgB2-00ETfu-Ew; Fri, 08 Dec 2023 20:06:20 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBgB2-00GYvf-5X; Fri, 08 Dec 2023 20:06:20 +0100 Date: Fri, 8 Dec 2023 20:06:20 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Thierry Reding Cc: Neil Armstrong , linux-pwm@vger.kernel.org, Martin Blumenstingl , Kevin Hilman , kernel@pengutronix.de, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Subject: Re: [PATCH] pwm: meson: Simplify using dev_err_probe() Message-ID: <20231208190620.5qobgtyii2wt7tfa@pengutronix.de> References: <20231206214817.1783227-2-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-amlogic@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231208_110624_611578_28ACB305 X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0376827136832835293==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============0376827136832835293== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bo76icyc46hz2ugk" Content-Disposition: inline --bo76icyc46hz2ugk Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Thierry, On Fri, Dec 08, 2023 at 04:52:57PM +0100, Thierry Reding wrote: > This is a lot of churn for very little gain. We seem to have different conceptions of churn. Each hunk here is an improvement for both SLOC count and usefulness of the generated error message. failed to register somename: -5 is worse than error EIO: failed to register somename , isn't it? > None of these functions are ever going to return -EPROBE_DEFER. And > yes, I know that function's doc says that it is "deemed acceptable to > use" elsewhere. However, the existing error messages are just fine, no > need to churn just for the sake of it. We had this disagreement already before. Yes dev_err_probe() is useful for three reasons and this driver only benefits from two of these. That's IMHO still one reason more than needed to justify such a change. And if you think that a function should only be used if all advantages are useful for the caller, let us reconsider if we really need capture support in the pwm framework as only two of the 68 drivers make use of it. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --bo76icyc46hz2ugk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmVzaSsACgkQj4D7WH0S /k6ozQf/SUXYDUMnY2yOUovZTGROoGOBsfWPHqzKKvQOSdc97mQvafP6W4Mt4/Mn dao+fXvGBfMJ5JUcMQoiz+J/4VjYF6NXkGN46GEhZrPXwKU0JbFhF0FCWnk/qZel qL+GQ61NtEW6Oh57Iu9tY9TnJKGMw0tDdCa6DbdKKeQccePVbF3I4yMxN3b60Dbn Y2iehxV0Goma6DZ26ylIoY8P1PSPJDHlCFZMbvjk4Kv5LPzYAQbXN8JNYxUzL/19 lFTg72YnmMSq76dEVLAGtRcPDuqv0cUtPezqbfMpBfz3LiWhqVkrAMi1r/cEVtTg BgkXG+mNRWkSGYi8YI8kVGh+9FStbg== =TWqz -----END PGP SIGNATURE----- --bo76icyc46hz2ugk-- --===============0376827136832835293== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============0376827136832835293==--