mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Alexey Romanov <avromanov@salutedevices.com>
To: <neil.armstrong@linaro.org>, <clabbe@baylibre.com>,
	<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <khilman@baylibre.com>,
	<jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com>
Cc: <linux-crypto@vger.kernel.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<kernel@salutedevices.com>,
	Alexey Romanov <avromanov@salutedevices.com>
Subject: [PATCH v2 02/20] drivers: crypto: meson: make CLK controller optional
Date: Tue, 23 Jan 2024 19:58:13 +0300	[thread overview]
Message-ID: <20240123165831.970023-3-avromanov@salutedevices.com> (raw)
In-Reply-To: <20240123165831.970023-1-avromanov@salutedevices.com>

Not all Amlogic SoC's uses CLK controller.

Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
---
 drivers/crypto/amlogic/amlogic-gxl-core.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index 35ec64df5b3a..a58644be76e9 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -263,16 +263,10 @@ static int meson_crypto_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "Cannot request MMIO err=%d\n", err);
 		return err;
 	}
-	mc->busclk = devm_clk_get(&pdev->dev, "blkmv");
+	mc->busclk = devm_clk_get_optional_enabled(&pdev->dev, "blkmv");
 	if (IS_ERR(mc->busclk)) {
 		err = PTR_ERR(mc->busclk);
-		dev_err(&pdev->dev, "Cannot get core clock err=%d\n", err);
-		return err;
-	}
-
-	err = clk_prepare_enable(mc->busclk);
-	if (err != 0) {
-		dev_err(&pdev->dev, "Cannot prepare_enable busclk\n");
+		dev_err(&pdev->dev, "Cannot get and enable core clock err=%d\n", err);
 		return err;
 	}
 
@@ -300,7 +294,6 @@ static int meson_crypto_probe(struct platform_device *pdev)
 	meson_unregister_algs(mc);
 error_flow:
 	meson_free_chanlist(mc, mc->flow_cnt - 1);
-	clk_disable_unprepare(mc->busclk);
 	return err;
 }
 
-- 
2.34.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  parent reply	other threads:[~2024-01-23 16:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 16:58 [PATCH v2 00/20] Support more Amlogic SoC families in crypto driver Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 01/20] drivers: crypto: meson: don't hardcode IRQ count Alexey Romanov
2024-01-23 16:58 ` Alexey Romanov [this message]
2024-01-24  8:28   ` [PATCH v2 02/20] drivers: crypto: meson: make CLK controller optional Jerome Brunet
2024-01-23 16:58 ` [PATCH v2 03/20] drviers: crypto: meson: add platform data Alexey Romanov
2024-01-24  7:30   ` Corentin Labbe
2024-02-01 17:13     ` Alexey Romanov
2024-02-01 19:45       ` Corentin Labbe
2024-01-23 16:58 ` [PATCH v2 04/20] drivers: crypto: meson: add MMIO helpers Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 05/20] drivers: crypto: meson: move get_engine_number() Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 06/20] drivers: crypto: meson: drop status field from meson_flow Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 07/20] drivers: crypto: meson: move algs definition and cipher API to cipher.c Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 08/20] drivers: crypto: meson: cleanup defines Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 09/20] drivers: crypto: meson: process more than MAXDESCS descriptors Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 10/20] drivers: crypto: meson: avoid kzalloc in engine thread Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 11/20] drivers: crypto: meson: introduce hasher Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 12/20] drivers: crypto: meson: add support for AES-CTR Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 13/20] drivers: crypto: meson: use fallback for 192-bit keys Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 14/20] drivers: crypto: meson: add support for G12-series Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 15/20] drivers: crypto: meson: add support for AXG-series Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 16/20] dt-bindings: crypto: meson: add new compatibles Alexey Romanov
2024-01-23 18:37   ` Rob Herring
2024-01-24  7:22   ` Krzysztof Kozlowski
2024-01-23 16:58 ` [PATCH v2 17/20] arch: arm64: dts: meson: a1: add crypto node Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 18/20] arch: arm64: dts: meson: s4: " Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 19/20] arch: arm64: dts: meson: g12: " Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 20/20] arch: arm64: dts: meson: axg: " Alexey Romanov
2024-01-24  7:22   ` Krzysztof Kozlowski
2024-01-24  9:13 ` [PATCH v2 00/20] Support more Amlogic SoC families in crypto driver neil.armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240123165831.970023-3-avromanov@salutedevices.com \
    --to=avromanov@salutedevices.com \
    --cc=clabbe@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jbrunet@baylibre.com \
    --cc=kernel@salutedevices.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®