From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D224C25B79 for ; Wed, 15 May 2024 19:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QMJ+eGv3MVHFw0qTHbry0m49ESqYCdOyRYIgGLUhkRg=; b=R4ShUEIu/mwu6e cywvho+mZST86h3b7cGb6XewxVCnAl1GrtruVeKXVdsz40h9FZ6t47Rc4JDlwkXkrUVrBwGLI1SWI kMca/J8lVq2iIIYwXNeujBwamGZg9uft/Bii/a43SWtLKgzZ67RYOFVZNLXrX5d9Mgv0ZbRv39nRm 6v6NWMgVTuzLrhvNoDvhKO5hzs4OihVyGm72mozECdXqDLL/qsAI0CN3mTzFBiYG3ox1N6jBk/UGH 5i60Wbghn8uXzubGIvU/QtDJyHtA2tGrLVsN8DT6RHY0sxSZA3APc6lWIjeyIVI21cSjfDi9B/yMM EXQW8LvGAf1mxReOa7IQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7JrL-00000002djL-2mOH; Wed, 15 May 2024 19:00:15 +0000 Received: from mx2.sberdevices.ru ([45.89.224.132] helo=mx1.sberdevices.ru) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7JrH-00000002dfv-36pP; Wed, 15 May 2024 19:00:13 +0000 Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 043FE120027; Wed, 15 May 2024 22:00:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 043FE120027 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1715799609; bh=ckMuf6MQpe0iaEm+Ee1bWyCe6cbGhXBFqyXa+u+DXDg=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=G9h+Yh3V6+EoUpaCL8Gx2lI6b1PAKwPVu4jv+o5GSnstdVQRIsZtZTDfZIF/Gx62e unpe5MWUmH102RY8ptwZ43jwEr1D6ftLkN5iDLMM768Jp8mUn1JoviQL9nLFVJptn/ JKIrWOT0m4j/B2Fx1XBv+hZnbKhw4oUY4Jq1PRYNzF633XkHNAFpPtANax8uvlGGT6 K8l18vtp0Ya6OHmu7yslcvY4nozwY908gGSpQMRV1b/8cB0ovj12RpcautQr9xFf1w QKbZXNaA7Lk4W/GNaFRJhaBVV4sSEqV91qIjubBVcbQdFJ7RPj1q2DH6wPPQEbNLuG l8MNx3y5IuX3g== Received: from smtp.sberdevices.ru (p-i-exch-sc-m02.sberdevices.ru [172.16.192.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Wed, 15 May 2024 22:00:08 +0300 (MSK) Received: from localhost (100.64.160.123) by p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 15 May 2024 22:00:08 +0300 Date: Wed, 15 May 2024 22:00:08 +0300 From: Dmitry Rokosov To: CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 4/7] dt-bindings: clock: meson: a1: peripherals: support sys_pll input Message-ID: <20240515190008.cbv4kj4inkg2bm56@CAB-WSD-L081021> References: <20240515185103.20256-1-ddrokosov@salutedevices.com> <20240515185103.20256-5-ddrokosov@salutedevices.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240515185103.20256-5-ddrokosov@salutedevices.com> User-Agent: NeoMutt/20220415 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 185260 [May 15 2024] X-KSMG-AntiSpam-Version: 6.1.0.4 X-KSMG-AntiSpam-Envelope-From: ddrokosov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 20 0.3.20 743589a8af6ec90b529f2124c2bbfc3ce1d2f20f, {Track_E25351}, {Tracking_from_domain_doesnt_match_to}, 127.0.0.199:7.1.2;smtp.sberdevices.ru:7.1.1,5.0.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;100.64.160.123:7.1.2;salutedevices.com:7.1.1, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2024/05/15 13:12:00 #25231738 X-KSMG-AntiVirus-Status: Clean, skipped X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240515_120012_180010_C1028372 X-CRM114-Status: GOOD ( 20.63 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hello Conor, On Wed, May 15, 2024 at 09:47:27PM +0300, Dmitry Rokosov wrote: > The 'sys_pll' input is an optional clock that can be used to generate > 'sys_pll_div16', which serves as one of the sources for the GEN clock. > > Signed-off-by: Dmitry Rokosov I didn't tag this patch with your Acked-by because I've changed the connection between the A1 PLL and the A1 peripherals controllers from 'sys_pll_div16' to 'sys_pll'. Please review this patch again, if possible. > --- > .../bindings/clock/amlogic,a1-peripherals-clkc.yaml | 9 +++++++-- > include/dt-bindings/clock/amlogic,a1-peripherals-clkc.h | 1 + > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-peripherals-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-peripherals-clkc.yaml > index 6d84cee1bd75..2568ad7dd0ac 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,a1-peripherals-clkc.yaml > +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-peripherals-clkc.yaml > @@ -30,6 +30,8 @@ properties: > - description: input fixed pll div7 > - description: input hifi pll > - description: input oscillator (usually at 24MHz) > + - description: input sys pll > + minItems: 6 # sys_pll is optional > > clock-names: > items: > @@ -39,6 +41,8 @@ properties: > - const: fclk_div7 > - const: hifi_pll > - const: xtal > + - const: sys_pll > + minItems: 6 # sys_pll is optional > > required: > - compatible > @@ -65,9 +69,10 @@ examples: > <&clkc_pll CLKID_FCLK_DIV5>, > <&clkc_pll CLKID_FCLK_DIV7>, > <&clkc_pll CLKID_HIFI_PLL>, > - <&xtal>; > + <&xtal>, > + <&clkc_pll CLKID_SYS_PLL>; > clock-names = "fclk_div2", "fclk_div3", > "fclk_div5", "fclk_div7", > - "hifi_pll", "xtal"; > + "hifi_pll", "xtal", "sys_pll"; > }; > }; > diff --git a/include/dt-bindings/clock/amlogic,a1-peripherals-clkc.h b/include/dt-bindings/clock/amlogic,a1-peripherals-clkc.h > index 06f198ee7623..2ce1a06dc735 100644 > --- a/include/dt-bindings/clock/amlogic,a1-peripherals-clkc.h > +++ b/include/dt-bindings/clock/amlogic,a1-peripherals-clkc.h > @@ -164,5 +164,6 @@ > #define CLKID_DMC_SEL 151 > #define CLKID_DMC_DIV 152 > #define CLKID_DMC_SEL2 153 > +#define CLKID_SYS_PLL_DIV16 154 > > #endif /* __A1_PERIPHERALS_CLKC_H */ > -- > 2.43.0 > -- Thank you, Dmitry _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic