From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21C8FC27C55 for ; Mon, 10 Jun 2024 12:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/LD1QJKPMr/YYWW1z2RMveRWQ5EVsmRUms3lzucCCnY=; b=ZKTZZN83l82/pT Hcgc7TVdqgAkR6AQ1viylRsJdt0slMrtyUqXhDSBfz3fPIIQi9WcjMKS3/G6+O0DHREFplLFCXvOG 19MP4tzgN2SykMbnob6SYIz/GoLtKMbmCIc+vWwmjE51P9g3CGDcvAcAdTE7n70HsEYRaOODgFofD hsamlATRuSuSKiBTHyEbgo6h3NrtcM5Xzv8cemyZ2T5mdRkU/gnrmZhdSAhZSfNqgKka/qAUDYA9r 3HMK5z0Ta1dSJSDehbpg3/jCASIeg99VqI9EKNdI1LWUa43eYcNDNo95/mebtqd39XHWf3BKZp1bf Cct7XMYUxp1ukiJ3AbYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGeSD-000000053go-0z7g; Mon, 10 Jun 2024 12:48:53 +0000 Received: from mx1.sberdevices.ru ([37.18.73.165]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGeS8-000000053eL-2iA8; Mon, 10 Jun 2024 12:48:51 +0000 Received: from p-infra-ksmg-sc-msk01.sberdevices.ru (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 98D27100009; Mon, 10 Jun 2024 15:48:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 98D27100009 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1718023723; bh=j3YIK2h8usjuYp/Fn/WGb0hwIgDEYJptTOyzUDckVro=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=CB7tWaAS8L4T5u/Wb2APAq8IO977ijed2j4sGe3NIrXrMlsmZut3p/ZpF4ctKtlGh a93blyqI8tBcdKl+ERNn6ynyI01ennDmN7EBkBwdCVE/xj6eocjEVS5v50qcBoOApR k6T/oldjby4wS8M2XYVAYATdwYZ6CVKmNiCRQUH3kzMXoTLcviYavRJww9XbUnN0xd HElrjKQV8Y6rCagOJwpUnPd04NzU+sthDEGoiKksRSJ1bdFMAfi7B/5W4tDBHIIdqf 6VxowPklrawKgENcAEbg71g5wzZsypgd46BLgpjg+c7/FUUypunquZhkd7ftdULRzd 0uNyhFXvhkqPw== Received: from smtp.sberdevices.ru (p-i-exch-sc-m02.sberdevices.ru [172.16.192.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Mon, 10 Jun 2024 15:48:43 +0300 (MSK) Received: from localhost (100.64.160.123) by p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 10 Jun 2024 15:48:43 +0300 Date: Mon, 10 Jun 2024 15:48:42 +0300 From: Dmitry Rokosov To: Jerome Brunet CC: , , , , , , , , , , , , , , , Rob Herring Subject: Re: [PATCH v3 6/7] dt-bindings: clock: meson: add A1 CPU clock controller bindings Message-ID: <20240610124842.mpy4rtlwtwasqf7h@CAB-WSD-L081021> References: <20240515185103.20256-1-ddrokosov@salutedevices.com> <20240515185103.20256-7-ddrokosov@salutedevices.com> <1jtti1p10m.fsf@starbuckisacylon.baylibre.com> <20240610111826.im3mz64hjfkxrxhr@CAB-WSD-L081021> <1j7cexow91.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1j7cexow91.fsf@starbuckisacylon.baylibre.com> User-Agent: NeoMutt/20220415 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 185833 [Jun 10 2024] X-KSMG-AntiSpam-Version: 6.1.0.4 X-KSMG-AntiSpam-Envelope-From: ddrokosov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 20 0.3.20 743589a8af6ec90b529f2124c2bbfc3ce1d2f20f, {Tracking_uf_ne_domains}, {Track_E25351}, {Tracking_from_domain_doesnt_match_to}, devicetree.org:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;smtp.sberdevices.ru:5.0.1,7.1.1;100.64.160.123:7.1.2;salutedevices.com:7.1.1;127.0.0.199:7.1.2, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean, bases: 2024/06/10 11:00:00 X-KSMG-LinksScanning: Clean, bases: 2024/06/10 11:00:00 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2024/06/10 11:09:00 #25535815 X-KSMG-AntiVirus-Status: Clean, skipped X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_054849_664665_4C7E55CF X-CRM114-Status: GOOD ( 35.54 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Jun 10, 2024 at 01:47:06PM +0200, Jerome Brunet wrote: > On Mon 10 Jun 2024 at 14:18, Dmitry Rokosov wrote: > > > Hello Jerome, > > > > Thank you for the review! > > > > On Mon, Jun 10, 2024 at 12:04:09PM +0200, Jerome Brunet wrote: > >> On Wed 15 May 2024 at 21:47, Dmitry Rokosov wrote: > >> > >> > Add the documentation and dt bindings for Amlogic A1 CPU clock > >> > controller. > >> > > >> > This controller consists of the general 'cpu_clk' and two main parents: > >> > 'cpu fixed clock' and 'syspll'. The 'cpu fixed clock' is an internal > >> > fixed clock, while the 'syspll' serves as an external input from the A1 > >> > PLL clock controller. > >> > > >> > Signed-off-by: Dmitry Rokosov > >> > Reviewed-by: Rob Herring > >> > --- > >> > .../bindings/clock/amlogic,a1-cpu-clkc.yaml | 64 +++++++++++++++++++ > >> > .../dt-bindings/clock/amlogic,a1-cpu-clkc.h | 19 ++++++ > >> > 2 files changed, 83 insertions(+) > >> > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-cpu-clkc.yaml > >> > create mode 100644 include/dt-bindings/clock/amlogic,a1-cpu-clkc.h > >> > > >> > diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-cpu-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-cpu-clkc.yaml > >> > new file mode 100644 > >> > index 000000000000..f4958b315ed4 > >> > --- /dev/null > >> > +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-cpu-clkc.yaml > >> > @@ -0,0 +1,64 @@ > >> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > >> > +%YAML 1.2 > >> > +--- > >> > +$id: http://devicetree.org/schemas/clock/amlogic,a1-cpu-clkc.yaml# > >> > +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> > + > >> > +title: Amlogic A1 CPU Clock Control Unit > >> > + > >> > +maintainers: > >> > + - Neil Armstrong > >> > + - Jerome Brunet > >> > + - Dmitry Rokosov > >> > + > >> > +properties: > >> > + compatible: > >> > + const: amlogic,a1-cpu-clkc > >> > + > >> > + '#clock-cells': > >> > + const: 1 > >> > + > >> > + reg: > >> > + maxItems: 1 > >> > + > >> > + clocks: > >> > + items: > >> > + - description: input fixed pll div2 > >> > + - description: input fixed pll div3 > >> > + - description: input sys pll > >> > + - description: input oscillator (usually at 24MHz) > >> > >> According to the documentation, fdiv5 is also an input of the CPU clock > >> tree. > >> > >> That is typically the kind of things we'd prefer to get right from the > >> beginning to avoid modifying the bindings later. > >> > > > > Could you please share which documentation you are referencing? I have > > the A113L documentation, and there is no mention of the CPU clock IP. > > You should get in touch with Amlogic. > Okay, I will double check with Amlogic and back with accurate information. > > I retrieved below register map from the vendor's custom driver: > > > > === > > CPUCTRL_CLK_CTRL0 > > > > bits 1:0 - cpu_fsource_sel0 > > 0 - xtal > > 1 - fclk_div2 > > 2 - fclk_div3 > > > > bit 2 - cpu_fsel0 > > 0 - cpu_fsource_sel0 > > 1 - cpu_fsource_div0 > > > > bit 3 - UNKNONWN > > > > bits 9:4 - cpu_fsource_div0 > > Divider value > > > > bit 10 - cpu_fclk > > 0 - cpu_fsel0 > > 1 - cpu_fsel1 > > > > bit 11 - cpu_clk > > 0 - cpu_fclk > > 1 - sys_pll > > > > bits 15:12 - UNKNONWN > > > > bits 17:16 - cpu_fsource_sel1 > > 0 - xtal > > 1 - fclk_div2 > > 2 - fclk_div3 > > > > bit 18 - cpu_fsel1 > > 0 - cpu_fsource_sel1 > > 1 - cpu_fsource_div1 > > > > bit 19 - UNKNONWN > > > > bits 25:20 - cpu_fsource_div1 > > Divider value > > > > bits 31:26 - UNKNONWN > > === > > > > As you can see it doesn't have any other inputs except fclk_div2, > > fclk_div3, sys_pll and xtal. > > You might not know what to do with it yet, still it is part of the > documentation and should be part of the bindings too > > > > >> > + > >> > + clock-names: > >> > + items: > >> > + - const: fclk_div2 > >> > + - const: fclk_div3 > >> > + - const: sys_pll > >> > + - const: xtal > >> > + > >> > +required: > >> > + - compatible > >> > + - '#clock-cells' > >> > + - reg > >> > + - clocks > >> > + - clock-names > >> > + > >> > +additionalProperties: false > >> > + > >> > +examples: > >> > + - | > >> > + #include > >> > + apb { > >> > + #address-cells = <2>; > >> > + #size-cells = <2>; > >> > + > >> > + clock-controller@fd000000 { > >> > + compatible = "amlogic,a1-cpu-clkc"; > >> > + reg = <0 0xfd000080 0 0x8>; > >> > >> If reg is <0 0xfd000080 0 0x8> then node name should be clock-controller@fd000080 > >> > > > > Okay, I will fix that example in the next version. > > > > [...] > > -- > Jerome -- Thank you, Dmitry _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic