From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A678EC02183 for ; Fri, 17 Jan 2025 08:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6t10Kk7rQC8j6y+3ddZTcYkbWazGw3+CFZ8Lf67jMSg=; b=B9gxXcLeTG+pR9 06k6EwdlmXerEakfTTjerBRkMTxDwZwM9JA0yHt+4FS6enwnPq+vpQOAiTnBgE0mJI6Jeo3qBPKjR batVwv/GCohCokyhXkOI5CryeB3wjgCQri8zPOaa9GxU9spl/Sk5hfQULjQWTHD/simdhJ4G16DQR E3xO302+97QJxNXxFn4AB/nSKyuTyAYTx1YBqzmwH15RUM46cDOzqPZF5IkGHuMpZP85bTatYpBiY DZ84sTldP+kJzCaNwwpCC3rNUcH+MDaCKRP+eraEa+txl/v2GwL+ySuCbsC7f1RRvg/NdmpNPifbU 07MGJd301jYL00dAuTLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYi2K-0000000HNDp-3b4d; Fri, 17 Jan 2025 08:49:04 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYi2J-0000000HNCc-0CPV; Fri, 17 Jan 2025 08:49:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5278CA42A01; Fri, 17 Jan 2025 08:47:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B432C4CEDD; Fri, 17 Jan 2025 08:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737103741; bh=cQc0hGk7FmLHCcBWPKPQA14Ij0b8LuFcpjJiNw1Al5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NbxWSK2dXtW/eIQj7Jp2UZaUEQ5m2cq0XzCoNalsUP/cs8UOjJIFtRKn4GXgjIVc2 cVHPBZHe1m6gPhu9dhqWsjWzchuJxQ5Z4gzWiRtjeVHD0V7eEGyQm8rKf4NpMhYBIr FePfAT3Ct/y8zT99TRC7+18AuIWun55wpfgatDdn9jeUIMWcJ3/zW9miSzifTEEiJ6 TCz114oXKXvNWRqEY9l/7uC1ixWI8VbBnWwBlZIB2bCFUMNw9tTt6erxuRDLdXNCD3 noIQucuR7dgo/xV8TFHSl6/CqhZPx41qr6vOrchadt9VRanW+bNO+9eSPKC0BtiTHU y3UqzrSERrkaQ== Date: Fri, 17 Jan 2025 09:48:58 +0100 From: Krzysztof Kozlowski To: Xianwei Zhao Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Bartosz Golaszewski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH v3 1/5] dt-bindings: pinctrl: Add support for Amlogic SoCs Message-ID: <20250117-intrepid-nano-horse-98e817@krzk-bin> References: <20250115-amlogic-pinctrl-v3-0-2b8536457aba@amlogic.com> <20250115-amlogic-pinctrl-v3-1-2b8536457aba@amlogic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250115-amlogic-pinctrl-v3-1-2b8536457aba@amlogic.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250117_004903_215455_42A810AA X-CRM114-Status: GOOD ( 10.22 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Jan 15, 2025 at 02:41:59PM +0800, Xianwei Zhao wrote: > +properties: > + compatible: > + const: amlogic,pinctrl-a4 > + > + "#address-cells": > + const: 2 > + > + "#size-cells": > + const: 2 Why this moved to '2'? 32-bit was not enough? > + > + ranges: true > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" Keep required after patternProperties > + > +patternProperties: > + "^gpio@[0-9a-f]+$": > + type: object > + > + properties: > + reg: > + minItems: 1 > + items: > + - description: pin config register > + - description: pin mux setting register (some special pin fixed function) > + - description: pin drive strength register (optionanl) typo: optional > + > + reg-names: > + minItems: 1 > + items: > + - const: gpio > + - const: mux > + - const: ds > + > + gpio-controller: true > + > + "#gpio-cells": > + const: 2 > + > + gpio-ranges: > + maxItems: 1 > + > + bank-number: > + description: | > + bank-number are provided by the pin controller header file at: > + > + $ref: /schemas/types.yaml#/definitions/uint32 gpio-ranges tell you that, don't they? Anyway, you would need here minimum and maximum. > + > + required: > + - reg > + - reg-names > + - gpio-controller > + - "#gpio-cells" > + - gpio-ranges > + - bank-number > + > + additionalProperties: false > + > + "^func-[0-9a-z-]+$": > + type: object > + patternProperties: > + "^group-[0-9a-z-]+$": > + type: object > + allOf: > + - $ref: /schemas/pinctrl/pincfg-node.yaml > + - $ref: /schemas/pinctrl/pinmux-node.yaml Missing required pinmux and maybe other properties. > + additionalProperties: false > + > +additionalProperties: false > + > +examples: > + - | > + #include > + apb { > + #address-cells = <2>; > + #size-cells = <2>; > + periphs_pinctrl: pinctrl { > + compatible = "amlogic,pinctrl-a4"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + gpio@14 { > + reg = <0 0x14 0 0x10>, > + <0 0x14 0 0x10>; One line. > + reg-names = "gpio", "mux"; > + gpio-controller; > + #gpio-cells = <2>; > + bank-number = ; > + gpio-ranges = <&periphs_pinctrl 0 8 10>; > + }; Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic