mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: linux-amlogic@lists.infradead.org
Cc: neil.armstrong@linaro.org, devicetree@vger.kernel.org,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: [PATCH v1 0/4] dts: amlogic: fix FCLK{3,4} clocks for new PWM controller binding
Date: Sun, 20 Apr 2025 18:47:57 +0200	[thread overview]
Message-ID: <20250420164801.330505-1-martin.blumenstingl@googlemail.com> (raw)

Christian has reported Bluetooth issues on some of his boards, for
example on a (GXBB) WeTek Play 2:
  # dmesg | grep -i blue
  Bluetooth: Core ver 2.22
  NET: Registered PF_BLUETOOTH protocol family
  Bluetooth: HCI device and connection manager initialized
  Bluetooth: HCI socket layer initialized
  Bluetooth: L2CAP socket layer initialized
  Bluetooth: SCO socket layer initialized
  Bluetooth: HCI UART driver ver 2.3
  Bluetooth: HCI UART protocol H4 registered
  Bluetooth: HCI UART protocol Three-wire (H5) registered
  Bluetooth: HCI UART protocol Broadcom registered
  Bluetooth: HCI UART protocol QCA registered
  Bluetooth: HCI UART protocol AML registered
  Bluetooth: null: hu 0000000023fa9791
  Bluetooth: hci0: hu 0000000023fa9791
  Bluetooth: hci0: hu 0000000023fa9791 skb 000000003f7acf2f
  Bluetooth: hci0: command 0x0c03 tx timeout
  Bluetooth: hci0: BCM: Reset failed (-110)
  Bluetooth: hci0: hu 0000000023fa9791
  Bluetooth: hci0: hu 0000000023fa9791

It turns out there's a typo in the references to the untested/unknown
clock input that made it into the already applied series
"dts: amlogic: switch to the new PWM controller binding" [0]

The original goal was to skip this input. This can be achieved by
specifying a clock input as <0> (which this series does). When using
<> (note the lack of 0) the clock is completely ignored when parsing
the .dtb, resulting in a shift in index of the FCLK DIV4 / DIV3 inputs.
This then results in the PWM controller driver calculating the
frequencies for a different clock compared to what the actual hardware
uses.

Neil, please apply this as a fix for the next 6.15-rc.


[0] https://lore.kernel.org/linux-amlogic/20241227212514.1376682-1-martin.blumenstingl@googlemail.com/


Martin Blumenstingl (4):
  ARM: dts: amlogic: meson8: fix reference to unknown/untested PWM clock
  ARM: dts: amlogic: meson8b: fix reference to unknown/untested PWM
    clock
  arm64: dts: amlogic: gx: fix reference to unknown/untested PWM clock
  arm64: dts: amlogic: g12: fix reference to unknown/untested PWM clock

 arch/arm/boot/dts/amlogic/meson8.dtsi             | 6 +++---
 arch/arm/boot/dts/amlogic/meson8b.dtsi            | 6 +++---
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 6 +++---
 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi       | 6 +++---
 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi        | 6 +++---
 5 files changed, 15 insertions(+), 15 deletions(-)

-- 
2.49.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

             reply	other threads:[~2025-04-20 16:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-20 16:47 Martin Blumenstingl [this message]
2025-04-20 16:47 ` [PATCH v1 1/4] ARM: dts: amlogic: meson8: fix reference to unknown/untested PWM clock Martin Blumenstingl
2025-04-20 16:47 ` [PATCH v1 2/4] ARM: dts: amlogic: meson8b: " Martin Blumenstingl
2025-04-20 16:48 ` [PATCH v1 3/4] arm64: dts: amlogic: gx: " Martin Blumenstingl
2025-04-20 16:48 ` [PATCH v1 4/4] arm64: dts: amlogic: g12: " Martin Blumenstingl
2025-04-22  6:58 ` [PATCH v1 0/4] dts: amlogic: fix FCLK{3,4} clocks for new PWM controller binding neil.armstrong
2025-04-22  7:27 ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250420164801.330505-1-martin.blumenstingl@googlemail.com \
    --to=martin.blumenstingl@googlemail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®