From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34B1AC71136 for ; Wed, 11 Jun 2025 17:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4q3Naqw5rVXo73asVwtvA+gwfLxoYCNdTb1QlZTnVMs=; b=qaW5iELIfVxIRp UjmyYIFk01YSFkcV+gJqIApb8W6ApF5/VXrId1kWwHJ0gAYSkGMhok+xxAGWiAQLxzDdkxtkRodMP 25gaEx4V3SycGYG8bWLzoO9Aa2EWA2QCg7lj67QEzK4MHjt/gdYoRXO0n52XZFgmWF87f9PIremum 8ozgouXKQ0Zgd7qfsimLINoQMGFLK1SjlvT+sE2MRvAWu74P+Rqq0hHo4E8kZIvPB18Hg2ihACxkz 4JdOUGyvMFnkbJAz21e1IKUqk0/DDf3N77F5hYzV9fnNuHD0t/99mID4GT36sGMaihl2P0qYn76y0 cQJkQX/55rODHgbOv9gA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPPjc-0000000Alil-4AgI; Wed, 11 Jun 2025 17:59:36 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPKyA-00000009t91-4ARl for linux-amlogic@lists.infradead.org; Wed, 11 Jun 2025 12:54:20 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3a54700a46eso2680332f8f.1 for ; Wed, 11 Jun 2025 05:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749646458; x=1750251258; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HFpwfaBk9Zi/05ZHLg2kQwpAQr276eZe2gpjdnyEXsw=; b=cqhnQkNnpjPVwn4/1zSZL/iTHVDAexiH/03NcEI3eOqpTVCoqholuA9ME548zelh5T npeTZ6adXx7Dwa/O7F4tpDqMksXfqXzCEaafbTbL1kz6A51x0CkF0H/ECnvDL02W7UzJ BE4HDo7OQ5H8KEl7HrTtS7LaNOMpcrickaFvCsazHMwdV342hZ5VGEWbA6E0wReAiuMZ b8hsF5lAcqgy0InUrWmEAwevsUlDWsa/Ipv8jhE9nZADLxonrU455jQqcTBQ4hThebd5 Rxk04D5tfBw/F2ARAP3rxTiIfd5uwbTlhKSuJrnr7TsU876Wd+a1Vn1qB2WWk+1gCTAK tPDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749646458; x=1750251258; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HFpwfaBk9Zi/05ZHLg2kQwpAQr276eZe2gpjdnyEXsw=; b=N77V4j4lmMGUVbuQqYoUV58UDlUNDNRvChYHwhlNRB5rQTE0oWAhdmKXczEhuL8K64 HRb9WRP4DazetOh+wPDzJLapyA1hPtyHoaXtfEHMXibZtSI9YAC+bSuK252AEQGIX5Z8 B62lIhITZZSCY7aj455NtFXQtSsoobHpG/BVUr6NWfeY9Rk1oySdtQPxeLCRgzyfojcP TRh93JuaogiMnW4RZu/vM4VJGZCaWo3phwdkxaNZp5YTuUfaEDFnw+MdHgzFZcFit+Jy nsj//OY3VeGzLQ7CM2bYESA3enpEt03ArRuGezSh8LubLPxaIvpFU/z8anzGSxoed6Zn g6ew== X-Forwarded-Encrypted: i=1; AJvYcCUWK1e4v8y3CNVoKJcs/k7EKDS9srJKt/u/O5Fsk8lvCZZBDw73TZ5auZzAsQB6w0E/xAUzlgiCYX7Ib9IL@lists.infradead.org X-Gm-Message-State: AOJu0YwgHj0T+Np+7YbuAepSmAt3N1r6P2svjqQP34EQrK2EFjeno7+X PJDyXxRaY6YOoD4XDAmy1G1E5c0VVvlf4O0rgWk3ZpvOIDAtID4glYt3kbR0utUfm0c= X-Gm-Gg: ASbGncsIrX8q+vIszZibzVlNFf4VZR6aX1snIulwVantPB81U3i14UJJHVzbu0lBbE1 ifnBlAtVbeaKDIFn0HbchunSEKf58bTdb7O6N4QcbSzew4hmCoSq67RWzNsYDPwEu7GWGIJhy5y THCqZjwWpN+tF+1jicwJUpxs2l5xoURZtGEHksAcUbrbygBYJzvl8Bg/9b0C2hNfj+Oezto/Tv6 TLd7sSZZdWYVZcV4GBfZqBpP9v6DFpiJzA5/JJozXjR6PxPz+zEI8aQV29riPL0VXvYX+10IuqD 3DZ1m7s/4BTfSzYvjiV6zCpLVler5cougV9btwMSyu/VBsNp9gN9M4JR76d5woA7RkMkn/nBiAh Tk/NCPCK18w8= X-Google-Smtp-Source: AGHT+IGIlwjD38JS//yUBEcvXlmN2huAOqXtp/YJa3YDrL38fHSYMCV1TEIKntX391ju7QlDra2xEA== X-Received: by 2002:a05:6000:2586:b0:3a4:d939:62f8 with SMTP id ffacd0b85a97d-3a5586cb2a6mr2093860f8f.32.1749646457670; Wed, 11 Jun 2025 05:54:17 -0700 (PDT) Received: from toaster.baylibre.com ([2a01:e0a:3c5:5fb1:8ef3:a82f:ccaa:91b5]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a53245275esm15225486f8f.76.2025.06.11.05.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 05:54:17 -0700 (PDT) From: Jerome Brunet Date: Wed, 11 Jun 2025 14:53:58 +0200 Subject: [PATCH 3/4] clk: clk-imx8mp-audiomix: use the auxiliary device creation helper MIME-Version: 1.0 Message-Id: <20250611-clk-aux-v1-3-fb6575ed86a7@baylibre.com> References: <20250611-clk-aux-v1-0-fb6575ed86a7@baylibre.com> In-Reply-To: <20250611-clk-aux-v1-0-fb6575ed86a7@baylibre.com> To: Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Th=C3=A9o_Lebrun?= , Michael Turquette , Stephen Boyd , Philipp Zabel , Abel Vesa , Peng Fan , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Martin Blumenstingl Cc: linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Jerome Brunet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2798; i=jbrunet@baylibre.com; h=from:subject:message-id; bh=ojLJe2tP2Vz209foMJ0Lu2S+h70I7DXs1+HhM6dEcXA=; b=owEBbQKS/ZANAwAKAeb8Dxw38tqFAcsmYgBoSXx0XZWnNZ1AgTV5+LghlbWYLZmdaCeetdFuI qp+F7j2WVaJAjMEAAEKAB0WIQT04VmuGPP1bV8btxvm/A8cN/LahQUCaEl8dAAKCRDm/A8cN/La hb16D/wP9KqqBEL7B0U8B0WK3yPhG6P25gSKeMgOS5rbf0shnJGcVbdMZrh5wm9fTchQpnEmZCz D2n4bKvAkLeTU4ydkqcJ269ydY7GRX313GINYYGI8Vg+zmRD8n52Kb7Stu2lxt/0RX81QLy/2vE UdgZmzXLrQ2p7vQFa+B/AAU02dJwd0jzeD6TTYstyr7Vt22QGmMBtRTl8MUiRbzFn0UTGfsNFxN wLGmBduWVn0u+WPHyEatcPAogHrnl78ggZsxkNmDNlLHJVlsjCYMKbOq4m2XV4NacsNVmG5G8dp GfaM8mfrSlogZpEL5Zbhz7PoJCcUjHf+NcnI35LMc53E30vHuphLQjdsUzJuDn3jsUO4FvCyUfA lom1Lz7f5BY4l3cojZXX+fHtCnp3Rjx736PDJxmvmXUNQM48ymIwr1jNh9XzYHP/6ZdnaTFXPT0 iLNQEC7PVi55LOyqA3Qh0Q4OTu0SXEL0Up0aCmi9hwUbtnsn8Hcnl2Ici1abYub+Us8WzOQVJT1 AeckT54HKRMGKNqpj/OQ4rMW8woe2BBCfkRgubAj13myhy1nI05lTUzV3LAtolCUdR3iSGT9htf iTexlX/QOC4yKNXuJoKwrB9N2TTIu2a9Jj0O/jNY3tem+RlQF7wWF88v6oSJ0sGAoHiCXLPtX8D rA4jtMmEVS0/N7w== X-Developer-Key: i=jbrunet@baylibre.com; a=openpgp; fpr=F29F26CF27BAE1A9719AE6BDC3C92AAF3E60AED9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250611_055419_063748_6D6692F9 X-CRM114-Status: GOOD ( 12.49 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The auxiliary device creation of this driver is simple enough to use the available auxiliary device creation helper. Use it and remove some boilerplate code. Signed-off-by: Jerome Brunet --- drivers/clk/imx/clk-imx8mp-audiomix.c | 49 ++++++----------------------------- 1 file changed, 8 insertions(+), 41 deletions(-) diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c index 775f62dddb11d8cfd17a4ebf7a677ef399c5e617..765fb1f5bd4fa2b039d7414abd89471438ee41dd 100644 --- a/drivers/clk/imx/clk-imx8mp-audiomix.c +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c @@ -230,61 +230,28 @@ struct clk_imx8mp_audiomix_priv { #if IS_ENABLED(CONFIG_RESET_CONTROLLER) -static void clk_imx8mp_audiomix_reset_unregister_adev(void *_adev) +static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev) { - struct auxiliary_device *adev = _adev; - - auxiliary_device_delete(adev); - auxiliary_device_uninit(adev); -} - -static void clk_imx8mp_audiomix_reset_adev_release(struct device *dev) -{ - struct auxiliary_device *adev = to_auxiliary_dev(dev); - - kfree(adev); -} - -static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev, - struct clk_imx8mp_audiomix_priv *priv) -{ - struct auxiliary_device *adev __free(kfree) = NULL; - int ret; + struct auxiliary_device *adev; if (!of_property_present(dev->of_node, "#reset-cells")) return 0; - adev = kzalloc(sizeof(*adev), GFP_KERNEL); + adev = devm_auxiliary_device_create(dev, "reset", NULL); if (!adev) - return -ENOMEM; - - adev->name = "reset"; - adev->dev.parent = dev; - adev->dev.release = clk_imx8mp_audiomix_reset_adev_release; - - ret = auxiliary_device_init(adev); - if (ret) - return ret; + return -ENODEV; - ret = auxiliary_device_add(adev); - if (ret) { - auxiliary_device_uninit(adev); - return ret; - } - - return devm_add_action_or_reset(dev, clk_imx8mp_audiomix_reset_unregister_adev, - no_free_ptr(adev)); + return 0; } #else /* !CONFIG_RESET_CONTROLLER */ -static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev, - struct clk_imx8mp_audiomix_priv *priv) +static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev) { return 0; } -#endif /* !CONFIG_RESET_CONTROLLER */ +#endif static void clk_imx8mp_audiomix_save_restore(struct device *dev, bool save) { @@ -408,7 +375,7 @@ static int clk_imx8mp_audiomix_probe(struct platform_device *pdev) if (ret) goto err_clk_register; - ret = clk_imx8mp_audiomix_reset_controller_register(dev, priv); + ret = clk_imx8mp_audiomix_reset_controller_register(dev); if (ret) goto err_clk_register; -- 2.47.2 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic