From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80565CCF9F8 for ; Wed, 5 Nov 2025 08:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dq4feMJ18gxEybwhHhz3x7V0QyGxtQGVSMLvQNAZycU=; b=4kft24yZjaS3l4 BqjIbXzTSgAU18gsrEyxwt+zAso6KEbpzAnT6JSoEZapRFmROckAlA0zecfm8FBYdddoqNTzokNEX LW1i+qA8xqaaOO2JNVRk/J+YGBsPuyOZo85nnwbYPpG56xPF7pjjlipUKAVawPsSbsMdPvj27EION mlgUdzA5KqZHbrw8+hhGRbDMGh3MpZ0TnTDl5+4N9T3FZBTsp/eFUFOeadl+SziUo1Za8hSBfJERk l/YQJ8OtjiFqp9kQbuA5gn0u0dxIKlqKdm7AuqKkCabmwdYbt+MDaM5FHYwAAZnTsvNJaWr+YKx1y CNtJ2OZniSesADhINiUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGYxS-0000000DIcO-0hLm; Wed, 05 Nov 2025 08:33:34 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGYxP-0000000DIbN-1L8c; Wed, 05 Nov 2025 08:33:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 6693C43A22; Wed, 5 Nov 2025 08:33:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CA45C4CEF8; Wed, 5 Nov 2025 08:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762331610; bh=N9DVJZLHg/ikq7JcKb017+GXdHTNHUl1swp5I6YFwKg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FWRtcGLQVHMZgFcfCcC2Ue5biDzICOqxbsTH9uRs3nHuk4V9OMogHP0jGb51Z/R1/ jJxkWdC8AHsbMqgtuTPgrjWZOlEwVVOpsHrziXpskkAkKCA1xrAzVVi07M2Ld7UyTP VJIqW87HIEtASx13s4C1VM/y6/X7on3YXHn7gwZzVxCFO470mCBBKSCNdU9LIk5Cyc 1XM/bvkZNvlVnWDHYXq4thAk5z0FFtDTWqf6wOzceEzFJa6Pqtp/I85AxdCnbThUg5 dL17TQbIUFUeUW15dIGkbb9zPwlX5ZkCMOZjeOPxSyuT7pqNhvIJS5W4nOvExPXANQ M6yn12bRbQ/3Q== Date: Wed, 5 Nov 2025 09:33:27 +0100 From: Krzysztof Kozlowski To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Jose Abreu , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthew Gerlach , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Keguang Zhang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Lad Prabhakar , Heiko Stuebner , Chen Wang , Inochi Amaoto , Emil Renner Berthing , Minda Chen , Drew Fustini , Guo Ren , Fu Wei , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Shuang Liang , Zhi Li , Shangjuan Wei , "G. Jaya Kumaran" , Clark Wang , Linux Team , Frank Li , David Wu , Samin Guo , Christophe Roullier , Swathi K S , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH v4 1/8] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems Message-ID: <20251105-fat-aromatic-nightingale-1ef8ac@kuoka> References: <20251104-qcom-sa8255p-emac-v4-0-f76660087cea@linaro.org> <20251104-qcom-sa8255p-emac-v4-1-f76660087cea@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251104-qcom-sa8255p-emac-v4-1-f76660087cea@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251105_003331_510186_5325B2D0 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Nov 04, 2025 at 02:08:52PM +0100, Bartosz Golaszewski wrote: > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos-scmi.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos-scmi.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..ff70d785d326f39a8fe5698759c56ab2cb7f7eef > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos-scmi.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/qcom,ethqos-scmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Ethernet ETHQOS device (firmware managed) > + > +maintainers: > + - Bjorn Andersson > + - Konrad Dybcio > + - Bartosz Golaszewski > + > +description: > + dwmmac based Qualcomm ethernet devices which support Gigabit > + ethernet (version v2.3.0 and onwards) with clocks, interconnects, etc. > + managed by firmware > + > +allOf: > + - $ref: snps,dwmac.yaml# > + > +properties: > + compatible: > + const: qcom,sa8255p-ethqos > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: stmmaceth > + - const: rgmii > + > + interrupts: > + items: > + - description: Combined signal for various interrupt events > + - description: The interrupt that occurs when HW safety error triggered > + > + interrupt-names: > + items: > + - const: macirq > + - const: sfty > + > + power-domains: > + minItems: 3 You should have here both constraints - min and maxItems. Current code works fine, but usually we want it to be explicit. I found two more nits which I did not notice earlier, so when fixing above please also: 1. Please name the file following compatible, so: qcom,sa8255p-ethqos.yaml (unless this was already discussed...) > + snps,tso; > + snps,pbl = <32>; > + rx-fifo-depth = <16384>; > + tx-fifo-depth = <16384>; > + > + phy-handle = <ðernet_phy>; > + phy-mode = "2500base-x"; > + > + snps,mtl-rx-config = <&mtl_rx_setup1>; > + snps,mtl-tx-config = <&mtl_tx_setup1>; > + > + power-domains = <&scmi8_pd 0>, <&scmi8_pd 1>, <&scmi8_dvfs 0>; > + power-domain-names = "core", "mdio","serdes"; 2. Missing space after , Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic