From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C715ECFD342 for ; Mon, 24 Nov 2025 03:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:MIME-Version:Message-Id :Date:Subject:From:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=kI1igT48fQ6DmiGb2xFuGIQX9JuIMR1i+whjH//jEpY=; b=PV0dB6yBrH8FCj 6DxSCWHbPC8cghR1NOaKsIvZ8F7SBEGCpTUBjEGalJvBOGLrJ001r1nM6BACujhId77gUEPlwazNQ nNIBYUMnWFcSZ0VGheCyp0zyXC1z3oU50oUmFcmC1cHuuuQpb2VpymtZoAKZx0Z0x/pQ+wAC8aFmT QxaeJdGfnujJHUmyscIpT+X3sRd7A/mm6cgunkONoe/eT4IG+NPxPvAbbBo8taL38TDkblpkBBi9+ KYRmuN0BuWC9gTeZMwpVa/0CsUjRdsQG54LK5dlg2cS2iu3Cj4Trp0f3kP4W5o0dVXZXKiIIBUXy1 n2ja+V+yj7ZIKEw4SriQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNNJj-0000000B1vF-3EkO; Mon, 24 Nov 2025 03:32:43 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNNJb-0000000B1sK-44sX; Mon, 24 Nov 2025 03:32:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8886443CDF; Mon, 24 Nov 2025 03:32:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 4FC1FC4CEF1; Mon, 24 Nov 2025 03:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763955154; bh=Rma4wPqX3YrBdvw49dMz8PSp/KasV1B7VvOywDgOwIk=; h=From:Subject:Date:To:Cc:Reply-To:From; b=TtAeh1VqibU1tllGZwnvEKRX8AlfTX1Lcd5oOnseMQwXqrn7rpAjgE5uzFqHFlee6 AtFBji4ARxH6Pauv5QZCf9qiT2Zq9fxPlqlkrotczOsr2RAMaksJPBcaWPJrfD68v0 b70h4SmbPETwpdfDst6/Fg4i7N2N70UWz894PYNRxleJxNGnhUmY7qOFtAGoYlYZLF GGiSCno5JesM7LXCdWEJix5MZd92dKSa6ba6G7TlbK8C4+h1ISAnlFsZUfBgLttJjl 7wIXx2QfLxEYsbYHm+sr/GFOWyClXwfkRvBWCl1DGIa/jjgSDVknYFUZmHc7Pm305s qJJSCbOAH/tyw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA12CFD2F6; Mon, 24 Nov 2025 03:32:34 +0000 (UTC) From: Zhentao Guo via B4 Relay Subject: [PATCH RFC v2 0/3] Add Amlogic stateless H.264 video decoder for S4 Date: Mon, 24 Nov 2025 11:32:16 +0800 Message-Id: <20251124-b4-s4-vdec-upstream-v2-0-bdbbce3f11a6@amlogic.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAMDRI2kC/32NQQ6CMBBFr0Jm7Zi2FCSuTEw8gFvDopQRJrGUt NhoCHe34QAu3//5768QKTBFOBcrBEoc2U8Z1KEAO5ppIOQ+MyihKinUCTuNUWPqyeJ7jksg41D UorTSaNtoA3k5B3ryZ7c+4H67QpvDkePiw3d/SnKv/kqTRIG1ElrIRpZd1V+Me/mB7dF6B+22b T8gusGIvQAAAA== X-Change-ID: 20251027-b4-s4-vdec-upstream-0603c1a4c84a To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Zhentao Guo X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763955152; l=9747; i=zhentao.guo@amlogic.com; s=20251024; h=from:subject:message-id; bh=Rma4wPqX3YrBdvw49dMz8PSp/KasV1B7VvOywDgOwIk=; b=7eiK9AbvnyV9gXLFTpZcAQD4I6wCyibBGhpwhcPp+8k4dMnWbwIHzswp1igFxQQmyeG9NSIv9 QfpXMUYCY7nBgLow2EsRMwYYDtrmC+VYlZSEyDAZxVsX9DPvTjREHqI X-Developer-Key: i=zhentao.guo@amlogic.com; a=ed25519; pk=5yfDKrjreXwcAoEUsdtWafy6YN500upXp/CgtnXjLVU= X-Endpoint-Received: by B4 Relay for zhentao.guo@amlogic.com/20251024 with auth_id=555 X-Original-From: Zhentao Guo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251123_193236_061025_CBA8AF0A X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: zhentao.guo@amlogic.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Introduce initial driver support for Amlogic's new video acceleration hardware architecture, designed for video stream decoding. Compared to the current Amlogic video decoder hardware architecture, this new implementation eliminates the Esparser hardware component, enabling direct vb2 buffer input. The driver is designed to support the V4L2 M2M stateless decoder API. The initial phase includes support for H.264 decoding on Amlogic S805X2 platform. The driver is capable of: - Supporting stateless H.264 decoding up to a resolution 1920x1088(on the S805X2 platform). - Supporting I/P/B frame handling. - Supporting vb2 mmap and dma-buf modes. - Supporting frame-based decode mode. (Note that some H.264 bitstreams require DPB reordering to generate reference lists, the stateless decoder driver cannot access reordered reference lists in this mode, requiring the driver to perform reference list reordering itself) - Supporting NV12/NV21 output. - Supporting Annex B start codes. This driver is tested with Gstreamer. Example: gst-launch-1.0 filesrc location=/tmp/video_640x360_mp4_hevc_450kbps_no_b.mp4 ! parsebin ! v4l2slh264dec ! filesink location=/tmp/output.yuv Retry the compliance test based on kernel 6.18-rc6: v4l2-compliance 1.30.1, 64 bits, 64-bit time_t Compliance test for aml-vdec-drv device /dev/video0: Driver Info: Driver name : aml-vdec-drv Card type : platform:aml-vdec-drv Bus info : platform:fe320000.video-codec Driver version : 6.18.0 Capabilities : 0x84204000 Video Memory-to-Memory Multiplanar Streaming Extended Pix Format Device Capabilities Device Caps : 0x04204000 Video Memory-to-Memory Multiplanar Streaming Extended Pix Format Detected Stateless Decoder Media Driver Info: Driver name : aml-vdec-drv Model : aml-vdec-drv Serial : Bus info : platform:fe320000.video-codec Media version : 6.18.0 Hardware revision: 0x00000000 (0) Driver version : 6.18.0 Interface Info: ID : 0x0300000c Type : V4L Video Entity Info: ID : 0x00000001 (1) Name : aml_dev_drv-source Function : V4L2 I/O Pad 0x01000002 : 0: Source Link 0x02000008: to remote pad 0x1000004 of entity 'aml_dev_drv-proc' (Video Decoder): Data, Enabled, Immutable Required ioctls: test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK test invalid ioctls: OK Allow for multiple opens: test second /dev/video0 open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK test for unlimited opens: OK Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported) Input ioctls: test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 0 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported) Control ioctls: test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 6 Private Controls: 0 Standard Compound Controls: 4 Private Compound Controls: 0 Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK test VIDIOC_TRY_FMT: OK test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported) test Composing: OK (Not Supported) test Scaling: OK (Not Supported) Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test CREATE_BUFS maximum buffers: OK test VIDIOC_REMOVE_BUFS: OK test VIDIOC_EXPBUF: OK test Requests: OK test blocking wait: OK Fluster test result of JVT-AVC_V1. Result: Ran 61/135 tests successfully - 52 test vectors failed due to interlaced or mbaff clips: The Amlogic stateless decoder driver only support bitstreams with frame_mbs_only_flags == 1. Test Vectors: cabac_mot_fld0_full cabac_mot_mbaff0_full cabac_mot_picaff0_full CABREF3_Sand_D CAFI1_SVA_C CAMA1_Sony_C CAMA1_TOSHIBA_B cama1_vtc_c cama2_vtc_b CAMA3_Sand_E cama3_vtc_b CAMACI3_Sony_C CAMANL1_TOSHIBA_B CAMANL2_TOSHIBA_B CAMANL3_Sand_E CAMASL3_Sony_B CAMP_MOT_MBAFF_L30 CAMP_MOT_MBAFF_L31 CANLMA2_Sony_C CANLMA3_Sony_C CAPA1_TOSHIBA_B CAPAMA3_Sand_F cavlc_mot_fld0_full_B cavlc_mot_mbaff0_full_B cavlc_mot_picaff0_full_B CVCANLMA2_Sony_C CVFI1_Sony_D CVFI1_SVA_C CVFI2_Sony_H CVFI2_SVA_C CVMA1_Sony_D CVMA1_TOSHIBA_B CVMANL1_TOSHIBA_B CVMANL2_TOSHIBA_B CVMAPAQP3_Sony_E CVMAQP2_Sony_G CVMAQP3_Sony_D CVMP_MOT_FLD_L30_B CVNLFI1_Sony_C CVNLFI2_Sony_H CVPA1_TOSHIBA_B FI1_Sony_E MR6_BT_B MR7_BT_B MR8_BT_B MR9_BT_B Sharp_MP_Field_1_B Sharp_MP_Field_2_B Sharp_MP_Field_3_B Sharp_MP_PAFF_1r2 Sharp_MP_PAFF_2r CVMP_MOT_FRM_L31_B - 3 test vectors failed due to unsupported bitstream. num_slice_group_minus1 greater than zero is not supported by the hardware. Test Vectors: FM1_BT_B FM1_FT_E FM2_SVA_C - 2 test vectors failed because SP_SLICE type is not supported by the hardware. Test Vectors: SP1_BT_A sp2_bt_b We are working with the remain failures, these failures have the same root cause. Signed-off-by: Zhentao Guo --- Changes in v2: - Fixed incorrect generation of the reference lists for some B-frames. - Rename or get rid of some properties in DTS and dt-binding. - Remove some useless code or helper functions, (eg. clk helper functions, reg I/O macros, and some superfluous print messages) replace these functions with existing ones. - Replace all the printk messages with dev_err/dev_info/dev_dbg - Use the helper functions from the existing meson-canvas driver. - Use clk_bulk_data to map clocks from DTS. - Retry the V4L2 Compliance test on 6.18-rc6, fix a newly introduced bug. - Link to v1: https://lore.kernel.org/r/20251027-b4-s4-vdec-upstream-v1-0-620401813b5d@amlogic.com --- Zhentao Guo (3): media: dt-bindings: Add Amlogic V4L2 video decoder decoder: Add V4L2 stateless H.264 decoder driver arm64: dts: amlogic: Add video decoder driver support for S4 SOCs .../bindings/media/amlogic,s4-vcodec-dec.yaml | 87 + MAINTAINERS | 7 + arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 27 + drivers/media/platform/amlogic/Kconfig | 1 + drivers/media/platform/amlogic/Makefile | 1 + drivers/media/platform/amlogic/vdec/Kconfig | 16 + drivers/media/platform/amlogic/vdec/Makefile | 4 + drivers/media/platform/amlogic/vdec/TODO | 7 + drivers/media/platform/amlogic/vdec/aml_vdec.c | 756 ++++++++ drivers/media/platform/amlogic/vdec/aml_vdec.h | 31 + drivers/media/platform/amlogic/vdec/aml_vdec_drv.c | 239 +++ drivers/media/platform/amlogic/vdec/aml_vdec_drv.h | 196 ++ drivers/media/platform/amlogic/vdec/aml_vdec_hw.c | 596 ++++++ drivers/media/platform/amlogic/vdec/aml_vdec_hw.h | 158 ++ .../platform/amlogic/vdec/aml_vdec_platform.c | 37 + .../platform/amlogic/vdec/aml_vdec_platform.h | 62 + drivers/media/platform/amlogic/vdec/h264.c | 1933 ++++++++++++++++++++ drivers/media/platform/amlogic/vdec/h264.h | 300 +++ drivers/media/platform/amlogic/vdec/reg_defines.h | 177 ++ 19 files changed, 4635 insertions(+) --- base-commit: 0c1c7a6a83feaf2cf182c52983ffe330ffb50280 change-id: 20251027-b4-s4-vdec-upstream-0603c1a4c84a Best regards, -- Zhentao Guo _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic