From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D06BCFD635 for ; Thu, 8 Jan 2026 08:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P91VOPWZYc7ck9DHO+aklRnmvNbnOPe46zfECGGm84U=; b=LvOqmp+EyN8MA6s0x0PZVL+NfW AMizl3uSBQCwMU4zDglVhIxCEDPJQN6Iu/z9t3648ciACq+40ohGeX6M/VuEhE5G5y4ewVKipIYX/ OVm2vzSpfAg8nDgclpizEQTml01Q8RovXJC4jaI5ZV/mEcnNKdXdn5QM5rugn8Mg+uOiUIGiTxncy N4fPV/X2kMUYbG48MR0xkGbL8jRIeGDO1FEKS4mfdoBzOhDFBPSgkc92PBpQrw3XKpzHvkYurdT1t RypOuVpqkQQ+jQXE+RRLgRd+YA2GPO+8JXWWv5ttyftXw1hv/oTAzhqVGGLsrxkeGhosdqQkOLsVk 7DlICwSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdlA3-0000000GFFH-04PM; Thu, 08 Jan 2026 08:14:27 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdlA0-0000000GFEC-3q6a; Thu, 08 Jan 2026 08:14:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 08A6260018; Thu, 8 Jan 2026 08:14:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B194C116C6; Thu, 8 Jan 2026 08:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767860063; bh=EtgY9/EVerR2uZrY6KJZ9kC/J3pcc8Nhql32Ojqiwoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tHqoozosIU8cDsP3+u6sm7M0ubuyctf0AYxcP9tphpkxQtszmGR7Tg17mXOu03IL2 5nE2xfP7ZngJKsk0roxvBy7ppI3AUirOVgrZRG1hBQqNUWdH68Hkc4LYn2ubn6nhyO 4d+c1Pr4G6j1g11+1SwUxX88gSsDBpF9cLBFfMUKZP44qVneUREuzNvNJIQhg8I4Q2 QSsC9OLAiALxNZ+F4RzEU8bYT6L5r51/UGmL2LyvYamiGMbAlXF152repnzP2Bykxu 47F+86tI1TQs64ivMCACn1iMGLTqq738E4D+F+QPUKYPMlwsKZawN0m91It/QgdPtv SsUnWqFgi2pmA== Date: Thu, 8 Jan 2026 09:14:21 +0100 From: Maxime Ripard To: Luca Ceresoli Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Matthias Brugger , AngeloGioacchino Del Regno , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 5/6] drm/exynos: hdmi: convert to of_drm_find_and_get_bridge() Message-ID: <20260108-acoustic-groovy-shark-1c6850@houat> References: <20260107-drm-bridge-alloc-getput-drm_of_find_bridge-3-v1-0-ef48a517828e@bootlin.com> <20260107-drm-bridge-alloc-getput-drm_of_find_bridge-3-v1-5-ef48a517828e@bootlin.com> MIME-Version: 1.0 In-Reply-To: <20260107-drm-bridge-alloc-getput-drm_of_find_bridge-3-v1-5-ef48a517828e@bootlin.com> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2908287733666842307==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============2908287733666842307== Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="iaxf263ybcspakt7" Content-Disposition: inline --iaxf263ybcspakt7 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 5/6] drm/exynos: hdmi: convert to of_drm_find_and_get_bridge() MIME-Version: 1.0 On Wed, Jan 07, 2026 at 05:22:03PM +0100, Luca Ceresoli wrote: > of_drm_find_bridge() is deprecated. Move to its replacement > of_drm_find_and_get_bridge() which gets a bridge reference, and ensure it > is put when done. >=20 > Signed-off-by: Luca Ceresoli Why can't we use next_bridge for this one? > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exyno= s/exynos_hdmi.c > index 01813e11e6c6..bfcf2fa62fe1 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -1779,7 +1779,7 @@ static int hdmi_bridge_init(struct hdmi_context *hd= ata) > return -EINVAL; > } > =20 > - hdata->bridge =3D of_drm_find_bridge(np); > + hdata->bridge =3D of_drm_find_and_get_bridge(np); > of_node_put(np); > =20 > if (!hdata->bridge) > @@ -2096,6 +2096,8 @@ static void hdmi_remove(struct platform_device *pde= v) > =20 > put_device(&hdata->ddc_adpt->dev); > =20 > + drm_bridge_put(hdata->bridge); > + > mutex_destroy(&hdata->mutex); > } Same story than in your part 2 series, it should be dropped in destroy. Maxime --iaxf263ybcspakt7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaV9nXAAKCRAnX84Zoj2+ dpQcAX4/DsMYcVghXzTl1wL4Eg875nz8oa8QzS5rCmiMvWyUXZDs9jjE+v4NJH9l XfmGlK0Bfij85bzMX8N3NHOZ0ga+3CVx6+FxmlxB26/EafiT6qVke+EY/dh8z5mV 6ouR1XkHOQ== =Htm4 -----END PGP SIGNATURE----- --iaxf263ybcspakt7-- --===============2908287733666842307== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============2908287733666842307==--