From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nick Xie <xieqinick@gmail.com>
Cc: neil.armstrong@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, martin.blumenstingl@googlemail.com,
khilman@baylibre.com, linux-kernel@vger.kernel.org,
xianwei.zhao@amlogic.com, nick@khadas.com,
linux-amlogic@lists.infradead.org, krzk+dt@kernel.org,
robh@kernel.org, linux-arm-kernel@lists.infradead.org,
jbrunet@baylibre.com
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding
Date: Wed, 14 Jan 2026 09:51:11 +0100 [thread overview]
Message-ID: <20260114-slick-passionate-mink-216a3a@quoll> (raw)
In-Reply-To: <20260114062549.68954-2-nick@khadas.com>
On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
> Add devicetree binding for Khadas VIM1S board based on
> Amlogic S4 S905Y4 SoC.
>
> Signed-off-by: Nick Xie <nick@khadas.com>
You still have the same From/SoB mismatch.
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 08d9963fe9259..55663e0f7f915 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -247,6 +247,12 @@ properties:
> - amlogic,aq222
> - const: amlogic,s4
>
> + - description: Boards with the Amlogic Meson S4 S905Y4 SoC
> + items:
> + - enum:
Yopu already have exactly such enum with such description, so your
compatible goes there. Look - it is called "Boards" - plural.
> + - khadas,vim1s
> + - const: amlogic,s4
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-01-14 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 6:25 [PATCH v2 0/2] arm64: dts: meson-s4: add support for Khadas VIM1S Nick Xie
2026-01-14 6:25 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding Nick Xie
2026-01-14 8:51 ` Krzysztof Kozlowski [this message]
2026-01-14 10:07 ` Nick Xie
2026-01-14 10:13 ` neil.armstrong
2026-01-14 10:33 ` Krzysztof Kozlowski
2026-01-14 11:25 ` Nick Xie
2026-01-14 12:07 ` neil.armstrong
2026-01-14 12:06 ` neil.armstrong
2026-01-14 6:25 ` [PATCH v2 2/2] arm64: dts: add initial device-tree for Khadas VIM1S Nick Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114-slick-passionate-mink-216a3a@quoll \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nick@khadas.com \
--cc=robh@kernel.org \
--cc=xianwei.zhao@amlogic.com \
--cc=xieqinick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®