From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98A0EC44507 for ; Mon, 13 Jul 2026 13:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yDVOUXIAJmVk8zQVznc/KkeZb78fppcAcbhdtbpb22s=; b=y1rdktiUvZg9AU ahWgsdW+Rkyzo9jH8gPItayLSc6Dch15bbfX+0I57pmR4bxZ8FO9lWBVMKtx/pXaja1kEIvE2xiw3 aNoEUHupLo2ZvWcA0HxexaJ5qhiHKONP4TNf4llpQjLstxawmlHNXUlZ7t6CYPzlRIYD2Yfut7fvK XmVSFWCpl7XxuazAvDyOvefgepq7/oO9QwEngBaD6FYSD0QYP/GQlOLQY6G1aeKYwCb5+2kKBRyzx xgDlKuyT4xm39qw9BlszI8rf7BVcyHRk2HDUNWJLhvqzUgpeB4eqbNO66sNedJBtYDZPUKI9e44qm NoSeWQvZaxwSHw0VvFaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjGaw-00000009MHv-0Bxn; Mon, 13 Jul 2026 13:21:14 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjGar-00000009MED-3TsT for linux-amlogic@lists.infradead.org; Mon, 13 Jul 2026 13:21:11 +0000 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DCDu2q1209914 for ; Mon, 13 Jul 2026 13:21:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1B1oa6NldI29ome8JkAuhcCrVCMdRvD2y8volZucecU=; b=HRMgAGLmTEjLL7NM fyUok4F7YQcqnppTYtirZjwB8UYNicMU6F1+I7N5ozfZx2/JtO+LcXq4XYQxgWGW ThUPjmF70f942+VTtukuLP+HPSK/avuY6favBLTLI19Qv6JfHRrCru8sMnGHeIiG voP3rzkT0P0xj7F7snSJX25ArsOqtqZeVvU8nSdc1t3AC3VJCMDLwYwVbIlta/oZ 5bKurWfOHT2SvIt2fHQQtW13/NkuuRvNSyeIAPx4eR7j7U2g+I5SecH0oNslpZ12 hFwzxIYh+Pa1/g5okCPXjEuXOQTJJdsLzxBwkiSFOhnXSoqCH/+UTcElkIB90IK9 c2+k/A== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcw4qrw3n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 13:21:09 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51bff5c7035so69011701cf.2 for ; Mon, 13 Jul 2026 06:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783948868; x=1784553668; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1B1oa6NldI29ome8JkAuhcCrVCMdRvD2y8volZucecU=; b=gkeknHm2zTtqDNPTTSsRSruiso+CZ72oRNpn3KR8Kca5tHxnzPqjx3239RfSg/bQ3A SuUUP17k+bhPIBfcacaPAaqWO+ujGtFsCDKKVtngY739Ixi3+r/mkVb5pX8K+V8t8bPk WiYBQplLlH0XGUylpXJd6XpuYobrmHcecGMEHv6nvKqUOCrgnEkKscr98Bhs8JI0SAei HkXg8A2dMzS7d5KMW35EXW7JdH6JKAnxPyhlz1+PpQtcRkH8hS1+COXWS1/2Yna0Y/6s 502yKiA+1kriVAjgUuz3ZDN1hoOaCozSJzsvya1Pxv22e0pTcvUy3ZdHSR1t4dQeYfcv 1cZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783948868; x=1784553668; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1B1oa6NldI29ome8JkAuhcCrVCMdRvD2y8volZucecU=; b=KPblyjH/m6itSS3+I2izUFSIoB/qNeQXV64fb+NMPuEd6AH30SOzo4uHBa9LRAGDEr od1odRz26RH6zLDWkwCnx715BCnZAaD72+ayK0i1wiDCgsnzk0D1u75FgbYCsTJLyKKx SQMJ2gJJHAdaIDQ6D+H0K/TTVxkf5GOHKoSnow/epfSLcZmkUpsXeOUiw2bcBWFCmvUj 2bKxVOQhySyg9ol0Gr9A+oxqDvKI41y2DxperVHKEd9psQZfwphiWwgGGm4GqaxpvEu1 a0/AoSSwlJBMIfDE0tpnpoChQT+xTF6q9d8pxwBL4HdOCyNMDH9wYmkCdWMuZoZ/envK i0gg== X-Forwarded-Encrypted: i=1; AHgh+RrNzDHHgdQSQZxY3Gn3WjDNGOOCy0akFrkrjramb8R8wMI/7Ch3i7prD6jX6udMg35fm/1P8oVM0zt1T3j6@lists.infradead.org X-Gm-Message-State: AOJu0YxW2nx5onVqvOXnd9s/yHFgYGQvNLMQuyhutYTx+Bnxy1wlMVMS B3te9wO5CzsefOBoW0JNKAY0JzirVqmZRpdjBf0u7F/YOMg4p8W7te6EHztLfr1a09uGMEEQyb3 GuKL2gte+AT6kjPTg4SXrQQOzbOzcjvromHfDYjYzXmV5CqeRwORMa1O1c7s3555R/FPaQQvN/g == X-Gm-Gg: AfdE7clnAOXD+asYBmzDOR+nJ9qCWfvD1c0xbdI2EddxRbPe0Nn1ggFcuTm53OjbSfv oRwqjzNp5AU2Bx0rSFoJss914lm6Z53enJQaTcA21TQ/Zrkcvp+Mh/fxa9uIfSpFNwsO30H0x4z MODWSC1e6rvoFIeEwWdO385lB1IieP2HPJseMZyWmdwX+mCdox0AQiRW0BQakDSBfhxf38PQfzr 5i8rE1UyFYe5G4Q+4shnojHxjREqFQJyo3vbabfCan3j8efJsazGIlTsVZ4g286WEB2vOEkKjjJ 371/W5VEtj1OVK0yfhzDLALDaHXAe2crGK9ubXiKziM+U0sBV7K7FG/J05CVSwOA4k8ws7uSAwb zevFnMh+z//bnvKfswMPOMTh8lt5hNI7PgPXgiry/ X-Received: by 2002:ac8:6f0f:0:b0:51a:8c86:bd40 with SMTP id d75a77b69052e-51cbf2bb069mr93022431cf.61.1783948868279; Mon, 13 Jul 2026 06:21:08 -0700 (PDT) X-Received: by 2002:ac8:6f0f:0:b0:51a:8c86:bd40 with SMTP id d75a77b69052e-51cbf2bb069mr93021511cf.61.1783948867610; Mon, 13 Jul 2026 06:21:07 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:8881:83b8:89fa:1a2a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6f3dcdsm354561715e9.3.2026.07.13.06.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 06:21:06 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 13 Jul 2026 15:20:30 +0200 Subject: [PATCH net-next v13 01/10] net: phy: aquantia: fix system interface type not updated in forced mode MIME-Version: 1.0 Message-Id: <20260713-qcom-sa8255p-emac-v13-1-119f8699ef8e@oss.qualcomm.com> References: <20260713-qcom-sa8255p-emac-v13-0-119f8699ef8e@oss.qualcomm.com> In-Reply-To: <20260713-qcom-sa8255p-emac-v13-0-119f8699ef8e@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Radu Rendec Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1751; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=jjMtp5SqAas4zIIzp6l5IEc/YbwGv5zChtMnC787rmU=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqVOYzzfnrx183EvrDrG4Ij0t7Dbry5xhQDBN63 sTHPBPheJ+JAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCalTmMwAKCRAFnS7L/zaE w1LgD/9qtqvWaJNIcmSJbF08/P2HiqqtPEBd1s+tyKeMo7yTuSVEomvSt9PQeumZk4luZvppMze BCjhLWx+6fOyjhWVSz8HBY65tAA1zD7DNVIs9qguS8J8Eq90NiKvfR7ZDr9usRfnKcKWxsWOHgG ojLZ9JC26nL2b+gxoo/vjBbVki55aAeUgxQGZz0qSU//7QXZA+OpLnwhW+P1mMQrYnuPu/MARCm bnmW2Z8D+kbpF4vgOOG6KYY6Xx4vv59wa4mGzYwTy5RnJK9fzo2so8pYw/lpa1A9XCm9gbZDWHE 6NZYLNQLxkY857AQzQnAMtuD1DqADDCt5IKRK8bDQdz1syR8/VCpUd/NCsYwjbqP/4rtmoVYY4+ nXsBxk4iuXvVwttd2OTIvw+ikxHFh5MNRIEdCJXtbA+nfzjLzy9U816KqDSzeyaAe22+gQoPAwb HnblJwwISfQH0LqYA+1jM4JEUC5SH3i4/XD//3GCfNpIZOrN8w4L3W1eopUVXLmIHDDP0Lt9nab xvVkp7PypSMfsI0At+9gRMCcikJJwfP+C2oM7ElLMHgQtDj2KemfCVk/c+WGO+bFkvXVAtBcGOR /emT2S12yGD/Gctx1pVyNrxdoAYZVAZD+2Zf4YHnVKyivlzdCOl9aa11AjnmAMRcxS2b4nQyJeb akLHRgl131BvtYg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDEzOSBTYWx0ZWRfX4M31/5Y4fwsY q/bN7AxW6vru44VqASSr6fXXV/vXM64y3jTJjGulih+SotNyGLCiuKIOJyA8eoBRgKQOxKbqrqK pmlAumUn4+n0tvd692pEm+l64NnfmaslRA0GXRj5Y4DxUJZLpY5hV/PSn9wj/GQrlnshFaWkPRn Lb0bCNrJwO0rkkzCtIFv8JHzbSS4zLa8cNQkWgyRqzcOw3nuMV3gjL/qF8h2I9dwQL8NwrvnpXW fTQaxSBqS4+puDE0eCLrz86+IPlulrWvySBaLzqPtpihWr92gzmC9X/+sbexHNTS9BxiCHs0lYp 5F7W/m9grf02yijC5lwxuQWB9HajRBegFTAqHUpgrOCkr0vdnKGpNj2gPFi9Id2MDwE4LUgCW0l 0eaQ2NjGrQ+EPh/syYQkv7y+w0Oquxfyh5avPn7iSuwBDIc1BTJao/2rKGKVXBb+CbwrTwEFSWi efsSTkf/99zhovWYUlw== X-Authority-Analysis: v=2.4 cv=HJrz0Itv c=1 sm=1 tr=0 ts=6a54e645 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=mooR1oPkU_hlknJbmfEA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: 2YKibdZJ9j7i2d5y-V19HDZL881pKFGR X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDEzOSBTYWx0ZWRfX8igKMpZbW7q+ DxuRkBx2u4WwVoqrCwSUADadwjVuKER6PP4eoSv0k/CPze3fbhn6Zor8e+pwJ/NfTtkU0cDaGsB qrDkrDk2bEHwHx2y6kUq3NabEkJT+8k= X-Proofpoint-ORIG-GUID: 2YKibdZJ9j7i2d5y-V19HDZL881pKFGR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130139 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260713_062109_891049_83C16B2B X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org aqr_gen1_read_status() decodes the MDIO_PHYXS_VEND_IF_STATUS register to determine which SerDes interface the PHY is currently using on its system side and stores the result in phydev->interface. phylink relies on this value to configure the MAC. The autoneg == AUTONEG_DISABLE check is not correct: MDIO_PHYXS_VEND_IF_STATUS is set by the PHY firmware based on the negotiated link speed, not based on whether autoneg was used to reach it. When the link comes up at 1G in forced mode, the register correctly reads SGMII, but the early return prevents phydev->interface from being updated. It stays at whatever value it held before (typically 2500BASE-X from the initial autoneg run), so phylink configures the MAC for the wrong interface and the link cannot come up. Remove the autoneg guard so that the system interface type is always decoded when the link is up. Cc: stable@vger.kernel.org Fixes: 110a2432c520 ("net: phy: aquantia: add downshift support") Signed-off-by: Bartosz Golaszewski --- drivers/net/phy/aquantia/aquantia_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c index e95d391a6dc233879ae1fb2a97758b3df9600ce5..b720e4e9028cc20823297e8bbd239121aeafa09f 100644 --- a/drivers/net/phy/aquantia/aquantia_main.c +++ b/drivers/net/phy/aquantia/aquantia_main.c @@ -544,7 +544,7 @@ static int aqr_gen1_read_status(struct phy_device *phydev) if (ret) return ret; - if (!phydev->link || phydev->autoneg == AUTONEG_DISABLE) + if (!phydev->link) return 0; /* The status register is not immediately correct on line side link up. -- 2.47.3 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic