From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00052C43458 for ; Mon, 13 Jul 2026 13:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tfCndyOFu2Eob3qLn3fs2Qb2O/IdddtmQTM+7+sbaNk=; b=bMJFWIguhChMbA yNTmDJGr/fTW4I3WkNREK5QUAPJgc5ZZteFCmUZagAWxHp8QidoAB6ZFC7GzU/ULwTfz9YeiA1eZv OesPO05x5ybQlJUgBEodOk6j17lJlRGXRmxYWbPN9AJZOO+f8jPeYFUWCKmG2nCHWr1ErazGfRCho DVrGd+iZxfwTMN0dXQWOteFERfHWQgzQEyDkFAJc9aDWFF1IMkfHLwE8Mkx9IViGnkTL/aDgnx9+/ p5IpSEJLNBWq7WSdXKUVAC/86W2Lup+hybyqDVJWeiPSVk6V8uLKrT28Ndq2+kBT4XyMTgZQCjP45 C3KQO6Rvh/BWCXVPoOnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjGbV-00000009NDn-3Ujo; Mon, 13 Jul 2026 13:21:49 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjGbP-00000009N5I-3U1f for linux-amlogic@bombadil.infradead.org; Mon, 13 Jul 2026 13:21:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=0iUvEQEb5V0jbH92pD3f0+p2Tcm2EEwWR0fzZ8QJ/4c=; b=Z3JfYCE4x5y+TLjtx4nffY9wgu i/C5WQXmz7VxBHWnTxftYSD/vh8SSLieHUCgVIvcxNblqtA4hTtYv9kbQT2IW0/W7lOF9i2DfUj8H e2aXb9TlBU8QPo+rKGL6E9itwbFW0z4ndrLSRjluQf7bniQpqsj3Up5xILJM59xJHLeftXpVJKLgy wyYBU0DCbV8Pj76aTIGZbPKaZ7twByCJYuwvCmxf00M5/NEwW96nZF4e9XWCqzP6lSNTDivx3INSV 7nnnNUfM1ZCqYirw8goyUaGpDTGj4Y8x90mRoz54wLfeKq7Bw42WyvtY4CXU8VYvDpHFrs1xNfa4f drSWYFzQ==; Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1wjGbI-0000000BdbG-1RX5 for linux-amlogic@lists.infradead.org; Mon, 13 Jul 2026 13:21:42 +0000 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DCDwE01494416 for ; Mon, 13 Jul 2026 13:21:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0iUvEQEb5V0jbH92pD3f0+p2Tcm2EEwWR0fzZ8QJ/4c=; b=LglMfE3iuaXTOvC+ Glk4qRQYP1S5h9C9BHTI8RQ5NJdjMZyMlsQsl5fbGN9kik4i7RA6B+kaxzVWS/MB AQ2J7J9DdIO8JCI1nDryAb8EyOQVoXHM/Gj/e3SfGjITUXUKhiiGqt+mvjpjEr5u Qtj5cWXSLd+AEl2d3ttJR3sh8V6bl+t0FWOUS4pVtm5zBFlaXd91t/H7WGorLh1Q xFp7XV18n+LvRnwDND0XpCMXYqLQvtYTEBLi66TqPSoB/JWUvFdxsXMu2LhjX3fl bBeT3r+MDRz95I8moyRXQ+uTEWUQMT/TAkSPos5ZuZb9lbQOJfRhS2UO7qLKesAy 4YslnA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcjnm2qhq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 13:21:34 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c1c7f135bso65369931cf.0 for ; Mon, 13 Jul 2026 06:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783948893; x=1784553693; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0iUvEQEb5V0jbH92pD3f0+p2Tcm2EEwWR0fzZ8QJ/4c=; b=Y2avs3mSBPg66rWEox9g4aOyP7mROxHnLp1PL5ptXh2wACT6H/fzeqkTKfagQlP+bV bIYq7FU997J5/YdH2zGFiscsNgx1DKeTkfMpGbly7Dpw2Oy4iOQhopZ01FzFAwgN1aE6 XU02YafimA2t/Bt2NRIDUxEZ0Fhm+TerixEab3ePDdsqZigeiEVc9PIK9DET8Jm8R8mY ZYk5UrwL7BQ5KTk7Q9Ew9Q6u3cothl/UNRCcmQYC/4D7htCfrND+X5GXp4kyfEJ23Zpf onB4/5OwrJ6qU6q+i/LvehNzep3gAXAjb3xOpDw2ee6FZNNAiqVGydRmc76jALDNRWDJ v5BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783948893; x=1784553693; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0iUvEQEb5V0jbH92pD3f0+p2Tcm2EEwWR0fzZ8QJ/4c=; b=YlWIHNW6NFGmLBkUu2c0gSYJIGjCNxJ+OuYkjAH6Lq5OXbGTOq9WdYbHBM/uH7l0nU 1vbxH8fckbwB4BI+lMcZL0Gu6RCHpOOcN7nUSotW/Cm8gPrhMcNJ8WFS8/121ne+GZdC wDGbvttsHkrhizW5UunFSzIKjt6axiCXDqIQXLJmXM04+vz/k5Xmqrxems0Gvp3GzwnV awmo0Xxl/xlLJ/MJCsN31DOzBGPlp4VmS4Uop77CkbsKzhbxl9PYTFoIkJ+uQT2yn/q9 G/3zsEDiUP2mA3qQCuSbHGdLmTuhUVdgnfPHIbd9xW93RDbD8PDnuj9iQX8Hc29xKeUc nZBA== X-Forwarded-Encrypted: i=1; AHgh+RraTvjzcrC7HG7HIVBdyx3Ey9Au/jEaqzPsVsJjoJ0ib4TriIjKMRKvVy6BQavkgA2voXDw8JB6xX2W5FD7@lists.infradead.org X-Gm-Message-State: AOJu0Yx870REPCVuVuamfJf7XUscDQR4SknreqWbYYicZDsF5ThxVHkz hUYqcYY1SOvmUGObBauVH12G7s0ID1qji7l3BCnDer+oZE+PGRXoOdk+SENn9DHslLQQhvDt/53 0ZKW/ITvsToibcly1gVSRR6RoT1ks6B1NhA1DtoKYwj32JaeULUmyihGzJCYWXMZxTHuChKcfx7 GCYeIcKw== X-Gm-Gg: AfdE7ck/BmOmXH2Pv8DYHyUjE/f7LMQdxrnA0l+jwksLVKxnFqrVftYDXprMGteAZGG 6j/tI/ZrN8YAdFSW9skjXqfaNSzdhkZHOIWtzwozASQxFx0vcus0JdaUPCOwODFEeEWS6P20Tqc tj+mXUnwIw73/vFPtnb4UhRqSqNHAy6/oJAePL/Czq09hnIJrCgKFaQA42x9f4GxDAKrOyUi9kD NO8W9k/FsfTTelkwTblphifkJ35ZHx6U7w146yUXV8ueqxQMED+6csHZWJrlWV2Rhix38SZWRo9 RfkZ/LYx7/puSELJDUp6eWnoq47U/W4f6hQRP9F+TMHhQ/7x9pOlQrbJhRDJwIyoR1FpZ0EmD01 28/5UT3BtT1VwjJEOF1wSi4CQGJCkppwNjPXSwTRU X-Received: by 2002:a05:622a:3cb:b0:51a:6feb:dc8f with SMTP id d75a77b69052e-51cbf0e0756mr87983141cf.9.1783948893502; Mon, 13 Jul 2026 06:21:33 -0700 (PDT) X-Received: by 2002:a05:622a:3cb:b0:51a:6feb:dc8f with SMTP id d75a77b69052e-51cbf0e0756mr87982631cf.9.1783948892921; Mon, 13 Jul 2026 06:21:32 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:8881:83b8:89fa:1a2a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6f3dcdsm354561715e9.3.2026.07.13.06.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 06:21:30 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 13 Jul 2026 15:20:36 +0200 Subject: [PATCH net-next v13 07/10] net: stmmac: qcom-ethqos: fix SGMII loopback not set on resume after speed change MIME-Version: 1.0 Message-Id: <20260713-qcom-sa8255p-emac-v13-7-119f8699ef8e@oss.qualcomm.com> References: <20260713-qcom-sa8255p-emac-v13-0-119f8699ef8e@oss.qualcomm.com> In-Reply-To: <20260713-qcom-sa8255p-emac-v13-0-119f8699ef8e@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Radu Rendec Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1420; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=SlOf+BhDICNYWid3SpsPo349aSqYaDdHZpfmoCBZZHw=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqVOY6LAQcF9quKJEcvEh90UXYXlVsW2Jh4yWPh RRmPDlSot2JAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCalTmOgAKCRAFnS7L/zaE w9aqD/955VoK6LaO6vaDxw6NTt3itus8v3c/OJJG0p98jDFCjD9YC2veyzrofOQ0TKWJWkmc/qq 5L+Ac3xpoWqBjo9EjcMJwbHZA7YDaQ1QBEwbfrOIYjfwaQvPgRz543CB2Rirv7mpI1ME/ZYGarG Lc53Oo+GNT1knmktmT98TP8TPiwyfLnv6s2jgbfzHlQVdSxInzl6Xba6PrCJHuhMLDi43O/hvtI hkq2+mkJvQnUya9sbFoNnDO5XbMFOxMtggKVASqfi5yaDZVn7M8rRonjE1EbIVHWfa/toUesOa0 P2e0vo0oOBPPSXJ3r+YZC31vRjm8PvCtAFda8qrWLHm10Na27nQ6aU+4dKx3LBtP6fXF1t/Sad5 GVj+DwHrUg0PX0oR+JFTj8EmlXXKuaFe9+36xK4HX8ntTUknyXl/r3jEBsr+BP3e+vriuO1WGBN 4gURGfViayyslZFJuqGaC3rGsj4SIfzqaN+4tboTUYzP7uHFYkFngFdmj/ItLNcy5oX2pCfSoIQ JoFgO/XoSylDbz5dTihBwgI4MureklGQDOz7Y1MVSeQl71Uo6PMERaIIUr/PlMJ2PFikXISCBbz B/8f1XlpUku81iFnZGKEliv4krJ2aF3MsOEoa7ov34PUKUoIyWfcroB/lyMGxpL2A5g4yFXqFEj krC1QUE24KD0tBA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-ORIG-GUID: EIwExUr4HPpQpeN31QpaCQOWvTZ3CDCd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDEzOSBTYWx0ZWRfXy3Hota24qotg w/DbWqhJQvYi1fzOovevcJwA6x8UMS8Q09jSfeYOa+JUuanheNqq4T2e0Z/rIX8rK7maRtOnZOh MYei12/RZ0kCPQfxVUuQM3lfuKvPcN/7eHqr1XfKWDIEfx640DtAekomJGrvlMf8wzYan7822Ya V4K/uTNR7rL1AWUvNQbYH17OR/clcYMzzv9uNhAiUtBydnQS4A/xiCdUC+vtxrucdPT5XbkclRE 5ATlMw9oxy++2NR2yVvZpD0AK362LbB11Gt+okfAj5kQkMFX/i4SiQgkt2DVG2FVA7iRd24Y88v nHKfmE+Pdw8KYvK2T2KoboEvwBoDuPVByL7vkEB5lHaPrM9U7CcZxyk/oMcessWggqbORzbJ8qe Ij0nPGw0zYW4WC8CfyMB91DSQlW2Z7TChXAqwO4OHViSa5jhMLVC+5BcgKnXQeupNDSi9HKYC5w YhxOeuNER3E7nFRO+OA== X-Proofpoint-GUID: EIwExUr4HPpQpeN31QpaCQOWvTZ3CDCd X-Authority-Analysis: v=2.4 cv=AfmB2XXG c=1 sm=1 tr=0 ts=6a54e65e cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=PjAGQVefHaMtIuCO3vkA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDEzOSBTYWx0ZWRfX4Tk2fY9LUKPy 9D1sKdumYLboN+K87a1fugE1qupYBVeMMAG0bf5O0hwZc4iS7xqY1hptfZO+zZvOK4uRcMZkGVI UvTIWSrGJwGVP1GHagXyC5435Y0YDjQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130139 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260713_142136_773628_B5175E6D X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The loopback in the MAC wrapper feeds the TX clock back into the RX path, while the SerDes is being powered up. Without it, dwmac4_dma_reset() polls a clock that never toggles and times out. qcom_ethqos_set_sgmii_loopback() gates this on phy_mode being 2500BASEX. mac_finish() now updates phy_mode to the runtime-resolved interface, any subsequent resume with a 1G SGMII link skips the loopback setup and the DMA reset hangs. Extend the guard to include PHY_INTERFACE_MODE_SGMII. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 9d19203ae4bd7dc17aca068f5eb88ff830e4e906..e083d7d55782ec8310e9375e466be00213667457 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -190,7 +190,8 @@ static void qcom_ethqos_set_sgmii_loopback(struct qcom_ethqos *ethqos, bool enable) { if (!ethqos->needs_sgmii_loopback || - ethqos->phy_mode != PHY_INTERFACE_MODE_2500BASEX) + (ethqos->phy_mode != PHY_INTERFACE_MODE_2500BASEX && + ethqos->phy_mode != PHY_INTERFACE_MODE_SGMII)) return; rgmii_updatel(ethqos, -- 2.47.3 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic