From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F3AFC531C7 for ; Thu, 23 Jul 2026 06:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KeKwu2wQsd1Bh+Dn2pAKNTDr7BcbYpOHB9/qn9KHdH8=; b=bGzMnAWVO4UOkm S695zu0QM+7iT0mtY+WmSnCfgcthghEKPxwJA3qgCVs8EdWhgvcNP4qliff36j6cmtJepKMSzNfzf 1gj1V4t/gzA8ZFRIXft9C/JvmxShPot3yRt5UHoc96+4GbqEIwazboIig/epEqBFglQ7YAlurV1p+ toin0CZ5KF2xas3Sa1vfrP0M1ntJLfXxQrcsp1tO5Ec8ULSS+uDqeF7vKzK3W1jBQdOsW+AFDZrd9 4w3j9YjKDZDqLxSi6vUq28m9PQLGTf21aDc63aTHHiiWU5PuHF353g5bQvFiHVFgccgHb6pruhD7X f3pF35522mUctXtT4V5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmnMS-0000000DalL-3Dy6; Thu, 23 Jul 2026 06:56:52 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmnMQ-0000000Dal9-2bU3 for linux-amlogic@lists.infradead.org; Thu, 23 Jul 2026 06:56:50 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 3D73743AF0; Thu, 23 Jul 2026 06:56:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB2F91F00A3A; Thu, 23 Jul 2026 06:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784789810; bh=/VmfauhnxpZCQ88u7hkyqlEensLfYHS5l3HR4TTCnwQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lWzOCbSG4PwFETqVB5oJzHZHWSwK5Szklodzjv6wD68z7ARJ0fAOzVdivt+ocR4Wf F9dytAP+xohXCvBihlnerU8+OyRwj3D+bKOTjSVKv/BUc4KRCTdcfgjwt2ZCbhQFB4 geQVcQAa5jT2Oh6G1LJF/yQap94IojexCYTBoKwNJ/T1/KTcIaePY0oNbT49bnFa1V GYL0tK+ZPVStKQG1viG1lx6+4E31WMH0Z8jK5uk9W58BPbZ923iw+RLy+gbOUKFY0u 57HR930iUwWGdy8XJKv76iW+30BSroWexl9IyCQ3krlDfac5BSfluHKRpN50QNTXWK nQuGlOgYxr4Uw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 4/4] spi: amlogic: spisg: Add support for A9 controller features To: "Xianwei Zhao" Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <20260723-a9-spisg-v2-4-9fc39106b7e2@amlogic.com> References: <20260723-a9-spisg-v2-0-9fc39106b7e2@amlogic.com> <20260723-a9-spisg-v2-4-9fc39106b7e2@amlogic.com> Date: Thu, 23 Jul 2026 06:56:49 +0000 Message-Id: <20260723065649.AB2F91F00A3A@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBUaW1lb3V0IGNvbXBsZXRpb24gcmFjZSBsZWFkaW5nIHRvIGNyb3NzLW1lc3NhZ2Ug Y29ycnVwdGlvbiBhbmQgcG90ZW50aWFsIERNQSBVQUYuCi0gW0hpZ2hdIFBNIHJ1bnRpbWUgdXNh Z2UgY291bnRlciBsZWFrIGFuZCBtaXNzaW5nIGRpc2FibGUgb24gcHJvYmUgZXJyb3IgYW5kIG1v ZHVsZSByZW1vdmUuCi0gW0hpZ2hdIERyaXZlciBlcnJvbmVvdXNseSBhc3N1bWVzIERNQSBhZGRy ZXNzIDAgaXMgaW52YWxpZCBmb3IgbWFwcGluZyB0cmFja2luZy4KLSBbSGlnaF0gVGhlIHJ1bnRp bWUgUE0gcmVzdW1lIGNhbGxiYWNrIGlnbm9yZXMgY2xvY2sgZW5hYmxlbWVudCBlcnJvcnMuCi0t CgotLS0gUGF0Y2ggWzRdOiBbUEFUQ0ggdjIgNC80XSBzcGk6IGFtbG9naWM6IHNwaXNnOiBBZGQg c3VwcG9ydCBmb3IgQTkgY29udHJvbGxlciBmZWF0dXJlcyAtLS0KY29tbWl0IDczM2Y4ZTk4NmE4 ODE2MTI0NWZkZjI2MWFmNjBlZTVmMTZlNDY0OGMKQXV0aG9yOiBYaWFud2VpIFpoYW8gPHhpYW53 ZWkuemhhb0BhbWxvZ2ljLmNvbT4KCnNwaTogYW1sb2dpYzogc3Bpc2c6IEFkZCBzdXBwb3J0IGZv ciBBOSBjb250cm9sbGVyIGZlYXR1cmVzCiAgICAKVGhlIEFtbG9naWMgQTkgU1BJU0cgY29udHJv bGxlciBleHRlbmRzIHRoZSBBNCBjb250cm9sbGVyIHdpdGggYWRkaXRpb25hbApjb25maWd1cmF0 aW9uIG9wdGlvbnMuIEFkZCBTb0Mtc3BlY2lmaWMgY2FwYWJpbGl0eSBkYXRhIGFuZCBjb25maWd1 cmUKdGhlc2UgZmVhdHVyZXMgd2hlbiB0aGV5IGFyZSBzdXBwb3J0ZWQgYnkgdGhlIHVuZGVybHlp bmcgaGFyZHdhcmUuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NwaS9zcGktYW1sb2dpYy1zcGlz Zy5jIGIvZHJpdmVycy9zcGkvc3BpLWFtbG9naWMtc3Bpc2cuYwo+IGluZGV4IDJkNjZmMDBkY2Nk NDUuLmJjOTU2NGFlZjI0NTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9zcGkvc3BpLWFtbG9naWMt c3Bpc2cuYwo+ICsrKyBiL2RyaXZlcnMvc3BpL3NwaS1hbWxvZ2ljLXNwaXNnLmMKClsgLi4uIF0K Cj4gQEAgLTU0Miw3ICs1NjYsMTMgQEAgc3RhdGljIGludCBhbWxfc3Bpc2dfdHJhbnNmZXJfb25l X21lc3NhZ2Uoc3RydWN0IHNwaV9jb250cm9sbGVyICpjdGxyLAo+ICAJCQkJICAgICAgIHhmZXIt PmVmZmVjdGl2ZV9zcGVlZF9oeik7Cj4gIAl9Cj4gIAo+IC0JaWYgKGNzX2hvbGRfaW5fc2Nsaykg ewo+ICsJaWYgKGRhdGEgJiYgZGF0YS0+Y3NfaG9sZF9jdHJsKSB7Cj4gKwkJY3NfaG9sZF9pbl9z Y2xrID0gY3NfaG9sZF9pbl9zY2xrID8gOiAxOwo+ICsJCXZhbCA9IGNzX2hvbGRfaW5fc2NsayAq IChGSUVMRF9HRVQoQ0ZHX0NMS19ESVYsIHNwaXNnLT5jZmdfYnVzKSArIDEpOwo+ICsJCXZhbCA9 IG1pbl90KHUzMiwgMHg3RkZGLCB2YWwpOwo+ICsJCUZJRUxEX01PRElGWShDRkdfQ1NfSE9MRCwg JnNwaXNnLT5jZmdfc3BpLCB2YWwpOwo+ICsJCWRlc2MtLTsKPiArCX0gZWxzZSBpZiAoY3NfaG9s ZF9pbl9zY2xrKSB7Cj4gIAkJLyogYWRkaXRpb25hbCBudWxsLWRlc2NyaXB0b3IgdG8gYWNoaWV2 ZSB0aGUgY3MtaG9sZCBkZWxheSAqLwo+ICAJCWFtbF9zcGlzZ19zZXR1cF9udWxsX2Rlc2Moc3Bp c2csIGRlc2MsIGNzX2hvbGRfaW5fc2Nsayk7Cj4gIAkJZGVzYy0tOwoKW1NldmVyaXR5OiBIaWdo XQpUaGlzIGlzIGEgcHJlLWV4aXN0aW5nIGlzc3VlLCBidXQgZG9lcyBhbWxfc3Bpc2dfdHJhbnNm ZXJfb25lX21lc3NhZ2UoKSBoYXZlIGEKdGltZW91dCBjb21wbGV0aW9uIHJhY2UgdGhhdCBjb3Vs ZCBsZWFkIHRvIERNQSB1c2UtYWZ0ZXItZnJlZT8KCklmIHdhaXRfZm9yX2NvbXBsZXRpb25fdGlt ZW91dCgpIGV4cGlyZXMsIHRoZSBkcml2ZXIgYXR0ZW1wdHMgdG8gc3RvcCB0aGUKdHJhbnNmZXIg Ynkgd3JpdGluZyAwIHRvIFNQSVNHX1JFR19ERVNDX0xJU1RfSDoKCglpZiAod2FpdF9mb3JfY29t cGxldGlvbl90aW1lb3V0KCZzcGlzZy0+Y29tcGxldGlvbiwgLi4uKSkgewoJCXJldCA9IHNwaXNn LT5zdGF0dXMgPyAtRUlPIDogMDsKCX0gZWxzZSB7CgkJLyogc3RvcCB0cmFuc2ZlciAqLwoJCXJl Z21hcF93cml0ZShzcGlzZy0+bWFwLCBTUElTR19SRUdfREVTQ19MSVNUX0gsIDApOwoJCXJldCA9 IC1FVElNRURPVVQ7Cgl9CgpTaW5jZSBpdCBmYWlscyB0byBkaXNhYmxlIHRoZSBoYXJkd2FyZSBp bnRlcnJ1cHQgb3Igc3luY2hyb25pemUgd2l0aCB0aGUgSVJRCmhhbmRsZXIgdmlhIHN5bmNocm9u aXplX2lycSgpLCBjb3VsZCBhIGRlbGF5ZWQgaGFyZHdhcmUgaW50ZXJydXB0IGNhbGwKY29tcGxl dGUoJnNwaXNnLT5jb21wbGV0aW9uKSBzbGlnaHRseSBsYXRlPwoKSWYgdGhpcyBoYXBwZW5zIGR1 cmluZyBvciBqdXN0IGFmdGVyIHRoZSBuZXh0IFNQSSBtZXNzYWdlIGNhbGxzCnJlaW5pdF9jb21w bGV0aW9uKCksIGl0IHdvdWxkIGltbWVkaWF0ZWx5IHNhdGlzZnkgdGhlIG5ldyBtZXNzYWdlJ3MK Y29tcGxldGlvbiB3YWl0LCB1bm1hcHBpbmcgdGhlIERNQSBidWZmZXJzIHdoaWxlIHRoZSBoYXJk d2FyZSBpcyBhY3RpdmVseQp1c2luZyB0aGVtLgoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzbid0 IGEgYnVnIGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwgYnV0IGRvZXMgdGhpcyBkcml2ZXIgZXJy b25lb3VzbHkKYXNzdW1lIERNQSBhZGRyZXNzIDAgaXMgaW52YWxpZCBmb3IgbWFwcGluZyB0cmFj a2luZz8KCkluIGFtbF9zcGlzZ19zZXR1cF90cmFuc2ZlcigpIGFuZCBhbWxfc3Bpc2dfY2xlYW51 cF90cmFuc2ZlcigpLCB0aGUgY29kZSBjaGVja3MKaWYgdGhlIG1hcHBlZCBETUEgYWRkcmVzcyBp cyB6ZXJvIHRvIGRldGVybWluZSBpZiBhIG1hcHBpbmcgZXhpc3RzOgoKCWlmIChkZXNjLT50eF9w YWRkcikgewoJCWlmIChGSUVMRF9HRVQoQ0ZHX1RYRF9NT0RFLCBkZXNjLT5jZmdfc3RhcnQpID09 IFNQSVNHX0RBVEFfTU9ERV9TRykgewoJCQlkbWFfdW5tYXBfc2luZ2xlKGRldiwgKGRtYV9hZGRy X3QpZGVzYy0+dHhfcGFkZHIsCgkJCQkJIGV4ZGVzYy0+dHhfY2NzZ19sZW4sIERNQV9UT19ERVZJ Q0UpOwoJCQlrZnJlZShleGRlc2MtPnR4X2Njc2cpOwoKU2luY2UgMCBpcyBhIHZhbGlkIERNQSBh ZGRyZXNzIG9uIHNvbWUgcGxhdGZvcm1zLCBpZiBkbWFfbWFwX3NpbmdsZSgpCnN1Y2Nlc3NmdWxs eSBtYXBzIGEgYnVmZmVyIHRvIGFkZHJlc3MgMCwgd291bGQgdGhpcyBza2lwIHRoZSB1bm1hcCBh bmQga2ZyZWUKY2FsbHMsIGxlYWtpbmcgbWVtb3J5IGFuZCB0aGUgRE1BIG1hcHBpbmc/IFNob3Vs ZCB0aGlzIHVzZSBhIHNlcGFyYXRlIGJvb2xlYW4KZmxhZyBsaWtlIHR4X21hcHBlZCBpbnN0ZWFk IG9mIHRlc3RpbmcgdGhlIERNQSBhZGRyZXNzIHZhbHVlPwoKWyAuLi4gXQoKPiBAQCAtNzczLDYg KzgwNSwyMSBAQCBzdGF0aWMgaW50IGFtbF9zcGlzZ19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQo+ICAKPiAgCXNwaXNnLT5jZmdfc3BpID0gRklFTERfUFJFUChDRkdfU0ZMQVNI X1dQLCAxKSB8Cj4gIAkJCSBGSUVMRF9QUkVQKENGR19TRkxBU0hfSEQsIDEpOwo+ICsKPiArCWlm IChzcGlzZy0+ZGF0YSAmJiBzcGlzZy0+ZGF0YS0+bW9faWRsZV9vdXRwdXRfY3RybCkgewo+ICsJ CWlmICghb2ZfcHJvcGVydHlfcmVhZF91MzIoZGV2LT5vZl9ub2RlLCAiYW1sb2dpYyxtby1pZGxl LW91dHB1dCIsICZ2YWwpKQo+ICsJCQlzcGlzZy0+Y2ZnX3NwaSB8PSAgRklFTERfUFJFUChDRkdf TU9fSURMRV9PVVRQVVQsIHZhbCk7Cj4gKwkJZWxzZQo+ICsJCQlzcGlzZy0+Y2ZnX3NwaSB8PSAg RklFTERfUFJFUChDRkdfTU9fSURMRV9PVVRQVVQsIDApOwo+ICsJfQo+ICsKPiArCWlmIChzcGlz Zy0+ZGF0YSAmJiBzcGlzZy0+ZGF0YS0+d29yZF9nYXBfY3RybCkgewo+ICsJCWlmICghb2ZfcHJv cGVydHlfcmVhZF91MzIoZGV2LT5vZl9ub2RlLCAiYW1sb2dpYyx3b3JkLWdhcCIsICZ2YWwpKQo+ ICsJCQlzcGlzZy0+Y2ZnX3NwaSB8PSAgRklFTERfUFJFUChDRkdfV09SRF9HQVAsIHZhbCk7Cj4g KwkJZWxzZQo+ICsJCQlzcGlzZy0+Y2ZnX3NwaSB8PSAgRklFTERfUFJFUChDRkdfV09SRF9HQVAs IDEpOwo+ICsJfQo+ICsKPiAgCWlmIChzcGlfY29udHJvbGxlcl9pc190YXJnZXQoY3RscikpIHsK PiAgCQlzcGlzZy0+Y2ZnX3NwaSB8PSBGSUVMRF9QUkVQKENGR19TTEFWRV9FTiwgMSk7Cj4gIAkJ c3Bpc2ctPmNmZ19idXMgPSBGSUVMRF9QUkVQKENGR19UWF9UVU5JTkcsIDB4Zik7CgpbU2V2ZXJp dHk6IEhpZ2hdClRoaXMgaXNuJ3QgYSBidWcgaW50cm9kdWNlZCBieSB0aGlzIHBhdGNoLCBidXQg ZG9lcyBhbWxfc3Bpc2dfcHJvYmUoKSBsZWFrCnRoZSBQTSBydW50aW1lIHVzYWdlIGNvdW50ZXIg b24gZXJyb3IgcGF0aHM/CgpUaGUgZHJpdmVyIGVuYWJsZXMgUE0gcnVudGltZSBhbmQgaW5jcmVt ZW50cyB0aGUgdXNhZ2UgY291bnRlcjoKCglwbV9ydW50aW1lX3NldF9hY3RpdmUoJnNwaXNnLT5w ZGV2LT5kZXYpOwoJcG1fcnVudGltZV9lbmFibGUoJnNwaXNnLT5wZGV2LT5kZXYpOwoJcG1fcnVu dGltZV9yZXN1bWVfYW5kX2dldCgmc3Bpc2ctPnBkZXYtPmRldik7CgpJZiBhIHN1YnNlcXVlbnQg b3BlcmF0aW9uIGxpa2UgZGV2bV9yZXF1ZXN0X2lycSgpIGZhaWxzLCB0aGUgY29kZSBicmFuY2hl cyB0bwpvdXRfY2xrIGFuZCByZXR1cm5zIHdpdGhvdXQgZGVjcmVtZW50aW5nIHRoZSB1c2FnZSBj b3VudGVyIG9yIGRpc2FibGluZyBQTQpydW50aW1lLiAKCkFkZGl0aW9uYWxseSwgYW1sX3NwaXNn X3JlbW92ZSgpIGRvZXMgbm90IGFwcGVhciB0byBjYWxsIHBtX3J1bnRpbWVfZGlzYWJsZSgpLAp3 aGljaCBjb3VsZCBsZWF2ZSB0aGUgZGV2aWNlIGRhbmdsaW5nIGluIHRoZSBQTSBydW50aW1lIGNv cmUgYWZ0ZXIgbW9kdWxlCnVubG9hZC4KClsgLi4uIF0KCj4gQEAgLTg1OSw2ICs5MDYsMTMgQEAg c3RhdGljIGludCBzcGlzZ19yZXN1bWVfcnVudGltZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIAly ZXR1cm4gMDsKPiAgfQo+ICAKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBhbWxfc3Bpc2dfZGF0YSBh OV9zcGlzZ19kYXRhID0gewo+ICsJLm1vX2lkbGVfb3V0cHV0X2N0cmwgPSB0cnVlLAo+ICsJLndv cmRfZ2FwX2N0cmwgPSB0cnVlLAo+ICsJLmNzX2hvbGRfY3RybCA9IHRydWUsCj4gKwkuY3Nfc2V0 dXBfZXh0ZW5kX2N0cmwgPSB0cnVlLAo+ICt9Owo+ICsKCltTZXZlcml0eTogSGlnaF0KVGhpcyBp cyBhIHByZS1leGlzdGluZyBpc3N1ZSwgYnV0IGRvZXMgc3Bpc2dfcmVzdW1lX3J1bnRpbWUoKSBp Z25vcmUgY2xvY2sKZW5hYmxlbWVudCBlcnJvcnM/CgpJbiBzcGlzZ19yZXN1bWVfcnVudGltZSgp LCB0aGUgZHJpdmVyIGNhbGxzOgoKCWNsa19wcmVwYXJlX2VuYWJsZShzcGlzZy0+Y29yZSk7Cglj bGtfcHJlcGFyZV9lbmFibGUoc3Bpc2ctPnNjbGspOwoKSWYgY2xvY2sgZW5hYmxlbWVudCBmYWls cywgdGhlIGZ1bmN0aW9uIHN0aWxsIHJldHVybnMgMCAoc3VjY2VzcykuIENvdWxkIHRoaXMKdHJp Y2sgdGhlIFBNIHJ1bnRpbWUgY29yZSBpbnRvIGJlbGlldmluZyB0aGUgZGV2aWNlIGlzIGFjdGl2 ZSwgY2F1c2luZwpzdWJzZXF1ZW50IE1NSU8gcmVnaXN0ZXIgYWNjZXNzZXMgdG8gaGFuZyB0aGUg YnVzIG9yIGNyYXNoIHRoZSBzeXN0ZW0gc2luY2UKdGhlIGNsb2NrIGRvbWFpbiBpcyBvZmY/Cgot LSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIw MjYwNzIzLWE5LXNwaXNnLXYyLTAtOWZjMzkxMDZiN2UyQGFtbG9naWMuY29tP3BhcnQ9NAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dp YyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=