From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D73AC5CFEB for ; Thu, 13 Aug 2026 07:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3cY7xTA48gQMg1Mdf5nFnaYKcAB7rJzK5q3tP57EFFA=; b=jTwjPzg4G12Htt EptWmvcPBMkGjgScB7nxE1wEv7ho71tn6ICCluYRPblONorZsBf6i56m5ht/fmvtDju5NAYg8V1dn ma9h25HsPaTloSicrg5memhGCKQR3VBI8jU2AuKgvi1FaviXVWOF6bfi0lVJQUJoKBaqMc+8MHFAq AdSfNKQFiGIkiWwY/8IsAI0naqWOprRgtF6HL0UpLZLVljE+qfmeQ4Xp7oLZc9iPQAPb0kM3wOx/U rD8SZ7wkCAbtiCr4IYHIuqrsW0CMAX7qiULrlEmrD6dgKoxohold5KCtyNwMWg5avErtmdP3AdMwB fuXyr00A4FwAMcLU0sfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuPS6-0000000HYUR-1IJ8; Thu, 13 Aug 2026 07:02:10 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuPS4-0000000HYUI-3mF2; Thu, 13 Aug 2026 07:02:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A4EAC438AE; Thu, 13 Aug 2026 07:02:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D8A11F000E9; Thu, 13 Aug 2026 07:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786604527; bh=/gqKioEF1GbavDA4gwe7ihUQosNd/QI2W5YICXn7nnM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=VPNynnMKL0D+jC2TYBCxyz6/CIOrImpUbn9HaqmsYgbOJXdkyDNTUWGSAAkfUj210 qzNYoVGaM2Lh/HZrM9fAkftOBaDQ1wReQ9dLFTc2G8JskEYyMCgpS6QZvKLfE5+cyP 3Iw3Wb+BOP/gG6i9vqc6e+CIPywd97oWkr9otA7rHSZ3V6/dLZALCRccRgUzzs7qWn qQ1RO7HelgDVVyYRwLz4mNS9E1L7vEA8yop7bsKrklGsZZ3wiHzF682nsnyPwYbsf8 4TrMzMPPokVRUcU23LStE2v79ttyY7xstReSObt4x9mtUpvW57g4uNYKprJLuXdM56 2Wjwj97PEl8fw== Date: Thu, 13 Aug 2026 09:01:59 +0200 From: Krzysztof Kozlowski To: Zhentao Guo Cc: Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder Message-ID: <20260813-rustling-sassy-terrier-11b99d@quoll> References: <20260812-b4-s4-vdec-upstream-v7-0-3fae085861bd@amlogic.com> <20260812-b4-s4-vdec-upstream-v7-3-3fae085861bd@amlogic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260812-b4-s4-vdec-upstream-v7-3-3fae085861bd@amlogic.com> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Aug 12, 2026 at 10:41:25AM +0800, Zhentao Guo wrote: > Describe the initial support for the V4L2 stateless video decoder > driver used with the Amlogic S4 (S805X2) platform. > > Signed-off-by: Zhentao Guo > --- > .../devicetree/bindings/media/amlogic,s4-vdec.yaml | 111 +++++++++++++++++++++ > 1 file changed, 111 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml > new file mode 100644 > index 000000000000..b5af3f931b26 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml > @@ -0,0 +1,111 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2025 Amlogic, Inc. All rights reserved > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/amlogic,s4-vdec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Video Decode Accelerator > + > +maintainers: > + - Zhentao Guo > + > +description: > + The Video Decoder Accelerator present on Amlogic SOCs. > + It supports stateless h264 decoding. > + > +properties: > + compatible: > + const: amlogic,s4-vdec > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: dos > + - const: dmc > + > + interrupts: > + maxItems: 2 > + > + interrupt-names: > + items: > + - const: hvdec > + - const: vdec vdec is the name of the module, so not really useful name. > + > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: dos > + - const: vdec Same here > + - const: hevcf > + > + power-domains: > + maxItems: 2 > + > + power-domain-names: > + items: > + - const: vdec > + - const: hvdec Same here. > + > + resets: > + maxItems: 1 > + > + amlogic,canvas: > + description: should point to a canvas provider node You basically duplicate the property name. Say something useful, what is it used for? > + $ref: /schemas/types.yaml#/definitions/phandle > + > + secure-monitor: > + description: phandle to the secure-monitor node Can a property whose type is a phandle and is called "secure-monitor" be not "phandle to the secure-monitor node"? Write useful code, not redundant. Anyway, missing vendor prefix as it is not a generic property (otherwise point me to generic schema defining it). Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic