From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3A08C79F9E for ; Tue, 8 Sep 2026 14:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yDVOUXIAJmVk8zQVznc/KkeZb78fppcAcbhdtbpb22s=; b=g3fGdqHsRsj3Zz Yf/NsW8VU9lQ5sq9RktNXUaL4Ral9lJMNYewOKqdljZ9aV3+BFrObs2XaCjhTonVFWUD3Elw/1CXf z/5SCe309I3tFr0IizgmegCIqCep+/CUlu7vaLWoDPTKIFC5K79mjNubaOIhubRsmoAgJIFCORVz0 0uMeQSYgpTOYQzcU4zqnqGd/4cTdTucFDLaV4omztv0D+DZzPuqka8Mj1zMV5nE+uJvtUFV9sUPg4 OKajswWdA2Fou88YbZMJpvIr8N65uEj5Y+3vPgckkKjr8vlbZllegFZIk/mRiGebK0HiiqECkZRN8 VEy+uDa+xAgdeUl1dCPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3xGt-00000009MBq-49bx; Tue, 08 Sep 2026 14:58:03 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3xGr-00000009MAT-0crm for linux-amlogic@lists.infradead.org; Tue, 08 Sep 2026 14:58:02 +0000 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 688EjGr73627425 for ; Tue, 8 Sep 2026 14:57:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1B1oa6NldI29ome8JkAuhcCrVCMdRvD2y8volZucecU=; b=kTCIk8j3aHSmnyqY 9b9gAQZQARWVR3bSRn/kfttx9qeVk826CqCyiJd6aRp1CZxK//jlGlUhPXPPIy2A aaiiqRq/66s/ABM+d/LJjRY5eyqbmvwns0JFx6u0RUhMxE45AFN06bhLhWzxo22M mVLWczys72gHIPS793OZ+o4ATDbtATe+mSW1aB5GcgP5QZ/QGXumCoLMAKcFau2F 2kf/ks5UlsmIbBiISLBy33wz8b80JHwLe9FtVYGxTshU9RX2DuSqaapuTmFcn2hf PYKZLnfB54w6+Z3ljGEg+wx0pThcjPftNaGb7B+emkgfjsIl3ToB5sYGMZowR8BU oL66XA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjcv7j7qs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 14:57:59 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93903622880so923538685a.0 for ; Tue, 08 Sep 2026 07:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788879479; x=1789484279; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1B1oa6NldI29ome8JkAuhcCrVCMdRvD2y8volZucecU=; b=ah20zlwKcqmlMrOWeHMcxVC+C19l2ba10TDXmk/cwgYBddp3hNjhOzpF12lMKVmQhS B5VjKMcM13b9zrWTqq+pHfKTXbgkQOG0AzCMUo7lcG5VzY9CfYLzUu+CWr53fYydbS25 5LhGDCDnuoaoc4Re5KFU1hhTKwlzz9k3rQi6WoBGZCliOXMnKlrYqVJahdrVcY1xLnE/ lvydXXZgDxQ035s3gwhK5YMqO3awEmphm68Uls7p5Q1KJ7tC1CBjdWxqb9bK+hwvCON+ NKQ0bnaY6b+/A5ciCxHqLRmYtRmkjwWkXpYMcY7anHCAQdKUsuwDxHZZbc/0xW506ono kMXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788879479; x=1789484279; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1B1oa6NldI29ome8JkAuhcCrVCMdRvD2y8volZucecU=; b=cXyUWNZL1j6/VeSFYT1oZe7E1XzlKgJutkxydK2ygJrFfZsMJ6PYSv9Obo7u9X9Ih7 Pspx/2JmhLdO08bIJZtwRTYBM4Wm1+RbYQyIrdwiahUunPwfmQqUbYzZix+MojajnK5f eYoP2118zUidgWtbkJg124kLi7/vUMcyMiEcVWPNr/eb2c+yL2hcfsQgwVAaS38TbIMT 1p95+s+OKEpneSZgKKaDvD8rEiUd93kzR4JGTCTvQX4+kLOYf6sBaBkhe4qa/UoO6dCb VHYuJso0AY0tOXiJDSZpjsKYYD9Rz7gc6vuhYu85cPT3Sm4dC0WzkbfwfUjnHj9shT3w lxtA== X-Forwarded-Encrypted: i=1; AKwUvBxkZVI8P+2CLUrBJW0xyQuH4348q4vURJFsGju5ZSoU1KB7pZSneBeYFj2meO0XRXEOWWbCyIOzgx24ntar@lists.infradead.org X-Gm-Message-State: AFuF++kRMeunH/3d0jedpbXb2rHZPUW/LKxpA1VTPlLuFE65ZZ31/9g0 FWDpqQX/zpNRZEbPtlRZsxMakYV2IYbHUA1OqRtBSzc+o0xh7Xj8n4bwioJ6yosSabiJQYlUCaY wAZ8pXDC8mDR4ag19CJ6z84L8b2Rzi6UT/yETFNYovRNIMl240g609kUG2MSzD3/W0soUunj0Ng == X-Gm-Gg: AYBFou3hdcFwst8ML1EQQZmk765fHgdc9sxL7ZfjFjvP+k5BgnAypJGfefnZnC+6UKm ZH5Ic4jMDufQexqzWapYE/Q/shzfiaVvIjmdgSeDi/z2Y3qCemNqWU/yqfOf4CFB8QxA1MY9lLx niw7nJt4g5oJdTNeWodnlKV9yT2NwfekfR39lLRMyiX3jb/DJeBB96lwv4qqazGuIYpJhse2KiZ E4fZ0r1egzsNe48IjNAA5jhgGFXzpcaB/mEq3IPVJh8WZ3yFBpMYSnMbenZOnbaFSvj27racItt HjsxxMo9cpFMOftOPOH1US4yDjNYYLAuawZ/be5G3QnLc4L7FstDRy6fzy83LzuLylto+VWJijd /WT0TmXWU1Zodx29j1MZt+fnHCqpK X-Received: by 2002:a05:620a:1a20:b0:939:72cb:baee with SMTP id af79cd13be357-93972cbbc65mr2826566685a.37.1788879478660; Tue, 08 Sep 2026 07:57:58 -0700 (PDT) X-Received: by 2002:a05:620a:1a20:b0:939:72cb:baee with SMTP id af79cd13be357-93972cbbc65mr2826558885a.37.1788879478118; Tue, 08 Sep 2026 07:57:58 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:79a2:f118:df09:fe51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485958f1493sm25191276f8f.37.2026.09.08.07.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 07:57:57 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Sep 2026 16:57:20 +0200 Subject: [PATCH net-next v14 01/10] net: phy: aquantia: fix system interface type not updated in forced mode MIME-Version: 1.0 Message-Id: <20260908-qcom-sa8255p-emac-v14-1-ec212b747a7d@oss.qualcomm.com> References: <20260908-qcom-sa8255p-emac-v14-0-ec212b747a7d@oss.qualcomm.com> In-Reply-To: <20260908-qcom-sa8255p-emac-v14-0-ec212b747a7d@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Radu Rendec Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1751; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=jjMtp5SqAas4zIIzp6l5IEc/YbwGv5zChtMnC787rmU=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqoCJmPqi3DXcwZqfQ9RcuBKffaeQOMu23z59wG LbX6KLmIzSJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaqAiZgAKCRAFnS7L/zaE w1eOD/920zuLA7hi4Qy2IBRHuh66/6fGvU4CJZXZ8ZD4vI93p4NDs9EDRQ2eK5JZND/M39YL/eh 52J1KMNflNj2rwdO9wtNiwHM8YO6NzJZZlpUa7Ak0jx20M07KgXAKYNawKRHhswKAmt3gb8Sv0U 7R2lyCi5bWTavJEKJLgNvmjrfEnQWTW86v2Qe12MS6XLkR0c7km8NpFwNMTRxMnxHTDgYNFwP2/ lznNBSoSePeij/ML6f9oklu10rRg9FOzx+41xkEE2odLqbSjDCVGlgIOBX0oJQo+RXjakYifphY sGn+nbC+Y0cJXEFw+YPWaN4TO8N7EZjKgatj0E/AX5y5S0CGtri1J31C8NxIAlYMjV1buvk+m49 qfUC1djmfabNtSorBXWHn6eIotETAu7110pwW1SXS8sJEZqYSaM+UHB6N+CEshJFHnSrEVXaT/2 x3/y1w97VKXb0+Uev2Wg+1Y7ZmG8lYpdBpbSo4D/ZwbxN92vpw2leV1EfoEopMdH5pVNVUEWzby 50E9cOb6Xut9TWCp47vnDqWbHrGxpYV+SIhgiE8LQjji3khnrOkZ8Ew8fUysP7pgCSfo9+8xS5d APT5j7JXhq/tpsKe9Ow2mrNTveRI7gaS19Aug2BWjajK9kK4xY3fNdUsZfMg4w1pP1+U86iGb2u Hwcchsr19M05kMA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=CMEamxrD c=1 sm=1 tr=0 ts=6aa02277 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=mooR1oPkU_hlknJbmfEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2MCBTYWx0ZWRfXy5KmND57MI9g maLaFhcwd8cDuAQxE5mEg0OR9gPkdmtGj19BaEGOT6WR0Z0pMGgXd1NuU5OUdIPLq65lmEnCOW6 qu6F/8Df3+6JY2u+WNUi41X9H+Wu+8s= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2MCBTYWx0ZWRfX2TXYWLhgdhMx JKdfge7B+uIjE+N/Oq0G2bmOWWXGFoKdLqzSfnxsm+/usa4lVpTy0em1CIfPZIt3gMuLgd+zfEd /sFvCvN1/uUSUNt5PYSUYGEZR0so3RlHCXvHg2feFNeRjGrK/Z/zQDwelUOVWSlu+NLLzU/Ayve E83zXVA+UunwgjXfPNQ8A5kYuDf11NmehLGIkFTcsvpbKqnaDxOxVMp9Ss0Oo9aIERHmrRHoqrq PWPJLSYexyWPJ34JNhMPqbuUe3X+ELmyryr688vyv5rKGXPqb63KUaf1wsoGQjW/s/7rA/im4QM iBfxCBtzF/FDiPjm3TySpB+I5FTWvMS7QbxLKStDa19IjVuwugW3kGnyz1duqbHftBw403Qlv8g pqhUQq6XTnsQaGI+DcU+Uful1siadC5okCM6inyi8ELqDNWSOEwC8+PtdRyZRvbQMyS6d15oADi BGRjECXgfDtG6jRYNRA== X-Proofpoint-ORIG-GUID: 1w2yEn9brsnjEj0w41CyO5A2fWZr4Y-d X-Proofpoint-GUID: 1w2yEn9brsnjEj0w41CyO5A2fWZr4Y-d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080160 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260908_075801_308618_52FD3418 X-CRM114-Status: GOOD ( 17.70 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org aqr_gen1_read_status() decodes the MDIO_PHYXS_VEND_IF_STATUS register to determine which SerDes interface the PHY is currently using on its system side and stores the result in phydev->interface. phylink relies on this value to configure the MAC. The autoneg == AUTONEG_DISABLE check is not correct: MDIO_PHYXS_VEND_IF_STATUS is set by the PHY firmware based on the negotiated link speed, not based on whether autoneg was used to reach it. When the link comes up at 1G in forced mode, the register correctly reads SGMII, but the early return prevents phydev->interface from being updated. It stays at whatever value it held before (typically 2500BASE-X from the initial autoneg run), so phylink configures the MAC for the wrong interface and the link cannot come up. Remove the autoneg guard so that the system interface type is always decoded when the link is up. Cc: stable@vger.kernel.org Fixes: 110a2432c520 ("net: phy: aquantia: add downshift support") Signed-off-by: Bartosz Golaszewski --- drivers/net/phy/aquantia/aquantia_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c index e95d391a6dc233879ae1fb2a97758b3df9600ce5..b720e4e9028cc20823297e8bbd239121aeafa09f 100644 --- a/drivers/net/phy/aquantia/aquantia_main.c +++ b/drivers/net/phy/aquantia/aquantia_main.c @@ -544,7 +544,7 @@ static int aqr_gen1_read_status(struct phy_device *phydev) if (ret) return ret; - if (!phydev->link || phydev->autoneg == AUTONEG_DISABLE) + if (!phydev->link) return 0; /* The status register is not immediately correct on line side link up. -- 2.47.3 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic