From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A5D1C88E7F for ; Wed, 16 Sep 2026 17:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Q1o2UPgoe/7yqNZWjsnBfc+61tECLdmUkF0VY6IxKxU=; b=L8NeONXwsBJeP0 fLaoo5BxpO+G1rZkdygxOb4dr11tfR0LLYGUkkk1lZ3I/KO5zBk96OPlCwY5mn8qAHzRmjrm8CpYw CnOgkEcJ/OhoBT+ZfzJf7FSak7GPyOJnlLDbbKS8xADFH30517Lup6kuJjI4CvuJCSB+KbaBfmLrj C2RFVUbrqkwWKC+gNjjTyM22SXISE5ZcqS59ZNKJKdVHU2+5NTH574u8AkPvks4QuYI74p5FR0d8G vNG/NStmxOyNEsXerI7H5vdj79SS6TO0tFYjvtoJaKBx6H4jCXTxclp8pven7nBa/aTvXm8GfTo23 kCCAHe5Rv8Y4zMHdzQXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6tiB-00000009tZp-17L1; Wed, 16 Sep 2026 17:46:23 +0000 Received: from smtp25.cstnet.cn ([159.226.251.25] helo=cstnet.cn) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6ti8-00000009tZB-1jg7; Wed, 16 Sep 2026 17:46:22 +0000 Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowAD3J0Lj1apqitxuCA--.23616S2; Thu, 17 Sep 2026 01:46:11 +0800 (CST) From: Wentao Liang To: airlied@gmail.com Cc: dri-devel@lists.freedesktop.org, jbrunet@baylibre.com, khilman@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, luca.ceresoli@bootlin.com, maarten.lankhorst@linux.intel.com, martin.blumenstingl@googlemail.com, mripard@kernel.org, neil.armstrong@linaro.org, simona@ffwll.ch, tzimmermann@suse.de, Wentao Liang Subject: [PATCH] drm/meson: Fix next_bridge reference leak in meson_encoder_dsi_probe() Date: Wed, 16 Sep 2026 17:45:43 +0000 Message-Id: <20260916174543.2089062-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CM-TRANSID: zQCowAD3J0Lj1apqitxuCA--.23616S2 X-Coremail-Antispam: 1UD129KBjvJXoW7CF4UZw4rGry3ZFyxZFW8Zwb_yoW8XrWkpr ZxWay3tF18J348Aw1DAF45CF4ay3WqqFWfGayktws3uw13W3WUtr93AF45ur1UZayYvFs3 trn5Wry8uFW5CaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9v14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxV WxJr0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2Wl Yx0E2Ix0cI8IcVAFwI0_JF0_Jw1lYx0Ex4A2jsIE14v26F4j6r4UJwAm72CE4IkC6x0Yz7 v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF 7I0E8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026x CaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_ JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r 1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UMIIF0xvE42xK8VAvwI8IcIk0 rVWUJVWUCwCI42IY6I8E87Iv67AKxVWxJVW8Jr1lIxAIcVC2z280aVCY1x0267AKxVWxJr 0_GcJvcSsGvfC2KfnxnUUI43ZEXa7VU1go2UUUUUU== X-Originating-IP: [36.110.52.2] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBgcMA2qqok9zVQABsE X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260916_104620_826594_F7AE4D37 X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The reference on the next bridge returned by of_drm_find_and_get_bridge() is never released when drm_simple_encoder_init() or drm_bridge_attach() fails. Drop it on both error paths before returning. Fixes: bfb8f5d0a9e7 ("drm/meson: encoder_dsi: get/put the next bridge") Signed-off-by: Wentao Liang --- drivers/gpu/drm/meson/meson_encoder_dsi.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_encoder_dsi.c b/drivers/gpu/drm/meson/meson_encoder_dsi.c index eba246791c68..5f2eeeaf93b8 100644 --- a/drivers/gpu/drm/meson/meson_encoder_dsi.c +++ b/drivers/gpu/drm/meson/meson_encoder_dsi.c @@ -135,17 +135,21 @@ int meson_encoder_dsi_probe(struct meson_drm *priv) /* Encoder */ ret = drm_simple_encoder_init(priv->drm, &meson_encoder_dsi->encoder, DRM_MODE_ENCODER_DSI); - if (ret) + if (ret) { + drm_bridge_put(meson_encoder_dsi->bridge.next_bridge); return dev_err_probe(priv->dev, ret, "Failed to init DSI encoder\n"); + } meson_encoder_dsi->encoder.possible_crtcs = BIT(0); /* Attach DSI Encoder Bridge to Encoder */ ret = drm_bridge_attach(&meson_encoder_dsi->encoder, &meson_encoder_dsi->bridge, NULL, 0); - if (ret) + if (ret) { + drm_bridge_put(meson_encoder_dsi->bridge.next_bridge); return dev_err_probe(priv->dev, ret, "Failed to attach bridge\n"); + } /* * We should have now in place: -- 2.34.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic