Re: [PATCH v6 2/4] nvmem: core: deprecate reg_write callback with reg_write_const

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] nvmem: dev_warn uses uninitialized device name in nvmem_register()
--

commit 77653927bdf19b36c155e416a676051598da0213
Author: Link Mauve <linkmauve@linkmauve.fr>

nvmem: core: deprecate reg_write callback with reg_write_const

This commit deprecates the reg_write callback in favor of reg_write_const,
which takes a const pointer for the value buffer. It also adds a deprecation
warning in nvmem_register() for drivers still using the old callback.

> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 0556d140170a4..a484d424119f9 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c

[ ... ]

> @@ -937,6 +940,11 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
>  
>  	ops->reg_read = config->reg_read;
>  	ops->reg_write = config->reg_write;
> +	ops->reg_write_const = config->reg_write_const;
> +
> +	if (ops->reg_write)
> +		dev_warn(&nvmem->dev, "Usage of reg_write in nvmem is deprecated, please "
> +		                      "migrate to reg_write_const.\n");

[Severity: Low]
Will this dev_warn() print an uninitialized device name, since dev_set_name()
hasn't been called on &nvmem->dev yet?

Looking further down in nvmem_register(), the device name is assigned later
in the switch block:

	switch (config->id) {
	case NVMEM_DEVID_NONE:
		rval = dev_set_name(&nvmem->dev, "%s", config->name);
		break;
	...

Could this result in the log message printing an uninitialized name like
(null) or (unnamed), making it difficult to identify which driver triggered
the deprecation warning?

Would it make sense to use config->dev (the parent device) for the warning,
or move this check below the dev_set_name() block?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920111000.2404131-1-linkmauve@linkmauve.fr?part=2

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic