Re: [PATCH v5 5/8] drm/bridge: pass down IRQ_HPD to the drivers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/omapdrm: hdmi5_bridge_hpd_notify signature mismatch causes build failure
--

commit c12a9be57208a1450c89b7b186ca8f9ff6848995
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

drm/bridge: pass down IRQ_HPD to the drivers

The DisplayPort standard defines a special kind of HPD events called
IRQ_HPD. These events are used to notify DP Source about the events on
the Sink side. Pass down the extra status to the bridge drivers via the
hpd_notify() callback, letting DP bridges to act accordingly.

> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index ed9f77a2597a1..2b3cad4bedde9 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -509,7 +509,8 @@ struct drm_bridge_funcs {
>  	 */
>  	void (*hpd_notify)(struct drm_bridge *bridge,
>  			   struct drm_connector *connector,
> -			   enum drm_connector_status status);
> +			   enum drm_connector_status status,
> +			   enum drm_connector_dp_event event);
>  
>  	/**
>  	 * @hpd_enable:

[Severity: Low]
Could this cause a build regression by missing an update in
drivers/gpu/drm/omapdrm/dss/hdmi5.c?

While hdmi4_bridge_hpd_notify() was updated in this patch,
hdmi5_bridge_hpd_notify() in hdmi5.c still retains the old 3-argument
signature. Assigning this incorrectly-typed function pointer to
hdmi5_bridge_funcs.hpd_notify will result in an incompatible pointer type
compiler error when building with CONFIG_DRM_OMAP enabled:

drivers/gpu/drm/omapdrm/dss/hdmi5.c:
static void hdmi5_bridge_hpd_notify(struct drm_bridge *bridge,
                                    struct drm_connector *connector,
                                    enum drm_connector_status status)
{
...
static const struct drm_bridge_funcs hdmi5_bridge_funcs = {
...
        .hpd_notify = hdmi5_bridge_hpd_notify,
...
};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-hpd-irq-events-v5-0-ff1de0090c72@oss.qualcomm.com?part=5

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic