From: sashiko-bot@kernel.org
To: "Xianwei Zhao" <xianwei.zhao@amlogic.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: net: meson-dwmac: add T7 support
Date: Mon, 21 Sep 2026 08:13:53 +0000 [thread overview]
Message-ID: <20260921081354.37C561F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260920-t7-node-new-v1-2-e6e0840c1b0b@amlogic.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: net: meson-dwmac: missing t7-dwmac in select block
- [Medium] dt-bindings: net: meson-dwmac: missing t7-dwmac in generational constraints
--
commit cf2bd16c5188a0d6d2a0e2fdf91dd50ebfa695b8
Author: Xianwei Zhao <xianwei.zhao@amlogic.com>
dt-bindings: net: meson-dwmac: add T7 support
Adds the T7 compatible string to the Meson DWMAC binding and adds a
conditional schema check to enforce the correct compatible combination.
> diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> index 5c91716d1f21e..f75a275e2d759 100644
> --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> @@ -28,6 +28,18 @@ select:
[Severity: Medium]
Should amlogic,t7-dwmac be added to the select block?
If a node is added with compatible = "amlogic,t7-dwmac";, it appears the
dt-validator will skip this schema entirely if the string is not explicitly
listed in the select properties. This would bypass the new allOf.if rules
added below.
>
> allOf:
> - $ref: snps,dwmac.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: amlogic,t7-dwmac
> + then:
> + properties:
> + compatible:
> + items:
> + - const: amlogic,t7-dwmac
> + - const: amlogic,meson-axg-dwmac
> + - const: snps,dwmac-4.00
[ ... ]
> @@ -139,8 +151,10 @@ properties:
> - amlogic,meson-gxbb-dwmac
> - amlogic,meson-axg-dwmac
> - amlogic,meson-g12a-dwmac
> + - amlogic,t7-dwmac
[Severity: Medium]
Does this new compatible string also need to be added to the existing
allOf.if blocks that check for amlogic,meson-axg-dwmac?
Since T7 uses AXG as a fallback, it shares its hardware constraints like
clocks and rx-internal-delay-ps. By omitting amlogic,t7-dwmac from those
existing conditional blocks, the schema implicitly relies on the fallback
string to trigger validation. A missing fallback string in a device tree
would bypass these generational constraints.
> contains:
> enum:
> + - snps,dwmac-4.00
> - snps,dwmac-3.70a
> - snps,dwmac
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-t7-node-new-v1-0-e6e0840c1b0b@amlogic.com?part=2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-09-21 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 8:13 [PATCH 0/3] t7: add some nodes for Amlogc t7 Xianwei Zhao via B4 Relay
2026-09-20 8:13 ` [PATCH 1/3] spi: dt-bindings: amlogic,meson-gx-spicc: add T7 compatible Xianwei Zhao via B4 Relay
2026-09-20 8:13 ` [PATCH 2/3] dt-bindings: net: meson-dwmac: add T7 support Xianwei Zhao via B4 Relay
2026-09-21 8:13 ` sashiko-bot [this message]
2026-09-20 8:13 ` [PATCH 3/3] arm64: dts: amlogic: add T7 peripheral nodes Xianwei Zhao via B4 Relay
2026-09-21 8:13 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921081354.37C561F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®