Re: [PATCH 1/3] dt-bindings: i2c: add Amlogic A9 I2C controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt-bindings: i2c: amlogic: misspelled maintainer email addresses
- [Low] dt-bindings: i2c: amlogic: invalid GIC interrupt type in example
--

commit 1ce7d70f157b5cc3e10c7e75c64287c2dbe2c1bb
Author: Xianwei Zhao <xianwei.zhao@amlogic.com>

dt-bindings: i2c: add Amlogic A9 I2C controller
    
Add a Device Tree binding for the I2C controller found on the
Amlogic A9 SoC.

> diff --git a/Documentation/devicetree/bindings/i2c/amlogic,a9-i2c.yaml b/Documentation/devicetree/bindings/i2c/amlogic,a9-i2c.yaml
> new file mode 100644
> index 0000000000000..681241a526806
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/amlogic,a9-i2c.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/amlogic,a9-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic A9 I2C Controller
> +
> +maintainers:
> +  - Xianwei Zhao <xianwei.zhaol@amlogic.com>
> +  - Junyi Zhao <junyi.zhaol@amlogic.com>

[Severity: Low]
This isn't a functional bug, but are these email addresses misspelled?

The trailing 'l' in 'zhaol' causes emails to bounce when contributors
use get_maintainer.pl to CC the maintainers on patches modifying this
binding.

[ ... ]

> +examples:
> +  - |
> +    i2c@3a4400 {
> +        compatible = "amlogic,a9-i2c";
> +        reg = <0x3a4400 0x3c>;
> +        interrupts = <1 164 1>;

[Severity: Low]
Is this GIC interrupt specifier in the examples block correct?

The first cell value of 1 designates a GIC_PPI (Per-Processor Interrupt),
which is limited to the range 0-15. A value of 164 is highly invalid for a
PPI.

Since I2C controllers are typically shared peripherals, should this be 0
(GIC_SPI) instead?

Developers copy-pasting the example will create invalid device trees that
fail at runtime or during dtc validation.

> +        clocks = <&clkc_periphs 11>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        eeprom@52 {
> +            compatible = "atmel,24c32";
> +            reg = <0x52>;
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-a9-i2c-v1-0-b8ad9b46f4a8@amlogic.com?part=1

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic