From: sashiko-bot@kernel.org
To: "Xianwei Zhao" <xianwei.zhao@amlogic.com>
Cc: robh@kernel.org, neil.armstrong@linaro.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: amlogic: add T7 peripheral nodes
Date: Fri, 25 Sep 2026 05:51:32 +0000 [thread overview]
Message-ID: <20260925055133.0FD501F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260924-t7-node-new-v2-3-319d3c19b4b2@amlogic.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: useless regulator properties without gpio
--
commit 61a44d137e93474e04a70d0ea481b570b8e6131c
Author: Xianwei Zhao <xianwei.zhao@amlogic.com>
arm64: dts: amlogic: add T7 peripheral nodes
This patch adds device tree descriptions for the peripherals on the Amlogic
T7 SoC and the T7 A311D2 AN400 board. It introduces support for the T7
Ethernet controller, SPI controllers, I2C controllers, UARTs, pinctrl groups,
regulators, and reserved memory.
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
> index ca7536f772ff1..50df961fba75b 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
> @@ -24,12 +24,159 @@ memory@0 {
[ ... ]
> + vddqlp_0v6: regulator-vddqlp-0v6 {
> + vin-supply = <&dc_in>;
> + compatible = "regulator-fixed";
> + regulator-name = "VDDQLP_0V6";
> + regulator-min-microvolt = <600000>;
> + regulator-max-microvolt = <600000>;
> + startup-delay-us = <70000>;
> + enable-active-high;
> + regulator-boot-on;
> + regulator-always-on;
> + };
[Severity: Low]
Is it intentional to include enable-active-high and startup-delay-us
properties for vddqlp_0v6 without defining a control gpio?
Without a gpio defined, the regulator core has no mechanism to toggle the
regulator, meaning enable-active-high has no effect. This appears to be a
device tree schema violation, although it does not cause a failure since the
regulator is marked regulator-always-on.
> +
> + vdd_ddr: regulator-vdd-ddr {
> + vin-supply = <&dc_in>;
> + compatible = "regulator-fixed";
> + regulator-name = "VDD_DDR";
> + regulator-min-microvolt = <800000>;
> + regulator-max-microvolt = <800000>;
> + startup-delay-us = <70000>;
> + enable-active-high;
> + regulator-boot-on;
> + regulator-always-on;
> + };
[Severity: Low]
Does vdd_ddr also need a control gpio?
Like vddqlp_0v6 above, it specifies enable-active-high and startup-delay-us
but lacks a gpio property.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-t7-node-new-v2-0-319d3c19b4b2@amlogic.com?part=3
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2026-09-25 5:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 5:51 [PATCH v2 0/3] t7: add some nodes for Amlogc t7 Xianwei Zhao via B4 Relay
2026-09-24 5:51 ` [PATCH v2 1/3] spi: dt-bindings: amlogic,meson-gx-spicc: add T7 compatible Xianwei Zhao via B4 Relay
2026-09-24 5:51 ` [PATCH v2 2/3] dt-bindings: net: meson-dwmac: add T7 support Xianwei Zhao via B4 Relay
2026-09-24 17:21 ` Conor Dooley
2026-09-24 5:51 ` [PATCH v2 3/3] arm64: dts: amlogic: add T7 peripheral nodes Xianwei Zhao via B4 Relay
2026-09-24 11:33 ` Ronald Claveau
2026-09-25 5:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925055133.0FD501F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®