From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C955CA5FC4 for ; Wed, 30 Sep 2026 23:33:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gaM4wzo+O+Jd28fd1arWTKoIQ1hVVnhATlXUrX+QvaU=; b=aX8XF7trm65HkG AZX83ctAIEb6Lnu58a3AeHQV/eUynMLZJFNC4W+1KsaM/4tliJaQkH5tShHiamvBiEPKwdJRhcu4A pULahkTBfT8MEvUv+XyhvOla52uMc9AgwCcNRhdhSt1bD7GVyGCccwSXAil412xbFvRmn1rR0Igea WTt+GSsP7lTCbkGFGP3D9RZzk48ErRxhtCvLx5sZu/MXEKOC2mkUO+dEdg2VSwb+9GRMo5ajXuDd7 MDyCJURVYMSg3TR7Gmhu5TNTbv9af02lI6q4dUyFaSRwrvJMZuw8Sy7GrSrhmZxZwdAtRZaEHpiMh TdEAUShibgyW2ls26/Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xC3nu-00000007SOd-3TDX; Wed, 30 Sep 2026 23:33:38 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xC3nt-00000007SOD-1lBd; Wed, 30 Sep 2026 23:33:37 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8A6B5601F1; Wed, 30 Sep 2026 23:33:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C986A1F000FF; Wed, 30 Sep 2026 23:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790811216; bh=FNK/3xFH9eCNhn2rwMTGwfSucgaTbz1Hnohkj9sa4DM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=iM5V8kprPcqUUtABn8RdjhABq8ehgpbe8HkhOI6mg+s6DDKlOTP6XWs6thPr/T+I+ /09P8WKMmvjdyd9hwWuizmemuZFg7YuxXw9f9Brv09nH6OLcgcU76tG5N4hEZyNNlI Zo+uMo1F5XPzSsJZ32D6FvkicUSSMBjkatis4KkJFCQN0t3VLq7UGK8LxQCpl1av3z ZJNQithgImxzAK/2VUJnPm6zHvoU+EMoQ5ljVKWox7TTZzzayUMw5jor3CpTrJj0xJ na5+drmiYFcHLS05GrUtvwtT7DGiN6sqyJpsRJ6y0oH73+IUGcfukvWLxscPl34msJ IgWcMfc7EYn9Q== Date: Wed, 30 Sep 2026 16:33:34 -0700 From: Jakub Kicinski To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski , stable@vger.kernel.org Subject: Re: [PATCH net-next v15 1/9] net: phy: aquantia: fix system interface type not updated in forced mode Message-ID: <20260930163334.60b4a88c@kernel.org> In-Reply-To: <20260923-qcom-sa8255p-emac-v15-1-e82f33720737@oss.qualcomm.com> References: <20260923-qcom-sa8255p-emac-v15-0-e82f33720737@oss.qualcomm.com> <20260923-qcom-sa8255p-emac-v15-1-e82f33720737@oss.qualcomm.com> MIME-Version: 1.0 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, 23 Sep 2026 17:14:35 +0200 Bartosz Golaszewski wrote: > aqr_gen1_read_status() decodes the MDIO_PHYXS_VEND_IF_STATUS register > to determine which SerDes interface the PHY is currently using on its > system side and stores the result in phydev->interface. phylink relies > on this value to configure the MAC. > > The autoneg == AUTONEG_DISABLE check is not correct: > MDIO_PHYXS_VEND_IF_STATUS is set by the PHY firmware based on the > negotiated link speed, not based on whether autoneg was used to reach > it. When the link comes up at 1G in forced mode, the register correctly > reads SGMII, but the early return prevents phydev->interface from being > updated. It stays at whatever value it held before (typically 2500BASE-X > from the initial autoneg run), so phylink configures the MAC for the > wrong interface and the link cannot come up. > > Remove the autoneg guard so that the system interface type is always > decoded when the link is up. > > Cc: stable@vger.kernel.org > Fixes: 110a2432c520 ("net: phy: aquantia: add downshift support") > Signed-off-by: Bartosz Golaszewski Sounds like a real regression, is it? Should we ship it to Linus tomorrow so that it makes 7.3? stable + next does not compute for me _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic