From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF0B9CA5FED for ; Fri, 9 Oct 2026 03:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A+W7Vk6S2PP4SPkjm4NbLWCcgLbnOUOewThMdK/gONU=; b=dxW9PoqjjnysBT pH5gJ4FMhqZgb47PldDWTkGsF6XgrnH+xdHGUfX1045PVbhWwLWt3ZkeUqK8GMifIO0yzp9Z7qc11 Ay2D4tr7MBxbQItQEo81tl4qTqaOmAz6Yoj1Ekem7R/nCGiGCFyyEEhy0kicRogFesTIg4Jkv1pla gKQK3i7yyN92TtLVEnepr/aaehm+EOSaipCOwj+2rfHoQlBET/ms8Lvjhd6+8W+J55KYuzW0aXIHe vvQZDpQLZB8AV4MDKw19TJaQY4kaM2BbymF/Ey3IG4YH9zif9NRjym0tzi9L0n9kXlPP0+2r813hR oLe6hoLTWTlQ23b5Kz1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xF18t-00000005L8x-30mL; Fri, 09 Oct 2026 03:19:31 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xF18s-00000005L7W-2xEm for linux-amlogic@bombadil.infradead.org; Fri, 09 Oct 2026 03:19:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=nVkhbIha367ZUPcSP/0qUyOfo0Zbwi092GPc0Z4TRTg=; b=nrPYU3/C4OMW+akwxWLK5KeuB0 I4WNWvpidEj2o4jYNLDndsl65nRBpDm9oGmBiqRJzF9GphbFsW+fnjpeWCu1Z4EgcCQ8kAQ4cicAk xttlbm9Sczq3NIe/XhPH7OVdsf6fFa5kqwFBVZVgy6c7IFjH1s/26jIFirWmR8wLJo28Tp687SbA3 l9ogrWUBNp25WHiseXKvjNOb6CwXEPD8bWCdfTpo2YlLk3XWmPSnm18ABF5vmBefB8f1anLDsQkwB 7R5c+TUqPPIvIhlii7HNGT++PjiEqYwz7YGxcAyN7TQP48ix3K01vAWuJriFRelvqidKKCce78oiQ V+P/UtNA==; Received: from smtpbgjp3.qq.com ([54.92.39.34]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1xF18o-0000000AqsL-2iP9 for linux-amlogic@lists.infradead.org; Fri, 09 Oct 2026 03:19:29 +0000 X-QQ-mid: zesmtpip2t1791515882t0fd3316f X-QQ-Originating-IP: XXNfWD6sBCjyqaCfOai782WfGgGzZkkZ7WXlzuAHYJ8= Received: from [192.168.30.32] ( [localhost]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 09 Oct 2026 11:17:59 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 12552488957466588621 EX-QQ-RecipientCnt: 29 From: Xilin Wu Date: Fri, 09 Oct 2026 11:16:07 +0800 Subject: [PATCH v2 15/20] drm/msm/dp: Flush VSC updates when leaving YUV420 MIME-Version: 1.0 Message-Id: <20261009-msm-dp-hdr10-v2-15-1835d4966da3@radxa.com> References: <20261009-msm-dp-hdr10-v2-0-1835d4966da3@radxa.com> In-Reply-To: <20261009-msm-dp-hdr10-v2-0-1835d4966da3@radxa.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, dragon@radxa.com, Xilin Wu , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3407; i=sophon@radxa.com; h=from:subject:message-id; bh=Z9h8OALLyQT16FzQH0lJ854H/RrF3oqTzDkmSpjnkKg=; b=owGbwMvMwCVmdFg0fe08Iz/G02pJDFknYlb1VPj7TlmssD18z5dZVp5Ppsnl555o3H0o43fcB ObaR1emd5SyMIhxMciKKbIoxDPMZa/MvfZUrFQPZg4rE8gQBi5OAZhI73OGP/zX8mwuvhZWVrnI 7bFGYuPsY+HM55Xnmi62Pr/Ir+V41j9Ghon8wfmbPuw8te/9xiPC/eobRRgEtL9c6PXaL+ncdvT zUVYA X-Developer-Key: i=sophon@radxa.com; a=openpgp; fpr=205F009D07796DD6E516752E32C31567AD9E324E X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpip:radxa.com:qybglogicsvrsz:qybglogicsvrsz3b-0 X-QQ-XMAILINFO: OYMEOeTae7mlISRHksvqf9mKHFDAasBBoBfvK+/vygPUzPQEbzmeATce Wb9d8cGlMHPJFCfUwfdOIVRta0UQdGHOqkf3BWxaGu+iSSNK+j0JCcOflNlH84vz1cwrULN 5Jv44Cmts036kLe2fNQwXvvWQYaYXuo+knQUtrZvLXZJvTkk9Q8bA4ZQGnAVFCfGc0pw0Fu p+HG0VkmtiqagE81axSVWS9cwtobY7lkGs72oOkkn4H4kval9CgH2IeONYO4YsHH1l30qpi ClKncC7Dyogh5ybsql7jMZxUzeIkIhyIvOCVD27qcMUEg6InuMEIZU88/Kh/iDV3ndex1VJ OPQP1xlBcMpKtYPpRcPlIuCM7W/NLCDQ5AbpH+41E3ptjFYgtw3byQCXrnW1z36JkX9Cuak eZTBR7OMjmA+DD2yvq9wSA0ahUYn9QFU/1iUJfuEXJ4BwFKeyieCNzEQouhQQ59zT2afZK5 hHqd7+Fs+Nu4ut11NtDfRlciLcIO4irz253egntREcyOLoJ3VspysvE5PlNsbeZCs8GWzu7 Egz9lGmeWUHXKstHSfjnTDKgZvUCrf9HVJIk5haY0eOEfYAz47Z04eVhbKKqWeeHCnEn74x p7O5KRE3zaJH6cf4C3fMWHYTcwdNBrHOZD2l+eOCxEx8lMVpFsYyU65A5DfMir9BRuEP4S/ tV7NLq+XVcRzEjLIGd2fvfhWY2eJTwDDbiguRSJKV4puRwSPaxqSgDKN+XTWgHGN6CdayMf MYnRsaNl/sLRZmRNNwIMb6sf7cA8vPOU6TaNFqwqpq4xhKvmmcdYpb2FBA0d+yomRby7NjR bVLb0GUBjwqkOzkcTBUV44xizDubfb8DziycQeTFjqfXUGEVzHhlgSTdz0ZeuYP8Sl572rz Vkh7SUuevecNVQYvLlEhUd4Eq94KNX/evgnc6wGpreqY3c6kKvmBFCw4sYrEFm+3485PBcJ d7NhgpRG2n5VfnCMWDJsmxH+Kt79Uiu0cZVvOtfSoHZMF8vX1lGHkZiP9qxE3T0eAK/eoX8 LTExyCTnF9ea8PfXaTWKwYWCmsmb9gT+G6DjGr3MpG4d84uVJdGYTxUWMma9XOkZkyGBydt Q== X-QQ-XMRINFO: OD9hHCdaPRBwH5bRRRw8tsiH4UAatJqXfg== X-QQ-RECHKSPAM: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261009_041927_622130_8E504234 X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Peripheral flush is currently requested only for the new YUV420 mode. Returning to RGB also changes SDP state and must remove the old VSC packet rather than leaving its enable bits set. Track whether either stream needs VSC and request peripheral flush for both enabling and removing it. Explicitly disable VSC for RGB, and write the packet payload before enabling transmission. Retain the existing hardware-specific SDP update mechanism. Assisted-by: LLM Signed-off-by: Xilin Wu --- drivers/gpu/drm/msm/dp/dp_display.c | 7 ++++++- drivers/gpu/drm/msm/dp/dp_panel.c | 6 ++++-- drivers/gpu/drm/msm/dp/dp_panel.h | 1 + 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 1f9595ff5fd9..486348113b8a 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -691,6 +691,8 @@ static int msm_dp_display_set_mode(struct msm_dp *msm_dp_display, else bpp = state->bpp; + msm_dp_panel->sdp_needs_flush = msm_dp_panel->msm_dp_mode.out_fmt_is_yuv_420 || + drm_mode_is_420_only(&msm_dp_panel->connector->display_info, adjusted_mode); msm_dp_panel_init_panel_info(msm_dp_panel, adjusted_mode, bpp ? bpp : 24); /* populate wide_bus_support to different layers */ @@ -1557,7 +1559,10 @@ void __exit msm_dp_unregister(void) bool msm_dp_needs_periph_flush(const struct msm_dp *msm_dp_display, const struct drm_display_mode *mode) { - return drm_mode_is_420_only(&msm_dp_display->connector->display_info, mode); + struct msm_dp_display_private *dp = container_of(msm_dp_display, + struct msm_dp_display_private, msm_dp_display); + + return dp->panel->sdp_needs_flush; } bool msm_dp_wide_bus_available(const struct msm_dp *msm_dp_display) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index af05441bc32a..026074cafc88 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_panel.c @@ -526,14 +526,14 @@ void msm_dp_panel_enable_vsc_sdp(struct msm_dp_panel *msm_dp_panel, struct dp_sd cfg2 = msm_dp_read_link(panel, MMSS_DP_SDP_CFG2); misc = msm_dp_read_link(panel, REG_DP_MISC1_MISC0); + msm_dp_panel_send_sdp(panel, vsc_sdp, MMSS_DP_GENERIC0_0); + cfg |= GEN0_SDP_EN; msm_dp_write_link(panel, MMSS_DP_SDP_CFG, cfg); cfg2 |= GENERIC0_SDPSIZE_VALID; msm_dp_write_link(panel, MMSS_DP_SDP_CFG2, cfg2); - msm_dp_panel_send_sdp(panel, vsc_sdp, MMSS_DP_GENERIC0_0); - /* indicates presence of VSC (BIT(6) of MISC1) */ misc |= DP_MISC1_VSC_SDP; @@ -686,6 +686,8 @@ int msm_dp_panel_timing_cfg(struct msm_dp_panel *msm_dp_panel, bool wide_bus_en) if (msm_dp_panel->msm_dp_mode.out_fmt_is_yuv_420) msm_dp_panel_setup_vsc_sdp_yuv_420(msm_dp_panel); + else + msm_dp_panel_disable_vsc_sdp(msm_dp_panel); panel->panel_on = true; diff --git a/drivers/gpu/drm/msm/dp/dp_panel.h b/drivers/gpu/drm/msm/dp/dp_panel.h index a5cb8a4a9498..31752895f124 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.h +++ b/drivers/gpu/drm/msm/dp/dp_panel.h @@ -42,6 +42,7 @@ struct msm_dp_panel { bool link_caps_valid; /* All capability reads completed; eDP can reuse the full cache. */ bool caps_cached; + bool sdp_needs_flush; u32 hw_revision; u32 max_bw_code; -- 2.56.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic