From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5FADCA9ED0 for ; Mon, 12 Oct 2026 19:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1lqhGnMNv4hTTdQ2i2H7Yog2oEaYtN4fpQP8w9jzHsw=; b=fcWhku9UB4zq2JgQaQj1uk3mzO iuU9oIgRkid9xPfrMxcnZLMlTD3elLffm02RdiC7eKeWuJyPcPmS5AqpqjZa+3ofqLEkrAmn7R4P6 f2lqHglHV/e487Cu4CsSgHZ5G0q07rYykdpHYiRA0Q2xlDh3RXVTOKteSyA5wRFaapR9zMC/7xRrX ipSBGy+/pZ+1P6E+C84zfVqWdl858LwRzHYCuOPWMSUEmKD+loJSTNVeOXySTjfHcoUjbfaprYkcg 3ZCq8gsmAlYWrajusRcoHA26ijoqc9Mq+HQt2+ZRYB+0kemtkKjllGDezsLlcE9dDJqq7Q461xmgl WdfdD+ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGLXn-0000000BN9z-1AkJ; Mon, 12 Oct 2026 19:18:43 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGLXm-0000000BN9n-2PVA; Mon, 12 Oct 2026 19:18:42 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A41736025F; Mon, 12 Oct 2026 19:18:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B3B31F008A1; Mon, 12 Oct 2026 19:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791832721; bh=Lh0EeRUmPO/n2sz7aHLajpNlc62AqgBNQDWR/Mouc3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=i2ldyTvkySETYb0S2alZFc5d8JjDLNPi+DhBhyG6YldX02eACwPkuXssIqIMYugyN ZZvT5P6OQ1N9Xadzg3OZhntvoRQ0kf+6PUxFkMDiltOdaaMNN95J5inV2wSlUtnxSH 4HU76tzVlXnPfFBTErIYAxTMK757kcnh0d7SErAJNvbEPoGIQPRTNeQ51HcNAC2mg4 RUd81Q1pZatSeQk7opR7zRlP3xKcvmXdK45GcZmcr0pMEEAMa86QL5jUVn5Hew9Id9 kthkILYOTIOMW089oC9iPcmkTGHR3GaM8IMALDRnowS8BYJzwCU6Fw2GphqcvG22EO kRF1rYYfMR9/A== Date: Mon, 12 Oct 2026 20:18:35 +0100 From: Conor Dooley To: Lucas Tanure Cc: xianwei.zhao@amlogic.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 8/8] dt-bindings: net: ethernet-controller: tabulate who adds the RGMII delays Message-ID: <20261012-suds-karaoke-efc4acf056af@spud> References: <20261010105900.247342-1-tanure@linux.com> <20261010105900.247342-9-tanure@linux.com> MIME-Version: 1.0 In-Reply-To: <20261010105900.247342-9-tanure@linux.com> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8652555890279828312==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============8652555890279828312== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZyeABZ831vo0PBfB" Content-Disposition: inline --ZyeABZ831vo0PBfB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 10, 2026 at 11:59:00AM +0100, Lucas Tanure wrote: > The informative section explains in prose how phy-mode, the delay > properties in the MAC node and the mode handed to the PHY fit together, > and says itself that developers often get this wrong. A reader has to > work through several paragraphs before answering the one question they > usually have: for this phy-mode and these properties, which part adds > which delay. >=20 > Add a table that answers it at a glance, with one row for every > combination the properties allow. >=20 > Assisted-by: LLM > Signed-off-by: Lucas Tanure If the net guys think this is valuable, Acked-by: Conor Dooley (although for something like this, us acking probably ain't needed, ehh?) > --- > .../bindings/net/ethernet-controller.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.ya= ml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index 1bafd687dcb1..bba27a9feb61 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -339,6 +339,24 @@ additionalProperties: true > # has added. Failure to remove the delay will result in a > # non-functioning link. > # > +# Put together, with the two properties in the MAC node, this is who > +# adds each delay: > +# > +# phy-mode tx-internal-delay-ps rx-internal-delay-ps TX delay = RX delay > +# rgmii - - PCB trace = PCB trace > +# rgmii-id - - PHY = PHY > +# rgmii-id present - MAC = PHY > +# rgmii-id - present PHY = MAC > +# rgmii-id present present MAC = MAC > +# rgmii-txid - - PHY = PCB trace > +# rgmii-txid present - MAC = PCB trace > +# rgmii-rxid - - PCB trace = PHY > +# rgmii-rxid - present PCB trace = MAC > +# > +# A property for a clock the PCB already delays is not in this table. > +# It is either the fine tuning described next, or a mistake the MAC > +# should report as a fatal error. > +# > # Sometimes there is a need to fine tune the delays. Often the MAC or > # PHY can perform this fine tuning. In the MAC node, the Device Tree > # properties 'rx-internal-delay-ps' and 'tx-internal-delay-ps' should > --=20 > 2.56.0 >=20 --ZyeABZ831vo0PBfB Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCas0yiwAKCRB4tDGHoIJi 0pqvAPsGoQ0dZuqznMzflFnrJJONMATY3If2+uw3QIz/GHgDxAEA6x8lm1tyHUeS J/yJwvaHqlB8POud4yNTEmA/S8/ccQs= =6vsf -----END PGP SIGNATURE----- --ZyeABZ831vo0PBfB-- --===============8652555890279828312== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============8652555890279828312==--