From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3129CC6B1A for ; Wed, 14 Oct 2026 12:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XjWBc3Ixpry2EofL9unxvgjyKlMbKVuMeZTNqAlneVs=; b=rJKk05jmhqpZCq gpzX9QHi93Judxo7WYC+htbFS6HpG4SXV6DT3SFJrz6TS9IRvKW+2uH7VYsmgY8loz6V2tRrCVyJR oq64HvcIYBYK68DFzuGmJDo5asmgOnF3CKNgN343KgUV/WeZZ10Nl6Jsa7pw68HrUibS5d/m9BBHu RVX9tPHjcTpmXq4nD67c9Y4t1Gm50XAd4SXNlzE04YiiWwKrCIjKEFrOCsutkflnFFOuWCAAE1Snb p3k3ynWPHnnes5TxgEJYf+Jo+FqPwjHsFa62k3VqHcuoNzWopT0Ti0N7c+Wq1PiVMUBp71lyxKH95 p/yBW/4NoeFwCAxWOfoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGyEL-0000000FRdD-48Xp; Wed, 14 Oct 2026 12:37:13 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGyEH-0000000FRXm-0jwd for linux-amlogic@lists.infradead.org; Wed, 14 Oct 2026 12:37:11 +0000 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69EBbsLH2515922 for ; Wed, 14 Oct 2026 12:37:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rewnoAte/tJ+Uf3m9Ci2S88OVFipQXBWInPmr2cUEoY=; b=AlfsYFZZiHLF5rCi wGlfXU/2kSJ+RvyjkPXizaFvhtZcX3+soS8b9X0bEtpg2jMZ1/KehuZctksYXhy4 w9GsiK/7mhC3RvdEaF0j0rqYO4HWDnEm7ERb2G+36WyxrWGnY0dE6DebcM/ugyeB jcWDmG/3njb5u1KZ+SCDCpOEG3IFdeBR9BKxj0xw1uOjuPDUzMhV27+gBwH7VX28 69lITh8sNIuvikehQB59dc4gYzSmSRJLtNZ1wxtF94p0evtDy02VaTKHFKw0NBeR WsIqoCGxiZowXFKI1j+zcpye3M52Ah7lbkDzsUaoqMPSQPZSH1LDw32zKDvstXIp qoiYLw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ha4709hp7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Oct 2026 12:37:08 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93caa0ce0cdso38508785a.2 for ; Wed, 14 Oct 2026 05:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791981427; x=1792586227; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rewnoAte/tJ+Uf3m9Ci2S88OVFipQXBWInPmr2cUEoY=; b=OHPXxj8J4VpRvN7aOs5iNLeE7kXy/kbgQtPry0QJFhidNErYGI+zyJDZK/EYhkB7hq BY/qpEwwgcYJ4pgmldekGjCTpz6/ocz8P743HY0iE+hE1iVAwyR3gF7aTEQO0r1iKyLE QxGHpVuCAK7cVYuqXnXJJkh8I6ZysizcvE7K0ICsDCQnu5Ke1NFXNCNdahhTbzcNmq6+ 0JNitQaDLR6Zg+T9aSN9QJwPli0uJI0judAenzJOMH2+osOUpKVxrj3THPJUUvNiJmM+ 6OER49CdcmmzVsifDW5NGZl15mD3rZ+cvPmnhXyxM6Idy8CxfBgNLxImPXh8KV6+4JXG RUNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791981427; x=1792586227; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rewnoAte/tJ+Uf3m9Ci2S88OVFipQXBWInPmr2cUEoY=; b=MYHK7NMXXw567d6ccSXyvWlxI7Y+eIoUwLPJ2rR4X2V21hRH7EE+DweDhvAlkb5SQn PqaZN1y/JzCnTS01kFZo63USCN/t5QVOEbaGFlNpfBxucPFFOaSyYV0+ZC0la/phs9xf ofcXF8tdxsxlbo9Uv9XC086/NLBVe+MFfrOy/4NdRezDoIuMVw4SknKFRxZImvFkkNRO iBG09WMRYQl9d7Jexox+wwqaXlYSB1drQYOlJ6kYTRj5/nyH/OIpMOhK6owuQsnaY+i1 pkdy8/2PY0I2Mr9uidXqg3ltcIh2MiQ0nFgZrpxYIg8BrIBNIlq7T/+oYzZ3DAakj0U3 uvTg== X-Forwarded-Encrypted: i=1; AKwUvBz5qq7WkfZlpcM2+DLa3S6N/YSXYPbA33j8q6bVQKhVzbD/4RosTjZVO1oJ9t+xTORsVYOeAIzay6sWhdAI@lists.infradead.org X-Gm-Message-State: AFq9FYKYTu9VILKVUgh59dDlXyJau4D2j1LZFEPzaEeklpVEoQeF3YiC mdsVs4X8yj/5iKS4qdEINoqZWGjLP+2QjY5tzrM4sDTXb3GZu5mOOK8H+FTORmBJon31ot+ZyTB obKSN46Hwr2QpS8NWlm4yGUuTkONn54k61UMRTfVswgd/C2+cXi9yBcVz5m2wqKWKCzS2UQL3eA == X-Gm-Gg: AYBFou3C0TtObIXXd/Q0Rnk/LcZTyzGJUCmfdHTHWzeyly/C1QX5l0yEL6XV9iHAiLp wYam/DdvKCs9QaH7bI4UVbqOmMicYDjAGCNYYlcXvE9RBYZmsGFariT7fCt106240GZNv0fTcbP uOkmGohF+eB4R/mcgAd3tv0Rtohkob/cSIIbp0GQy7emkYLCRFryOALvHF9iPY5fMFBz0XwUOmu KhtQJcAAe5RHgiADomq5imcXVLU7NoS1XTG/SMQTjb8BMMz/huU5+SXv0v5VcpbWds7j+KC+71X oCEfvf83Q91aicw+WhzO1DTcTfQNdqZV+skDgyec/KPQaLIpc48JEweGHxxfIpp92RJAXzpwmPf jntmmn0tFxcTYok/hSpHVGrkDVMRX X-Received: by 2002:a05:620a:44c4:b0:93b:d7a2:dd2b with SMTP id af79cd13be357-93ebd282089mr2546074785a.59.1791981427441; Wed, 14 Oct 2026 05:37:07 -0700 (PDT) X-Received: by 2002:a05:620a:44c4:b0:93b:d7a2:dd2b with SMTP id af79cd13be357-93ebd282089mr2546067185a.59.1791981426847; Wed, 14 Oct 2026 05:37:06 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:8916:7b9b:97a2:6c96]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a19f318c31sm206122615e9.3.2026.10.14.05.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 05:37:05 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 14 Oct 2026 14:36:40 +0200 Subject: [PATCH net-next v16 1/7] net: stmmac: dwmac4: don't program the 1us tick counter without a CSR clock MIME-Version: 1.0 Message-Id: <20261014-qcom-sa8255p-emac-v16-1-0266c2ead980@oss.qualcomm.com> References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> In-Reply-To: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Bartosz Golaszewski , Sashiko X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2229; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=2sBp7G5mc6uJL64UNxM6dPPb+46Qh7eHGxK9GvyQ9M8=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqz3dl4m+qpuql2x9Vuhi+JubZ+193cRWj0/Vsd rhj3qvfaZWJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCas93ZQAKCRAFnS7L/zaE wxR0D/wIXdjVmoAyOQeH7rB9q9+tq0uz6+cpOevgEQPFym6rHDfDydYuv+Yx0TwmDKaVxqZEqA9 jkqxQdxY0HzAlkxLaSYJL9dSajCUAOaQizKey3sUqyZ7gTnQDdYKJIM0saQvyScb+N+VM1CDA8k nCOaR4A1ZkyhRe1eaRwXPwqDRV23Y3dscokhHny/y2qlzPrjHUcocoY9Pxz2mKFyd/1dPshepuB ALhQTHp2qyGnx/sbNa40NyMyYIxUSOqLNpg7MPPZ/eHcKYgkGdFKBuvD2nc/aTbpFGHG5jyxLP7 frCLl5Xa+7k1cT8qg4UPQXAjT5M9VZGOy0QgPZLiQMJdI7DjYAqQCNwAjEPF6Bdmm3tpaZetRLC XgnGVlbnhs/uZHx/2whbV9/5bXedTCMQikDfotazCFTGCdTIo+U5ShDYDkAFqkFxFAMdt1Q77RU FrTnQ/+A4OMvVXId7/C5hRBwuLsxeyoEqwLXi7guVcuc++nVFS9OqFGBV0mCz2L/Hv3+M0qQ3SK 5kDrgaYLzvgplw4JYzqeNct7wnTR6M+0AxpMQbSCzDQKiIXYKo22NyVVXf8wZNCzpQ3j8Wix6vp 14Gpzo8HiHXuQp4PsyR+VZQ3zaYmSmsJGP8CN32EV6T2d1AeDhgTNRKD1oP6kJRByraeJ6rRevV 024vzSVRofGO1kA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE0MDA1MCBTYWx0ZWRfX5b39wPu/sIFs +5XqO109ZJKBYTeSpdSJUSjpIGvKmJ1PNzyRIXhzXfxysyYQeDA+OlgB4GTuVyIFDpGg3+pJUHT eoqJbu+kmkPvwwlRKLd3zQ29auEgEVLdrh8fgbfNy9RaFi0Z1zlNkrLAE3L48JcgJViFjWIuj/7 x7F2Hfcgy7TE83+MTCS+T/s6wEAMb71Zce49no/28qF/Ur2XJHQPVYol+m1bPizWmClon9Ris0Z MfHcLCc4MBvqGq20GyAEqzmSHmwFlNo9BzWNPPO0CckYIiGlLPLacE/ZipgR6vnDRwLztEUPd1e hoS3j77KDloGwDP36JUJ/25K1sJ6KE+cyHIewMd4M2psvbdOat2Nq//MhRAJslssbZHnypxfeiA 6c8RKYhtOVWfnZn9qsFjovGpEmQD9ZZWQ3vRMCJoPVq2P48oAZD+XkecmIhPb7Epqw2ISgG5MrS XRR5fdDHkmeJ6SiZ47g== X-Proofpoint-GUID: rm9Kg85XP2wr-Hogp-AiG7aVt6Dktpsc X-Authority-Analysis: v=2.4 cv=P6avFSAu c=1 sm=1 tr=0 ts=6acf7774 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Xm6EMxWvXKbCXn_Kg3kA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: rm9Kg85XP2wr-Hogp-AiG7aVt6Dktpsc X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE0MDA1MCBTYWx0ZWRfX1wbByXO5lG1d 77VL1x5Ikn6UIMffqssDeNwlO6gWzQZt5LBKlX2HM8SJKwOVNUAGAlZ33MFXwO1kvqidkZ42362 IzSY9pAeVY1KUy8obmcfolTg+VRiRzU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610140050 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261014_053709_404439_14C3354E X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org dwmac4_core_init() derives the TIC counter value from the rate of the CSR clock. If no such clock is available (for instance because clocks are managed by firmware and not described in DT), the rate is 0 and (0 / 1000000) - 1 underflows to 0xffffffff, which is then written to the register and can break the LPI timers that count in microseconds. Leave the register at its reset value when the CSR clock rate is unknown. The RX watchdog conversion helpers already cope with a missing clock by falling back to clk_ref_rate or returning 0, so nothing else needs to change. This is first hit with the Qualcomm sa8255p ethernet, whose DT has no clocks. Fixes: 68f5d3dc2808 ("net: stmmac: qcom-ethqos: add support for sa8255p") Reported-by: Sashiko Closes: https://lore.kernel.org/all/179052656185.2160803.1751830002645522416@kernel.org/ Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c index cd6c5d6f42b5445918f277a2b4168d8f473bfca1..259e2ebed8c14dfdb9318da9be03c5f1dc9b1284 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c @@ -48,9 +48,14 @@ static void dwmac4_core_init(struct mac_device_info *hw, value = readl(ioaddr + GMAC_CONFIG); writel(value | GMAC_CORE_INIT, ioaddr + GMAC_CONFIG); - /* Configure LPI 1us counter to number of CSR clock ticks in 1us - 1 */ + /* Configure LPI 1us counter to number of CSR clock ticks in 1us - 1. + * Platforms with firmware-managed clocks may not expose the CSR clock + * to linux, in which case there's no meaningful value to program. + */ clk_rate = clk_get_rate(priv->plat->stmmac_clk); - writel((clk_rate / 1000000) - 1, ioaddr + GMAC4_MAC_ONEUS_TIC_COUNTER); + if (clk_rate >= 1000000) + writel((clk_rate / 1000000) - 1, + ioaddr + GMAC4_MAC_ONEUS_TIC_COUNTER); /* Enable GMAC interrupts */ writel(GMAC_INT_DEFAULT_ENABLE, ioaddr + GMAC_INT_EN); -- 2.47.3 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic