From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09E7B606A322 for ; Mon, 26 Oct 2026 13:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=dqvjEciH; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=L2WgO7gM DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=RpKE+KAYYV4jUxzxQeg6d2KpdvayEIi0syyrdaPlwyk=; b=dqvjEciHe/BWCJdwMwdulL0GrB mJTk0kYhW3xgnBzMocmg1hJ2E6bLAfuPQ9PygMgAmIq4KrSOv2V6RSmp80HOTjxjBPBx/vhu1QQ+M lBsRr39ycUmYPFYMvqSROOAm2CUd3mTmTAqstwmBebc4dxnxawvSPtI0uxA/v8g2VpjYAcGEtrxFv Imde4CZTakQXAAFaVKM0u8p811f00WNY6wG9Ii1Mh6/tD/OijOVzAg35JjI9XpTCX+TG2jjqEUoSl gZIAws1HnP1HyV2mUAoHsnqhEmLvMMqGk9bvdiwG36ekIS8wNoIKeE+tyRpmy+cehH4/vClRBdyrK yRspJgQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLKm6-00000002bK9-2dCc; Mon, 26 Oct 2026 13:30:06 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLKlx-00000002bGG-291N for linux-amlogic@lists.infradead.org; Mon, 26 Oct 2026 13:29:58 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-48e0d885929so1955224f8f.3 for ; Mon, 26 Oct 2026 06:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1793021395; x=1793626195; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BO6aaS6rcK9WalnH265ep27g6d3OOM+TLOjjpCjcQ0M=; b=L2WgO7gMTxl7BJBlV4LG7E68WjGhWNAK34CtxM9p42n2x30Gd2ZalgEtLX10ZWNqkp yJ7dZK1OAUxumweC0EM8IpVkz5bHkEkoKVP4uWKHnloTo9RFPAReT2nNK0XFX5uCaZye E7AbKQUAYtIAS5odapEDR8sDNOGPUDw0gf08FT80U/cSjOR8EkKYUkDqIQOrihKGOGSK LbG4DlwonsrD3z0K9xI2erCa1Hh49oNAMgVlDAwuuHbvuiWJoB972eUGwuN/YfZdgfIf OZ8pRdklx2Nnu5+MxpJu6pdZZ7s7t8pzp0GSzCPSIgN9TQnWeEKqkVmdYOVEYc4351zQ V/oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793021395; x=1793626195; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BO6aaS6rcK9WalnH265ep27g6d3OOM+TLOjjpCjcQ0M=; b=trM3t/dMLvFItYBmNH+DxPXcB3Zn3fHWJZRQOdk5lz+AyGEqMk0KWd+4RhzPMiHSWE b67i/asswcRLIW2YpObrYAf5zcTkAx+BbM7CZppN/5Q7NTI4j40mwXSwvpneX1ZRUUg6 TnhkigHfdfYhutZN5Eq6dXIQOEMAUodnSbZLpXS+FpyLN1egZcW4kgqR7Eyl/bXBRP5+ DrNmApYkxUmTkZy/m3x3/9A4ilHIHL2F8GUV6OFVdRfmJzIKvPA/HmgJa4eyBWlIUA+D wF/ggsR7S/rNhR0vHrsO5XX8NPYv02Y/cMg9wiNk6fdJq68gl9u8bKzCba9GnMMaX+Ur GDOg== X-Gm-Message-State: AFq9FYLwITEiCHO4+sxLNY/PEi6nlKGX4yW/VNnVw7ZEXZMKHxsD3y0C NY1ns1c3FbD3pPvwfeTMlRGkeW5MhdrmL60yihZ3cduOO5vDGFtsg/qnrNDzWfh6rU4= X-Gm-Gg: AYBFou2IP6J+65S/b8dYO6HvcBBUgU7mScD6GubteQNsPbGZomVmFFkoDjtFOn5pRzq 2h7pd6Y8jYxwS3d8YOKeMVg4WL1p/+KoLlZHUvn7EyKgSVXskUECuIZhVM3TyBHCAy3lug6Fd6r rttJF28FDGqdc6SjPkeAW0UWE1gXFXUyWWqhf9KisuYp80qMb18nQMCS8Ui6DgPx9iWIZ9q7PHL 7R7sxgUxkhXwNk/xmOe17DTViUcFdv5qKHVsJ57wRoIsLamkLtnyQ6mlEhHsx1Z2tsD94PbHeN5 g1ptYrml7D8tKybbLgvfhh2wK9kuczLaE+rDtFayV2sImbmuORTKHCMIYwUSudV2TIpHAsSiJBd 5+vkjuBRERfct3KAFVs+gbnFIdCKJL45uHunjrE/K7yZWM42LyX3Ol6POnZVuPB0g7kIBUEiubh xflTccr4chSTMDP/bllAGOttoehMxJzQMb72aHQM6knZfPASM95s6bgQM1Vr+3RpPvGzDje3Wcf UlmBArwobCx7WhxFZ+9rgscZL62ZQsGmIbn6NVWQ0qt3bNEeUlNBlYeoLQYGzGFqZKnpsnzCKw3 ydOOoPpyRW3dzS/3s48g5Fn2DLdPIiZukS3eLlsWx5ZFu0c+P9z25Iyj/WMCX7NWnhijSiIA X-Received: by 2002:a05:600c:3e10:b0:4a1:9661:14b5 with SMTP id 5b1f17b1804b1-4a35acba868mr111743135e9.29.1793021395526; Mon, 26 Oct 2026 06:29:55 -0700 (PDT) Received: from macbook.homenet.telecomitalia.it (host-95-246-144-141.retail.telecomitalia.it. [95.246.144.141]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a359fbb725sm194507095e9.0.2026.10.26.06.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 06:29:54 -0700 (PDT) From: Carlo Caione Date: Mon, 26 Oct 2026 14:29:45 +0100 Subject: [PATCH 2/2] clk: meson: regmap: use the current divisor for read-only clocks X-Archived-By: MIME-Version: 1.0 Message-Id: <20261026-upstream-clk-regmap-ro-divider-v1-2-c8216b0fb93a@baylibre.com> References: <20261026-upstream-clk-regmap-ro-divider-v1-0-c8216b0fb93a@baylibre.com> In-Reply-To: <20261026-upstream-clk-regmap-ro-divider-v1-0-c8216b0fb93a@baylibre.com> To: Neil Armstrong , Jerome Brunet , Stephen Boyd , Brian Masney , Kevin Hilman , Martin Blumenstingl Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Carlo Caione X-Mailer: b4 0.16.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261026_062957_605951_92AC7A6B X-CRM114-Status: GOOD ( 12.79 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 None of the Meson clocks using clk_regmap_divider_ro_ops set CLK_DIVIDER_READ_ONLY. Without that flag, the shared rounding callback can choose a new divisor even though these ops cannot program it. The clock core may then adjust child clocks using the wrong parent rate. Make the read-only ops always round using the current hardware divisor. Parent rate changes remain allowed with CLK_SET_RATE_PARENT. Signed-off-by: Carlo Caione --- drivers/clk/meson/clk-regmap.c | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/clk/meson/clk-regmap.c b/drivers/clk/meson/clk-regmap.c index 1ed56fe63cae..002e16865109 100644 --- a/drivers/clk/meson/clk-regmap.c +++ b/drivers/clk/meson/clk-regmap.c @@ -120,26 +120,34 @@ static unsigned long clk_regmap_div_recalc_rate(struct clk_hw *hw, div->width); } -static int clk_regmap_div_determine_rate(struct clk_hw *hw, - struct clk_rate_request *req) +static int clk_regmap_div_ro_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct clk_regmap *clk = to_clk_regmap(hw); struct clk_regmap_div_data *div = clk_get_regmap_div_data(clk); unsigned int val; int ret; - /* if read only, just return current value */ - if (div->flags & CLK_DIVIDER_READ_ONLY) { - ret = regmap_read(clk->map, div->offset, &val); - if (ret) - return ret; + ret = regmap_read(clk->map, div->offset, &val); + if (ret) + return ret; - val >>= div->shift; - val &= clk_div_mask(div->width); + val >>= div->shift; + val &= clk_div_mask(div->width); - return divider_ro_determine_rate(hw, req, div->table, - div->width, div->flags, val); - } + return divider_ro_determine_rate(hw, req, div->table, div->width, + div->flags, val); +} + +static int clk_regmap_div_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) +{ + struct clk_regmap *clk = to_clk_regmap(hw); + struct clk_regmap_div_data *div = clk_get_regmap_div_data(clk); + + /* if read only, just return current value */ + if (div->flags & CLK_DIVIDER_READ_ONLY) + return clk_regmap_div_ro_determine_rate(hw, req); return divider_determine_rate(hw, req, div->table, div->width, div->flags); @@ -176,7 +184,7 @@ EXPORT_SYMBOL_NS_GPL(clk_regmap_divider_ops, "CLK_MESON"); const struct clk_ops clk_regmap_divider_ro_ops = { .init = clk_regmap_init, .recalc_rate = clk_regmap_div_recalc_rate, - .determine_rate = clk_regmap_div_determine_rate, + .determine_rate = clk_regmap_div_ro_determine_rate, }; EXPORT_SYMBOL_NS_GPL(clk_regmap_divider_ro_ops, "CLK_MESON"); -- 2.56.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic