From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Wentao Liang <vulab@iscas.ac.cn>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] serial: meson: unregister the UART driver if port registration fails
Date: Wed, 4 Nov 2026 11:49:58 +0100 [thread overview]
Message-ID: <2026110413-delegate-antitoxic-1264@gregkh> (raw)
In-Reply-To: <5b741c90-4e57-425e-b3ef-b8d10eac1f33@kernel.org>
On Wed, Nov 04, 2026 at 08:02:33AM +0100, Jiri Slaby wrote:
> On 04. 11. 26, 3:15, Wentao Liang wrote:
> > meson_uart_probe() registers the shared uart_driver on the first port and
> > relies on meson_uart_remove() to unregister it once the last port is
> > removed. If uart_add_one_port() fails, probe returns an error, so remove
> > is never called and the driver stays registered, leaking its tty driver
> > and per-port state.
> >
> > Remember whether this probe registered the driver and unregister it again
> > when adding the port fails.
> >
> > Fixes: e71aab9d6132 ("tty: serial: meson: apply ttyS devname instead of ttyAML for new SoCs")
> > Cc: stable@vger.kernel.org
> > Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> > Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
>
> makes sense to me:
> Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Nope, this is a bot, I strongly recommend that everyone just add this
address to their email killfile as they never respond and spam out tons
of crap.
thanks,
greg k-h
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-11-04 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 2:15 Wentao Liang
2026-11-04 7:02 ` Jiri Slaby
2026-11-04 10:49 ` Greg Kroah-Hartman [this message]
2026-11-04 8:45 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026110413-delegate-antitoxic-1264@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®