From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81672608D97A for ; Sat, 7 Nov 2026 10:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=2KHKMZEe; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=nwjNFf7h; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=zrfShWIu DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=WcC3jzqqE8IWkDVtZIg1qy2a2/VBk0W25za54l0K4LA=; b=2KHKMZEe3RncLSYqPr9d8DjnZN DiXgqBASGczxPoXuKfCOpkEEZwwDq6L6JL9PoABokoI0o783fbDkwhG01UWytlE1e3M0KaItLZU7/ sowSmrXzi73RrZIKp9StHt3Ijos/xGwdHYrWlO3fHrhED94fR/Cv4rrAgt12AUO635U1/qmszaDe1 Ipni4WCvwbu5YgvkG7fJ5phsABvF7LdnazR8dLTdZLfrZwmifHPtbe+FsvzcUvIuebSA+c7/Iz00J qZbVUOGFwerBckt6iHeXT6V6s7zYqjeUT+4okVgJE4VZGeqL6q1TN3tajkVw6e6S5CGsq5e26zV8R hB4T5WXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPdUI-0000000EU8O-1T0u; Sat, 07 Nov 2026 10:17:30 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPdTt-0000000ETYm-07jY for linux-amlogic@bombadil.infradead.org; Sat, 07 Nov 2026 10:17:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=zPNlTJQB2JtnHksSH6UTNWuXH1VDaK++sm3Uz94AgtA=; b=nwjNFf7hrO7vh/sDxwbT9a/0aM dkGBrUNgGNVZVcL14k46jF+Op74fltkBSEcHsF9bpnmn4bkkuDvMn9jawRmOhgtUa0irDAcWf739a JTP74PyHmHWTK9y1kX4BtquRdIPmreYVdhlGH+ScE0knI0Yj9LmtnGdjISIyJ8/R4PiggJUF/duBn Dv4b+0LDpPswCzRIBGm6fPu/8f/wncYSmMRTbSp31Q7qhd3bfN8ESwzzvo+5GT+Y/RGwpgwvl4ulk KJo9yvu7Ow8yEi3D8a4QEfl0/zdohxxU32Pw3vJXOlY99GcZuwsBuONPCM7dbbAfQLDneN6m6j2Uu R01F2usQ==; Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]) by desiato.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPdTp-000000057jw-089E for linux-amlogic@lists.infradead.org; Sat, 07 Nov 2026 10:17:03 +0000 Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-8490a7d6696so973735a34.3 for ; Sat, 07 Nov 2026 02:17:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794046619; x=1794651419; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zPNlTJQB2JtnHksSH6UTNWuXH1VDaK++sm3Uz94AgtA=; b=zrfShWIu+gH5zGu5JTyA4ymLYmdRYANM69bN2GFekWP1OZZt4FvYqHn+miwHwxFqCD yPcmc7yz8s04PIFBMCLYtxIti4irI4izF3mfUCLZkzgKQ/bpSDdFy8x3kXcvhCmZvvtH QPdxKX4vPlWM3SPoKYdKl6ON8wePgS3Xy2AFu2eCKsADYhZnzg4aeofQbbRxOQlb5XF8 tnxmuBv/onrprDIrAOKO4z5ftac98zECpVl4ZN6vtC1XjeQtie+YwMyZKNSe6Hp7UES5 J/I/HeGKhTx4t880duEJZgdQZtF6yZfSJ12JoTYa3ryKg8Bej03p9N9ikWgsnjXBPBrC VV9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794046619; x=1794651419; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zPNlTJQB2JtnHksSH6UTNWuXH1VDaK++sm3Uz94AgtA=; b=Y24dQbaod1kNJGUk4miXXt//0pFsK1MpqlBvoCQKaPlIsFM997OK/JVSwI8aOdRAnn h/Dyn9dRuOBbfRtuCcY+lcNzhPNKAb0gGvqEt7GqUI+mZXQjdeYdLqFUn0ox4XXhnZQf NYaBfldRpPYBR/oGdHlyl3PzZcstha7w5xrMaS/qwz/W+zGLuOma+gYxfDeCLa7k+y05 59fbFe6t77FFfO2MyKayarczOhFK1CEpnnijBaPxUEpQyoz9bJo+GgMyxN9gvsrnTObs I2xw1S8Z6uiPPL0ew/ewNKT7It1hszCqCHJHzBWfOGwX7ZX/NhmOw8xv5yGw7MZTVJwf sLuQ== X-Forwarded-Encrypted: i=1; AKwUvBzpjnu8kaTaGTN+4Ccy0Uj3SD1o1hrMco4A9E66vzgG17wf2vN4YF3jy5ci9OmpDnxwd5CoVygBcRA5zzJo@lists.infradead.org X-Gm-Message-State: APuU4Z9mXkYlkGwq0STIUHkBApnyLQiV9CSkg9ytR74hutdgRe/0UDoq zsmjswUtq9xmu8uNcbS1EGcjex7jP/2nMn83y3ANWIL20biZf7vbx+V7 X-Gm-Gg: AYBFou31F69rUlZY4Zm8+p3N2Z/eNx1tsG9aRiQxPVbZ8qffYKN0qpzVw2nQA+lejL+ RNF0Rqlp39T4xgW0U7J5UG3ColgxfIttduKqqcsxv7XdvA3oO/cNrQoFgngHWw4IR8CzE2i5Wm7 qoqB2CoWdmPbdJMURATuY4+VfS1cdQOaEKYAUwv9W1OgIMuhQZD5l87NuxVA8CWxCV+fXS35PgF K7vd7QAlWVfvLWRujHj7cPJnlWIrWd+Laj1gCs5dsaqqLVqJgJLmfvPvvVJB4noi9hm7RP+YoXs 9RU0Q2kh32TaYThdPXiwaiQh0vj9h/54/SUegKXX2mW0yiMCx9AVQLBEqdFl3VmaS/fPIGdMlcB ZIv32PEY5WbDkx0bXH3/4i5AsdA1kQMgCXuylxSZxtOb04TmNgNbc/Gnjehl/cKcpt+D3fIJtCk pnsheXC0qWxlwfqW5nSM1MONio9uU9c8zZl4YbzV9h8s+fYAdtzWyljdwCN36FDudxKycWCoD8q 4gDzAZ/Dhuj+oBCKX+k7hWflMPnlMUza5tfc2C18GipcMPvsLaLPNfhuqzXjK7Se6tjeKOo8vg/ 7pKgL1AHliINtVvgwvalFtmKYNhlefnY2pODvh2R6A2Pe8Y1acTpJ+c8N4TW+AVePALOiw2kIMd 99ZxzVp0jNN/VWrLHlDlffVM46zTeIpnSfkOJYLCT3LqVuHzty7B004LNJe5S0heZWihDlrQ6a2 r5QWADRKk6v57GuglgonORzYs82YDS8uvN7sn51ySyuRNd4D2JBlRd X-Received: by 2002:a05:6830:7182:b0:85e:f82d:4389 with SMTP id 46e09a7af769-85f1d001fdemr4006750a34.14.1794046618968; Sat, 07 Nov 2026 02:16:58 -0800 (PST) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-85f1dbef224sm3990269a34.12.2026.11.07.02.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2026 02:16:58 -0800 (PST) From: James Hilliard Date: Sat, 07 Nov 2026 03:16:09 -0700 Subject: [PATCH 12/58] mtd: rawnand: arasan: retain chips across controller removal X-Archived-By: MIME-Version: 1.0 Message-Id: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-12-0181ef0cc4c8@gmail.com> References: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> In-Reply-To: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Brian Norris , Boris Brezillon , Arseniy Krasnov , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thomas Gleixner , Vitaly Wool , David Woodhouse , Russell King , David Woodhouse , Mike Rapoport , Maxime Coquelin , Alexandre Torgue , Christophe Kerello , Jason Roberts , Michal Simek , Boris Brezillon , Mason Yang , Ramuthevar Vadivel Murugan , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Dmitry Osipenko , Matthias Brugger , AngeloGioacchino Del Regno , Jorge Ramirez-Ortiz , Heiko Stuebner , Yifeng Zhao , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Keguang Zhang , Jacky Huang , Shan-Chun Hung , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Liang Yang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Manivannan Sadhasivam , Kamal Dasu , Broadcom internal kernel review list , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Cercueil , Harvey Hunt , Maxim Levitsky , Michael Walle , Srinivas Kandagatla Cc: Tze Yee Ng , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_101701_117112_3FFEDE3B X-CRM114-Status: GOOD ( 19.21 ) X-Spam-Score: 0.1 (/) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Keep chip metadata, BCH state and controller storage until the last MTD reference is released. Unregister and disconnect the chips before releasing chip-select GPIOs, so notifier I/O and active NAND operations finish while the hardware is usable. Free unpublished chip allocations directly and use retained cleanup after MTD registration has been attempted. Fixes: 197b88fecc50 ("mtd: rawnand: arasan: Add new Arasan NAND controller") Signed-off-by: James Hilliard --- drivers/mtd/nand/raw/arasan-nand-controller.c | 57 ++++++++++++++++++++------- 1 file changed, 42 insertions(+), 15 deletions(-) diff --git a/drivers/mtd/nand/raw/arasan-nand-controller.c b/drivers/mtd/nand/raw/arasan-nand-controller.c index 865754737f5f..57b5d6119b70 100644 --- a/drivers/mtd/nand/raw/arasan-nand-controller.c +++ b/drivers/mtd/nand/raw/arasan-nand-controller.c @@ -1269,6 +1269,11 @@ static const struct nand_controller_ops anfc_ops = { .detach_chip = anfc_detach_chip, }; +static void anfc_chip_release(struct nand_chip *chip) +{ + kfree(to_anand(chip)); +} + static int anfc_chip_init(struct arasan_nfc *nfc, struct device_node *np) { struct anand *anand; @@ -1276,7 +1281,7 @@ static int anfc_chip_init(struct arasan_nfc *nfc, struct device_node *np) struct mtd_info *mtd; int rb, ret, i; - anand = devm_kzalloc(nfc->dev, sizeof(*anand), GFP_KERNEL); + anand = kzalloc_obj(*anand); if (!anand) return -ENOMEM; @@ -1284,31 +1289,35 @@ static int anfc_chip_init(struct arasan_nfc *nfc, struct device_node *np) anand->ncs_idx = of_property_count_elems_of_size(np, "reg", sizeof(u32)); if (anand->ncs_idx <= 0 || anand->ncs_idx > nfc->ncs) { dev_err(nfc->dev, "Invalid reg property\n"); - return -EINVAL; + ret = -EINVAL; + goto free_chip; } anand->cs_idx = devm_kcalloc(nfc->dev, anand->ncs_idx, sizeof(*anand->cs_idx), GFP_KERNEL); - if (!anand->cs_idx) - return -ENOMEM; + if (!anand->cs_idx) { + ret = -ENOMEM; + goto free_chip; + } for (i = 0; i < anand->ncs_idx; i++) { ret = of_property_read_u32_index(np, "reg", i, &anand->cs_idx[i]); if (ret) { dev_err(nfc->dev, "invalid CS property: %d\n", ret); - return ret; + goto free_chip; } } /* Ready-busy init */ ret = of_property_read_u32(np, "nand-rb", &rb); if (ret) - return ret; + goto free_chip; if (rb >= ANFC_MAX_CS) { dev_err(nfc->dev, "Wrong RB %d\n", rb); - return -EINVAL; + ret = -EINVAL; + goto free_chip; } anand->rb = rb; @@ -1323,24 +1332,35 @@ static int anfc_chip_init(struct arasan_nfc *nfc, struct device_node *np) nand_set_flash_node(chip, np); if (!mtd->name) { dev_err(nfc->dev, "NAND label property is mandatory\n"); - return -EINVAL; + ret = -EINVAL; + goto free_chip; } ret = nand_scan(chip, anand->ncs_idx); if (ret) { dev_err(nfc->dev, "Scan operation failed\n"); - return ret; + goto free_chip; } - ret = mtd_device_register(mtd, NULL, 0); + ret = nand_set_release(chip, anfc_chip_release); if (ret) { nand_cleanup(chip); + goto free_chip; + } + ret = mtd_device_register(mtd, NULL, 0); + if (ret) { + nand_disconnect(chip); + mtd_put_master(mtd); return ret; } list_add_tail(&anand->node, &nfc->chips); return 0; + +free_chip: + kfree(anand); + return ret; } static void anfc_chips_cleanup(struct arasan_nfc *nfc) @@ -1353,8 +1373,9 @@ static void anfc_chips_cleanup(struct arasan_nfc *nfc) chip = &anand->chip; ret = mtd_device_unregister(nand_to_mtd(chip)); WARN_ON(ret); - nand_cleanup(chip); + nand_disconnect(chip); list_del(&anand->node); + mtd_put_master(nand_to_mtd(chip)); } } @@ -1431,17 +1452,24 @@ static int anfc_parse_cs(struct arasan_nfc *nfc) return 0; } +static void anfc_release(struct nand_controller *controller) +{ + kfree(container_of(controller, struct arasan_nfc, controller)); +} + static int anfc_probe(struct platform_device *pdev) { struct arasan_nfc *nfc; int ret; - nfc = devm_kzalloc(&pdev->dev, sizeof(*nfc), GFP_KERNEL); + nfc = kzalloc_obj(*nfc); if (!nfc) return -ENOMEM; + ret = devm_nand_controller_init(&pdev->dev, &nfc->controller, anfc_release); + if (ret) + return ret; nfc->dev = &pdev->dev; - nand_controller_init(&nfc->controller); nfc->controller.ops = &anfc_ops; INIT_LIST_HEAD(&nfc->chips); @@ -1481,13 +1509,12 @@ static void anfc_remove(struct platform_device *pdev) int i; struct arasan_nfc *nfc = platform_get_drvdata(pdev); + anfc_chips_cleanup(nfc); for (i = 0; i < nfc->ncs; i++) { if (nfc->cs_array[i]) { gpiod_put(nfc->cs_array[i]); } } - - anfc_chips_cleanup(nfc); } static const struct of_device_id anfc_ids[] = { -- 2.53.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic