From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE693606D805 for ; Sat, 7 Nov 2026 10:17:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=rsdrxstz; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=nrVXexCC; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=XFL5IdKc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=2HpqvrENwRw3HBQepbTGZCJMm3GkuLTr3nD3cRezJeY=; b=rsdrxstzfp8kZCqg6mYYwafcfd S3kWRWo/yh3FWG/A3w0dTkGbNBcVAzrUTXlmSo2N8XXhEX3kddKx6MW+pdO1joil0Mc7XEiu46Yuh b2wSuO+WbPYyNr70EXJuqIJPyI1e9zGrCWoK4qdj7Yj9d7FRl5AaHIx/oelwj60iG2JD5bstvt2HL rdfeNkKi+1B8rNliiQKsXG+hfjD+99gxYOxpTkS3VzT4GZ1WlZTJRRwCSB5wdoauJribsb86cIAYs TiUzBoO7XizQXeSNJN9iPasmv8S5AzeKudnKp+1D/b2arVYRESESEe126tE1xNz2HJXhkT75rkyof CzT/z8MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPdUc-0000000EUaI-0Tpz; Sat, 07 Nov 2026 10:17:50 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPdU2-0000000ETkh-23Fk for linux-amlogic@bombadil.infradead.org; Sat, 07 Nov 2026 10:17:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=qfP62W4d274H4KIf4XZuVTstlQD2a+OvnHofuZlNZwo=; b=nrVXexCCM9CRFt+92Za/gwOIiM sGCOSyaE9STxrNjGQrvyneEgXBJ77osBDk/vfixSRrquzaOEed/6rhR+1ZRiECze9ZjV+X+RS1p3k ga5B5ScLt0/ptYtyFb/n938YAVzP1WwjCcHihnZWPRSpipnnnWk2kLzPzUcV4Vfq6mzZHuxfNum4Z Q4EAKLXYphRvOrF5dG+keBbyNqknTNwRr2yCFSnNb90eOTLMGCm4ytc8yvHf/3r/PeSJaehOeto/O jru6Yd+nBksUAUS3V0wAkFYJcl5pLrSB3g9DTLUfoeXbOtyU+vJzK0MdmOWyz0np84GbzUIreI92j pzFhQMDg==; Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]) by desiato.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPdTy-000000057pq-18CY for linux-amlogic@lists.infradead.org; Sat, 07 Nov 2026 10:17:13 +0000 Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-823e4047037so955632a34.2 for ; Sat, 07 Nov 2026 02:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794046628; x=1794651428; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qfP62W4d274H4KIf4XZuVTstlQD2a+OvnHofuZlNZwo=; b=XFL5IdKcVsU3c+QH9ujpkjkNlcDSN954J31txZN2jK+XI03ztYaftEp+QWgvuvl2pF 8/8aCrGBI1KzisShrS7h8qxPsbfslc6x50uxngnsUWjfyFq0fzDB8Z0cupOhSnfb/fra CvKb3hIMSOULeifa6Ur6PW/Z1+EhAIPrbHRbJJx9UbDwOgB8eLrw7rHY5I0+AkXVcbFB HfLG1VVakxZw08/ngMqRqsotFYxFuFxdFglTAPE6MUWIZSTZam5P7I3xMlhzXRnjSpSR q0a/Ozcd12Etk269/Bxv7UQ0fRF7rzUkl9B/bxRJhwDQxdepOdrDzHagD6U/TliSO5z0 PWzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794046628; x=1794651428; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qfP62W4d274H4KIf4XZuVTstlQD2a+OvnHofuZlNZwo=; b=PDfAFvNXHFj/1rMSpHOa0G3DfLg25NLONen13HxjcBqkx/8WfP6ZuH7Q7JlIPui5ih N7ExwH6SloJxXXRytx9+qKcU9NGnfKL7X7A3oop6n5746D5OkcQmTdR5Lgr+U2E5Cbkr 40HGzdQYC9eJA5d1iGmA85kenyZaLKHUEQ14PrAAy6BJSoNym/akZD7RiaEJQ79P+mEI qAVTmOkxhoLpuDMce3o4NlAr4h0Ej0uCWxb4FASKyzGrvgywIMXg5rfGWmnho+CMjkEy Mm/6ZAO+JnRikJi5r0/nruEfln6yq9wCk0+TpQerdTTEB3dtWYklbuILneJCVUZmLuvw /mrQ== X-Forwarded-Encrypted: i=1; AKwUvBwhNkhaUymu0hGkKHr279MIbFiyaWO2pPr2JfkoHsUNmtCmHck5r1n3neNEnK4HzRfHMUPio74BZ+4FPECl@lists.infradead.org X-Gm-Message-State: APuU4Z/7GHyGTDbXMqgBb8MCiSMtneSasCiJKbZAaz+Hlu4atEhR0iIa 3l21cPWE090DqFM28mfwaDF2MmC/1dqrME0MwFSxtgxepCae17vMT846 X-Gm-Gg: AYBFou0HYWFJFMq/jeZZSx3rsPuGRC7vQniquzKHskRtxWAkRgEQbp0/ggDrONsioCw wWrOKLt+C/r2UU0UrbNXhjcraX1hvrxBCmCxXjhDWdbD7/qGIXlj/LwE1cQF7w/NiyCyLXK+DaC YhXs+s/5lH0gaPwO0z/rXq60aHZqObB9UbhN1RdExWQ0N6PJKkMK5ASUK5y59XAW7JywJU/qkPJ zrvUAaZTaOFVPKjx5bTN9uJOMPHq3+f8p+pOK5A8Tvx/C7cMyb10FE9QS3QQkxuQ/GbxJF5H4vt VR6w25ivKKYQIl2F2W+f0IOMXL512hOaqp/BT4fEtx2o0z2NWjkz6lxdJump8M8jHFoEc0iUU3h zEvvUQ5J4fJxXVBf77heG0rQu5S57PvGT/6snFsFm5eCrTtXuY0dMtoOfLTB8i969vbDF0wLKd7 3M8A2eb2IS5zhn9RFvjFMODJJFNZ/aUFY+7ufgTU6ApHhJxtsE7uS6AhILbEk0xNpEvO5D3ML35 +ezg4sotBAzW8RRSlu29lg5o1nXo6XfPzj3T940tO/L6k1+SmCcYW0481ESAG+xfx6bHkGrvfBZ GDW1Yunw1dXvk1px9xTWbsJtGzFPcOesgAWoaV8LredQC2ZbOuWgoz4FZ4T8eSBR2BU4m+c5eox HTwfi/j+QMmp6GG19XMKOUVkS516vqIxcbWXpd31ntfUtZsUjxtI+xwCLm0xZZyDiekLw0BKWwT ApzXIGmYU9H5FvsvghDGbskMdhcl3p52Eaz+EOnnApDqRf+6ARqXko X-Received: by 2002:a05:6830:410e:b0:844:ec25:c7f2 with SMTP id 46e09a7af769-85f1cfdc445mr4024752a34.13.1794046627839; Sat, 07 Nov 2026 02:17:07 -0800 (PST) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-85f1dbef224sm3990269a34.12.2026.11.07.02.17.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2026 02:17:07 -0800 (PST) From: James Hilliard Date: Sat, 07 Nov 2026 03:16:12 -0700 Subject: [PATCH 15/58] mtd: rawnand: tegra: retain open-handle state on removal X-Archived-By: MIME-Version: 1.0 Message-Id: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-15-0181ef0cc4c8@gmail.com> References: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> In-Reply-To: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Brian Norris , Boris Brezillon , Arseniy Krasnov , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thomas Gleixner , Vitaly Wool , David Woodhouse , Russell King , David Woodhouse , Mike Rapoport , Maxime Coquelin , Alexandre Torgue , Christophe Kerello , Jason Roberts , Michal Simek , Boris Brezillon , Mason Yang , Ramuthevar Vadivel Murugan , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Dmitry Osipenko , Matthias Brugger , AngeloGioacchino Del Regno , Jorge Ramirez-Ortiz , Heiko Stuebner , Yifeng Zhao , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Keguang Zhang , Jacky Huang , Shan-Chun Hung , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Liang Yang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Manivannan Sadhasivam , Kamal Dasu , Broadcom internal kernel review list , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Cercueil , Harvey Hunt , Maxim Levitsky , Michael Walle , Srinivas Kandagatla Cc: Tze Yee Ng , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_101710_243217_1A7A096F X-CRM114-Status: GOOD ( 16.90 ) X-Spam-Score: 0.1 (/) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Retain the chip and controller allocations until their final MTD references are released. Disconnect the chip before suspending the controller so retained handles cannot reach powered-down hardware. Leave metadata cleanup to the final put, including registration-failure unwinding. Fixes: d7d9f8ec77fe ("mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver") Signed-off-by: James Hilliard --- drivers/mtd/nand/raw/tegra_nand.c | 37 ++++++++++++++++++++++++++++++------- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/raw/tegra_nand.c b/drivers/mtd/nand/raw/tegra_nand.c index 7f9eb5f042a7..da7791741b9d 100644 --- a/drivers/mtd/nand/raw/tegra_nand.c +++ b/drivers/mtd/nand/raw/tegra_nand.c @@ -1064,6 +1064,11 @@ static const struct nand_controller_ops tegra_nand_controller_ops = { .setup_interface = tegra_nand_setup_interface, }; +static void tegra_nand_chip_release(struct nand_chip *chip) +{ + kfree(container_of(chip, struct tegra_nand_chip, chip)); +} + static int tegra_nand_chips_init(struct device *dev, struct tegra_nand_controller *ctrl) { @@ -1096,7 +1101,7 @@ static int tegra_nand_chips_init(struct device *dev, return ret; } - nand = devm_kzalloc(dev, sizeof(*nand), GFP_KERNEL); + nand = kzalloc_obj(*nand); if (!nand) return -ENOMEM; @@ -1107,7 +1112,7 @@ static int tegra_nand_chips_init(struct device *dev, if (IS_ERR(nand->wp_gpio)) { ret = PTR_ERR(nand->wp_gpio); dev_err(dev, "Failed to request WP GPIO: %d\n", ret); - return ret; + goto free_chip; } chip = &nand->chip; @@ -1127,20 +1132,35 @@ static int tegra_nand_chips_init(struct device *dev, ret = nand_scan(chip, 1); if (ret) - return ret; + goto free_chip; mtd_ooblayout_ecc(mtd, 0, &nand->ecc); + ret = nand_set_release(chip, tegra_nand_chip_release); + if (ret) { + nand_cleanup(chip); + goto free_chip; + } ret = mtd_device_register(mtd, NULL, 0); if (ret) { dev_err(dev, "Failed to register mtd device: %d\n", ret); - nand_cleanup(chip); + nand_disconnect(chip); + mtd_put_master(mtd); return ret; } ctrl->chip = chip; return 0; + +free_chip: + kfree(nand); + return ret; +} + +static void tegra_nand_release(struct nand_controller *controller) +{ + kfree(container_of(controller, struct tegra_nand_controller, controller)); } static int tegra_nand_probe(struct platform_device *pdev) @@ -1149,13 +1169,15 @@ static int tegra_nand_probe(struct platform_device *pdev) struct tegra_nand_controller *ctrl; int err = 0; - ctrl = devm_kzalloc(&pdev->dev, sizeof(*ctrl), GFP_KERNEL); + ctrl = kzalloc_obj(*ctrl); if (!ctrl) return -ENOMEM; + err = devm_nand_controller_init(&pdev->dev, &ctrl->controller, tegra_nand_release); + if (err) + return err; ctrl->dev = &pdev->dev; platform_set_drvdata(pdev, ctrl); - nand_controller_init(&ctrl->controller); ctrl->controller.ops = &tegra_nand_controller_ops; ctrl->regs = devm_platform_ioremap_resource(pdev, 0); @@ -1232,10 +1254,11 @@ static void tegra_nand_remove(struct platform_device *pdev) WARN_ON(mtd_device_unregister(mtd)); - nand_cleanup(chip); + nand_disconnect(chip); pm_runtime_put_sync_suspend(ctrl->dev); pm_runtime_force_suspend(ctrl->dev); + mtd_put_master(mtd); } static int __maybe_unused tegra_nand_runtime_resume(struct device *dev) -- 2.53.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic