From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89D2C606A331 for ; Sat, 7 Nov 2026 20:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=UtfWB1jH; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=m29a8utw DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=/a9mIwWKNfkF7UHmx3WyfT0OcKRpLn+MHZQxIL40tEw=; b=UtfWB1jHRb293XtDJX0fKEFt/T Q45DU92lJWyetS0vj9+5wD7feIegAbE++l7ZsGzbLmBteKIna8av28MGxybFh9snOIIaIq59TE9iV rv7IwO8M0amdPY/ZCrfxE6GvfTQJDFGIV4tDL82+tAqe2vazkZ7TFKaqwknQc+wQakb8Gukavtmdx cMvpVIKMi5To0NfylJjf+6QcQtq3TJH1kova0GiuiZG/bbBdf2mIhRke6Lawk/fgK845f3s4ZOf6l UPGaHKLbnn6NKKByA2ZaZyYHwPu+ojcZZIoCXdJ67zYi2mmLTuR3C4MDurwaf5y+jG9hHiAlzv3TJ NqfKqXLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPmnU-0000000FIqI-3gZQ; Sat, 07 Nov 2026 20:13:56 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPmnK-0000000FIUc-20Ox for linux-amlogic@bombadil.infradead.org; Sat, 07 Nov 2026 20:13:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=JrxepS2J9VPceqdGkgV52/qe1YoRSs0JHMfO/RKE6Vo=; b=m29a8utwaelA6KCUxepqeBAP7k fTzK2wAJyk5bKy5DtXdzP6fH1+Cwb+p3oKDvthSSjk6cSh1TtedOg2Wea/+rWtDOy3hVIgNlAvtW8 vDqOYPazjwvLv2zNRtWfy4jV2R8gFlj7YaW85fp29a3GhpVRPfzRGvbpe5MsU4TYpM5+2FXSOfbTU MKbCo7KWiK9JyfcWWgMvmolVhMfQZ8Iq9QAMJ5HeTeWdVsVYUliMEXx2cE8dprC5LsYpkcD8y7mYS bfg5f7Df82tgjJNDLXLgZ+V68XGsktypmD4agAn5kg7/fCdseA67D2v6JcNQLRzTUxfsatj8EfcuB vMI5jePg==; Received: from mail-oo1-f44.google.com ([209.85.161.44]) by desiato.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPmnC-00000005Qet-1onJ for linux-amlogic@lists.infradead.org; Sat, 07 Nov 2026 20:13:43 +0000 Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-6fe4372c5f3so1057792eaf.3 for ; Sat, 07 Nov 2026 12:13:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794082416; x=1794687216; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JrxepS2J9VPceqdGkgV52/qe1YoRSs0JHMfO/RKE6Vo=; b=dLjTBFE6HPYdQ42LFlCOvpKfOMZwC+8dLWlQar/1jhEqutCzjeYBrqXsncG0z3F2+G olR7HNVCgAJL45hcHqhybXDu298m0+tnqkxO66ugtuWXFlTnXsVhh16CDOwStN2FHLio XCmA/4FiIyBzJWz3utgaGYX+tG23OVh1BPHOwI77G7MgqoZG/ycljdLfl3M98CbpJh5v nDDgCrgXXKoKijOqZo3MogbxyonUwFjuwFQ7rDOJtFZaVUEE4rQpPD2wrwcEZqjbkCp4 +D3s3V0rLkXqZY3VwD78j58/MCrFkCIKKAtY83yNkdvHLxVdFzxMY3P0qtKAfKkoLQIr qMdw== X-Forwarded-Encrypted: i=1; AKwUvBzQKjWDKH6fVEm38lm94bi8IhQS/2lWsKlibVvFosFWmbDMq4vcR66bLpOgesGgzxVKmO/lyiGbGhJ9f9iB@lists.infradead.org X-Gm-Message-State: APuU4Z9lZiumeEpSNJeGGIxhECKsM3kXk814FBjF/p5DAI9utd3BQlB0 2skZiz0nKYXdguCp+TXm2wGykV4pXc87KmAR3X38cNsZGNXF0rxNOqvniybi0bN86t8= X-Gm-Gg: AYBFou2POQyz/BRLUMJdSI/OdeoDA1YV9P6oS/FT/zFUrm0+JUeizm4TIwTc3eOXq0F +LDqqlieD5Bh+5wcuMo9TtCwmwhbweE5UpR19kAsly7jrihmtqLEOiibkWVmFMDKjXPu8+dRURg 3Ywu4nRSdrS+jDneZCtHKhhAye85YCoWYwmrRM4+SrK3vgUvDkr8Qsgm5rL4xyJFeTM06QBPCkz gowDafeibdXSvYPPMefFF0LwXJB/QyvpFWc7AeSjoUpoA0X24qHwGO1KRAqEKYSJbfRbTB6czeR GisjNgQIXnE/5f4RlLFmAgXwmqp4phicqF4X3TlroizTqJwrpa1XgY1yLJeqb8UDTYHBQ1IxMEB BImHpckOL0PzPwacC21wgdu/g8sQsa6zNVEAIbjihMfhbOuGxbldcozDNOJ5AySKfJseyL3fy5r qP8ri1yL+kPiDJYvrEPSp7qYYzfhSMazwggkFIfva8G/24OopVKNpFjTVMIPBhhZEiOrb0Hm3JR aCGozW1c+m8/SycqBahIrD3ImYiQbltS5ijeaIv4K7VV5mpAKdMYWHB7kZ7stJ3WqsK3U6GiQTU oxbjKGu0lE2SPuUZAseR6gjV+iAMU/c8fY1940aWUs4CIRWqMMeanT4SWgL6 X-Received: by 2002:a05:6820:60b:b0:6b7:46fa:1693 with SMTP id 006d021491bc7-7170f2e8271mr15281eaf.40.1794082416544; Sat, 07 Nov 2026 12:13:36 -0800 (PST) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4ade68aa561sm226096fac.5.2026.11.07.12.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2026 12:13:36 -0800 (PST) From: James Hilliard Date: Sat, 07 Nov 2026 03:16:39 -0700 Subject: [PATCH 42/58] mtd: rawnand: au1550nd: retain chip state across removal X-Archived-By: MIME-Version: 1.0 Message-Id: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-42-0181ef0cc4c8@gmail.com> References: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> In-Reply-To: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Brian Norris , Boris Brezillon , Arseniy Krasnov , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thomas Gleixner , Vitaly Wool , David Woodhouse , Russell King , David Woodhouse , Mike Rapoport , Maxime Coquelin , Alexandre Torgue , Christophe Kerello , Jason Roberts , Michal Simek , Boris Brezillon , Mason Yang , Ramuthevar Vadivel Murugan , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Dmitry Osipenko , Matthias Brugger , AngeloGioacchino Del Regno , Jorge Ramirez-Ortiz , Heiko Stuebner , Yifeng Zhao , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Keguang Zhang , Jacky Huang , Shan-Chun Hung , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Liang Yang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Manivannan Sadhasivam , Kamal Dasu , Broadcom internal kernel review list , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Cercueil , Harvey Hunt , Maxim Levitsky , Michael Walle , Srinivas Kandagatla Cc: Tze Yee Ng , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_201341_986048_5A264082 X-CRM114-Status: GOOD ( 16.72 ) X-Spam-Score: 3.5 (+++) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Drain NAND access before unmapping the chip-select window, and retain the chip and controller until the final MTD reference is released. Check MTD registration errors so unsuccessful publication releases the same ownership. Signed-off-by: James Hilliard --- drivers/mtd/nand/raw/au1550nd.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/nand/raw/au1550nd.c b/drivers/mtd/nand/raw/au1550nd.c index f1e99197ab84..bd78bcc84282 100644 --- a/drivers/mtd/nand/raw/au1550nd.c +++ b/drivers/mtd/nand/raw/au1550nd.c @@ -251,6 +251,11 @@ static const struct nand_controller_ops au1550nd_ops = { .attach_chip = au1550nd_attach_chip, }; +static void au1550nd_release(struct nand_controller *controller) +{ + kfree(container_of(controller, struct au1550nd_ctx, controller)); +} + static int au1550nd_probe(struct platform_device *pdev) { struct au1550nd_platdata *pd; @@ -269,6 +274,9 @@ static int au1550nd_probe(struct platform_device *pdev) ctx = kzalloc_obj(*ctx); if (!ctx) return -ENOMEM; + ret = devm_nand_controller_init(&pdev->dev, &ctx->controller, au1550nd_release); + if (ret) + return ret; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!r) { @@ -302,7 +310,6 @@ static int au1550nd_probe(struct platform_device *pdev) } ctx->cs = cs; - nand_controller_init(&ctx->controller); ctx->controller.ops = &au1550nd_ops; this->controller = &ctx->controller; @@ -322,7 +329,17 @@ static int au1550nd_probe(struct platform_device *pdev) goto out3; } - mtd_device_register(mtd, pd->parts, pd->num_parts); + ret = nand_set_release(this, NULL); + if (ret) { + nand_cleanup(this); + goto out3; + } + ret = mtd_device_register(mtd, pd->parts, pd->num_parts); + if (ret) { + nand_disconnect(this); + mtd_put_master(mtd); + goto out3; + } platform_set_drvdata(pdev, ctx); @@ -333,7 +350,6 @@ static int au1550nd_probe(struct platform_device *pdev) out2: release_mem_region(r->start, resource_size(r)); out1: - kfree(ctx); return ret; } @@ -346,10 +362,10 @@ static void au1550nd_remove(struct platform_device *pdev) ret = mtd_device_unregister(nand_to_mtd(chip)); WARN_ON(ret); - nand_cleanup(chip); + nand_disconnect(chip); iounmap(ctx->base); release_mem_region(r->start, 0x1000); - kfree(ctx); + mtd_put_master(nand_to_mtd(chip)); } static struct platform_driver au1550nd_driver = { -- 2.53.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic