From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD046082BC9 for ; Sat, 7 Nov 2026 20:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=h4bUZgvG DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=CjzxggmLEYsjRm7AjPk1VTyG/F7IWOUbOB1udi5WZOI=; b=h4bUZgvGo+SxWTsDtshFB5+8hC X1mYJsqlgmEt4cfZpKgUy1t7WsaMJKbhLtwXt6GQTCGUvjPC7aenvkWU9f33+v2e76nsE6EQVW+p9 i1rr0yngHERRnrV2UFjewCVXmXoKS5B4kytdBAqWofnf+wOqdG/fK6hC1MYWnIcntjZmiZWnuV82L RchBiH/bZBJxGl+v8fQp63E1Xg1kQZadsfBaWf1sLlMxr6Z5P1Sd9U2NAEe5C4TwsIoUVd3VUFHTw 1rtlCJWaQrUwqUO0q67t5BJdf82InNZlDQvGgXmdOIdWxf8bsU8t9pUKQPd1XJUt5u3DO8Scj53Wj e2FpR3hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPmnT-0000000FInU-29s7; Sat, 07 Nov 2026 20:13:55 +0000 Received: from mail-oa1-f45.google.com ([209.85.160.45]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPmnE-0000000FIIx-363B for linux-amlogic@lists.infradead.org; Sat, 07 Nov 2026 20:13:45 +0000 Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-43bf9548df4so20297fac.0 for ; Sat, 07 Nov 2026 12:13:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794082420; x=1794687220; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oX/04PSyv+m9ZWIAwPwysaJo9a7lukovrgxtc3xymbg=; b=AUC13MusBAoY9KMHCFPDc7fcpMKOuRHw9hwXQJh2ijUYPEyijhqPH+dsRgrPNpaUvy DA37uqd98m5qBGQGnIoCSy4rmWGVnY72w8BN7hdjMkjrQ8CWZ0/+p4VJinYSTmNVnoQj O6OYdlxCkIWgR6sr4djK3hOhyx6HXH+6YLLswpkb6F0e8PRyAOeezylvWI3kbI5JhOlT ZorGTilw4OfmI96WwPtx52EBxJHF5QFaughsT3ti7UPKeliiRucuf7ZtL3jFDqM8fMxJ KcZCRCuPg9thbMZaKbtF80uMoDPInJ+nHwVr4Lu+jaAG+DpVa05e02E1+btvgBTAK3z0 JY4g== X-Forwarded-Encrypted: i=1; AKwUvByKTSJqjajbjn7JRQHNJU1r5AzdOMhc0tAksiM5pSJ7xo9C3j8ezA1XmvXw9qOHAg/UCmu7FcR1mswTlGrl@lists.infradead.org X-Gm-Message-State: APuU4Z/P9SRVXkY8xMmEFufj+/bPi8SgIZQ6zmQpElEWaw0BCq/MveVm 1FTTehL1MwbnRXOEvs7hvAVg5o3SHsakIv4WniB8QmXR3Vq99a6LMG9CecS5COcgSRI= X-Gm-Gg: AYBFou05fJO4HWEJ7OoOf1VYO/2CGSHJKseYn/npA8kVV74eWg7Nw8avN4EV2IW+8Kb yYE4RbkqMdLWhlPsAzvGhBmyqNxOe4G+tql9t/YywkEMjdmqnFzWPbQaC3djhzep2JHQ6/guuZG Gju0Jn/amgwHCGItndz1IveDKIZBko6xVZJmAtiTZHDhKuBVVCBsp40FKTLWzS3vfBBvLyC/Cfc PDwxW/CCGhVtKPAVHAClU1n3rKZp8XTVpxbP8cG+7zzlCC0NXsFdFcD7XUbWzz4lOPhxVjFHXJ0 NXvVDT27GKFDZo1UWlqnIRTUgdUnfaONEIsikk/icRe4ZxwOknEVgGO+QtFD1m9IYRfFKM9xcxL 9Nq7suPBcpc2MT5hwxNuuBu6zlzscfXxCrZe/jb7oKbpIve3m0NIRgc1RD06+DkIjhfaa06SbLA uG9JBH09PEOs21n5C9swNWixUQ7UjJkz/LeGVvAQMTVbphfuYES1KHS2qCO9Gk7Aqebzu9PY7TE CnkVY/k22eeWLvvGkuvPr20cXpMysNhFdxakIt0IbtUIg839OftmJw5wdH8C4CrODJSUjKJQsvE +ysC1IBvNjj3qy7jOZqNnCNUZASwNqWaRGhpH9Gnzd0+uF2ghctFjOWSKHvg X-Received: by 2002:a05:6870:d394:b0:4ad:8124:9235 with SMTP id 586e51a60fabf-4ad9881005emr3579674fac.9.1794082419546; Sat, 07 Nov 2026 12:13:39 -0800 (PST) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4ade68aa561sm226096fac.5.2026.11.07.12.13.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2026 12:13:38 -0800 (PST) From: James Hilliard Date: Sat, 07 Nov 2026 03:16:40 -0700 Subject: [PATCH 43/58] mtd: rawnand: sharpsl: retain chip state across removal X-Archived-By: MIME-Version: 1.0 Message-Id: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-43-0181ef0cc4c8@gmail.com> References: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> In-Reply-To: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Brian Norris , Boris Brezillon , Arseniy Krasnov , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thomas Gleixner , Vitaly Wool , David Woodhouse , Russell King , David Woodhouse , Mike Rapoport , Maxime Coquelin , Alexandre Torgue , Christophe Kerello , Jason Roberts , Michal Simek , Boris Brezillon , Mason Yang , Ramuthevar Vadivel Murugan , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Dmitry Osipenko , Matthias Brugger , AngeloGioacchino Del Regno , Jorge Ramirez-Ortiz , Heiko Stuebner , Yifeng Zhao , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Keguang Zhang , Jacky Huang , Shan-Chun Hung , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Liang Yang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Manivannan Sadhasivam , Kamal Dasu , Broadcom internal kernel review list , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Cercueil , Harvey Hunt , Maxim Levitsky , Michael Walle , Srinivas Kandagatla Cc: Tze Yee Ng , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_121341_348747_F22DAD19 X-CRM114-Status: GOOD ( 17.47 ) X-Spam-Score: 1.7 (+) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Separate chip-select unmapping from chip storage reclamation. Outstanding MTD references retain the scanned chip and layout metadata after removal; new hardware operations fail once the chip is disconnected. Signed-off-by: James Hilliard --- drivers/mtd/nand/raw/sharpsl.c | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/raw/sharpsl.c b/drivers/mtd/nand/raw/sharpsl.c index 4154ab74f169..1ffd2b210d20 100644 --- a/drivers/mtd/nand/raw/sharpsl.c +++ b/drivers/mtd/nand/raw/sharpsl.c @@ -114,6 +114,11 @@ static const struct nand_controller_ops sharpsl_ops = { .attach_chip = sharpsl_attach_chip, }; +static void sharpsl_nand_release(struct nand_controller *controller) +{ + kfree(container_of(controller, struct sharpsl_nand, controller)); +} + /* * Main initialization routine */ @@ -135,6 +140,9 @@ static int sharpsl_nand_probe(struct platform_device *pdev) sharpsl = kzalloc_obj(struct sharpsl_nand); if (!sharpsl) return -ENOMEM; + err = devm_nand_controller_init(&pdev->dev, &sharpsl->controller, sharpsl_nand_release); + if (err) + return err; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!r) { @@ -154,7 +162,6 @@ static int sharpsl_nand_probe(struct platform_device *pdev) /* Get pointer to private data */ this = (struct nand_chip *)(&sharpsl->chip); - nand_controller_init(&sharpsl->controller); sharpsl->controller.ops = &sharpsl_ops; this->controller = &sharpsl->controller; @@ -188,10 +195,16 @@ static int sharpsl_nand_probe(struct platform_device *pdev) /* Register the partitions */ mtd->name = "sharpsl-nand"; - err = mtd_device_parse_register(mtd, data->part_parsers, NULL, - data->partitions, data->nr_partitions); + err = nand_set_release(this, NULL); if (err) goto err_add; + err = mtd_device_parse_register(mtd, data->part_parsers, NULL, + data->partitions, data->nr_partitions); + if (err) { + nand_disconnect(this); + mtd_put_master(mtd); + goto err_scan; + } /* Return happy */ return 0; @@ -203,7 +216,6 @@ static int sharpsl_nand_probe(struct platform_device *pdev) iounmap(sharpsl->io); err_ioremap: err_get_res: - kfree(sharpsl); return err; } @@ -221,12 +233,11 @@ static void sharpsl_nand_remove(struct platform_device *pdev) WARN_ON(ret); /* Release resources */ - nand_cleanup(chip); + nand_disconnect(chip); iounmap(sharpsl->io); - /* Free the driver's structure */ - kfree(sharpsl); + mtd_put_master(nand_to_mtd(chip)); } static struct platform_driver sharpsl_nand_driver = { -- 2.53.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic