From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDA9B606A32C for ; Sat, 7 Nov 2026 20:13:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=DqGRvbMm; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=DEmJD8OD DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=DjPSvc39YIlpFJvFnwfDeb9pzpOPpc48J4h2NW8d92M=; b=DqGRvbMmiP/+mm31OpE2icEFi8 ZDHzcYgelxJP40GPZOIbnFYxo+1Obn3aHYHhgzmRDvafBwAovh9GiglE4sgiQVaFVZqMJfqiHtMYr jcQcnvQGnorRYg2WNgUDW4EJ1u92rl3z2CwT0jMdoLa9B44hUGbj7ZRT3Mk4JF2jnEfKxy/AQTCaV LO6C3L4koZDyjWuucFtT5xHRq92nrrELmJOYZAXKwx4I+o/9rjyt3c4hePkFq3J/e5IaA+9zWIQ2d Cf3NcN/nP0bbqCIUEJ4NrCuVQyyDRRWDNiHaZuTt5aZWTleRuGG5aEAuHvaaZ2zzDAn/Bfdc3PZ/9 zasQXzbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPmnW-0000000FItP-17X2; Sat, 07 Nov 2026 20:13:58 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPmnN-0000000FIZy-1emZ for linux-amlogic@bombadil.infradead.org; Sat, 07 Nov 2026 20:13:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=ORfgQ1dv5y4O+I8/uTd8VN7JdvvEiftmkqcbIimalQM=; b=DEmJD8ODZmhRK/FnO1q8UZuADx mIZVwD3I5Q77s5w34GTuiE1U6NDXc8pQs6YHxM3G2Pf4E1pn2FpgGfSQuZUE1d2sxRKegwtkI5833 WJ2Lu8rLQ5O+ku6GBqIaD/6xUN6nFnXAUpzTwHVmLy53i89/abuvHn3ReKRTSBfNnsekFJGMM8Ji/ MlH79zQaJPxHW+OZdgS4bbs2KJGPFg++KVzLNTMkWI70OBiWLtqVulhIRmSnBwJxvxtah++m+Avl9 jk/Y8nMp5M2Nq/7r50yluR/QkEy8HLC/mM7dalTHQxWztB9zEhyN9vIGBcDg+jYOdeLT0m5APnRWY d0W7VyvA==; Received: from mail-oa1-f46.google.com ([209.85.160.46]) by desiato.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPmnI-00000005QhL-36nh for linux-amlogic@lists.infradead.org; Sat, 07 Nov 2026 20:13:48 +0000 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-4911df1e196so3575fac.1 for ; Sat, 07 Nov 2026 12:13:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794082422; x=1794687222; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ORfgQ1dv5y4O+I8/uTd8VN7JdvvEiftmkqcbIimalQM=; b=1mL3aetfPBgF+gd+PRpBaVBcJxMIbTNnFvVcb8OQUJwdRDzzHNmgiKV7t+3SXa72n+ v5h1DXrIWWLCmhRqDwmh0IRaNweVmX00i98Nx33vMGhI8ih4WdtznW06vL68UFEVPJ1Q cPT8O9y0U3dT3Z7GODc37RgHjj3mnvE3IKABAgKGdAX4AMfR2zXtebZv6TnF4UoA7J6W emubP2APzcL6qEAc0/QvjerRurFhXaEgwBSoAP9hH82UeRGab+2JRNAcivzUbUHEVVuB diciCPwMEeZPubcQ6NMSRLDz3Nek4upmFPdjM6XxxeIP3G2vGsRFz22FdvL12iBVhWvA oVkg== X-Forwarded-Encrypted: i=1; AKwUvBwFShY6M5wh7SH3P/qyS+dus1XDoj/MUT4UHONBAlnny+bEOmXpUKXNO76B+s9aCHeHKomx9eb/VHJ+HcIw@lists.infradead.org X-Gm-Message-State: APuU4Z+E7pSI0sUqUYj2umEvkf8msFn3sBO0walv+c4ED9CyrfcsmoQj KHvavy3wCDfuVL3pBqUyxRpiJgnfn4r+VpWpy8k8uqHNdKGlt402a7uXGwBZJQ/svUo= X-Gm-Gg: AYBFou0UBCoGBY1D6G8yvdNZ70IaYOl22NqdfyWpq3VF29E1vBSrthkm1eOyclvvNF6 QRGvvXL2G/ZGbChnBvEAXv8EGR9gNjDPyNx3YNqVffS6eJ1ek//v6iiphxvb0omDxM8Iorkeh1B UaBZEVrIYqFw9Qe5+9quL1uRYoluiqxGa9xoEjN51wz5R9J/EVj9ycxPpA0fs5FS1GDX9awK3is gV1bg6ldki8+UMMstgvPxJ7naf5waO1xRdbT5T+Iuf2U721dCypzzqrimTrb45ngSpLdSKlixlE U2OddwuMYMi3gBqMPdzqUK9BTfqG6GSzvbONsD52Ns6gyTqp2WQEDmtMz7buW9MSA/cI8rP2G5w arKIdL7ENO7zBW5+9fj88wLDHBepgia/uwshkgb5zPkHUawVZbF/EKnU+/OXdnvsKSatcHiAb3L bsxArP1sxyUxO/Qj9Y2Z//JwnxOMKqjczoQrMHfEnT+f09Osft7HM9qMLyTxPVSy28OfunnO3SZ a+1fQpIeCpQWqwk8dqGaShDU8h/HO8gUNC9VHhWuN/QXLlRLvjmUfOFXqV0l7ZiEgSujX/64PP4 ho/Y/0UVQEDO2o4v8gB22qODrcffIXfZLBZPc+21ffRb9W8XBPRcbCX9KOKB X-Received: by 2002:a05:6808:670d:b0:564:5fe0:dd60 with SMTP id 5614622812f47-567e0997194mr5082140b6e.9.1794082422526; Sat, 07 Nov 2026 12:13:42 -0800 (PST) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4ade68aa561sm226096fac.5.2026.11.07.12.13.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2026 12:13:42 -0800 (PST) From: James Hilliard Date: Sat, 07 Nov 2026 03:16:41 -0700 Subject: [PATCH 44/58] mtd: rawnand: davinci: retain chip state across removal X-Archived-By: MIME-Version: 1.0 Message-Id: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-44-0181ef0cc4c8@gmail.com> References: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> In-Reply-To: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Brian Norris , Boris Brezillon , Arseniy Krasnov , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thomas Gleixner , Vitaly Wool , David Woodhouse , Russell King , David Woodhouse , Mike Rapoport , Maxime Coquelin , Alexandre Torgue , Christophe Kerello , Jason Roberts , Michal Simek , Boris Brezillon , Mason Yang , Ramuthevar Vadivel Murugan , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Dmitry Osipenko , Matthias Brugger , AngeloGioacchino Del Regno , Jorge Ramirez-Ortiz , Heiko Stuebner , Yifeng Zhao , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Keguang Zhang , Jacky Huang , Shan-Chun Hung , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Liang Yang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Manivannan Sadhasivam , Kamal Dasu , Broadcom internal kernel review list , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Cercueil , Harvey Hunt , Maxim Levitsky , Michael Walle , Srinivas Kandagatla Cc: Tze Yee Ng , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_201345_501762_2A36D202 X-CRM114-Status: GOOD ( 18.30 ) X-Spam-Score: 3.5 (+++) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Disconnect the chip before releasing the shared four-bit ECC engine. Retain the chip and controller while MTD references remain, with final NAND cleanup independent of the device-managed hardware resources. Signed-off-by: James Hilliard --- drivers/mtd/nand/raw/davinci_nand.c | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c index 3986553881d0..2231e6a45114 100644 --- a/drivers/mtd/nand/raw/davinci_nand.c +++ b/drivers/mtd/nand/raw/davinci_nand.c @@ -895,6 +895,11 @@ static const struct nand_controller_ops davinci_nand_controller_ops = { .setup_interface = davinci_nand_setup_interface, }; +static void nand_davinci_release(struct nand_controller *controller) +{ + kfree(container_of(controller, struct davinci_nand_info, controller)); +} + static int nand_davinci_probe(struct platform_device *pdev) { struct davinci_nand_pdata *pdata; @@ -919,9 +924,12 @@ static int nand_davinci_probe(struct platform_device *pdev) if (pdata->core_chipsel > 3) return -ENODEV; - info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); + info = kzalloc_obj(*info); if (!info) return -ENOMEM; + ret = devm_nand_controller_init(&pdev->dev, &info->controller, nand_davinci_release); + if (ret) + return ret; platform_set_drvdata(pdev, info); @@ -986,7 +994,6 @@ static int nand_davinci_probe(struct platform_device *pdev) spin_unlock_irq(&davinci_nand_lock); /* Scan to find existence of the device(s) */ - nand_controller_init(&info->controller); info->controller.ops = &davinci_nand_controller_ops; info->chip.controller = &info->controller; ret = nand_scan(&info->chip, pdata->mask_chipsel ? 2 : 1); @@ -995,12 +1002,18 @@ static int nand_davinci_probe(struct platform_device *pdev) return ret; } + ret = nand_set_release(&info->chip, NULL); + if (ret) + goto err_cleanup_nand; if (pdata->parts) ret = mtd_device_register(mtd, pdata->parts, pdata->nr_parts); else ret = mtd_device_register(mtd, NULL, 0); - if (ret < 0) - goto err_cleanup_nand; + if (ret < 0) { + nand_disconnect(&info->chip); + mtd_put_master(mtd); + return ret; + } val = davinci_nand_readl(info, NRCSR_OFFSET); dev_info(&pdev->dev, "controller rev. %d.%d\n", @@ -1020,14 +1033,16 @@ static void nand_davinci_remove(struct platform_device *pdev) struct nand_chip *chip = &info->chip; int ret; + ret = mtd_device_unregister(nand_to_mtd(chip)); + WARN_ON(ret); + nand_disconnect(chip); + spin_lock_irq(&davinci_nand_lock); if (chip->ecc.placement == NAND_ECC_PLACEMENT_INTERLEAVED) ecc4_busy = false; spin_unlock_irq(&davinci_nand_lock); - ret = mtd_device_unregister(nand_to_mtd(chip)); - WARN_ON(ret); - nand_cleanup(chip); + mtd_put_master(nand_to_mtd(chip)); } static struct platform_driver nand_davinci_driver = { -- 2.53.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic