From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2B8E606D816 for ; Sat, 7 Nov 2026 20:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=4ZY8haMT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=6AvcpgA63DLO0RRGydhlv8qcjdhJHb2eM/oChz/ar1s=; b=4ZY8haMT3IhMsPYa5gtLli3EfT 1CNCmcirW5nk9SBsns5FLVaWqhuJBjHaoRv2cOPDeRdYa72jQHF/Nwfllf10lpUTyYdWn7MeLNsRz Q61LoG1fnGgAnD7eWrDvPfujBPK7RY5NH6x2sx9ugbd+wa0M24/bneFK/a2TPXn9cBY6s/MMHiwta kk/s1MvGAxCJkgCacAQPaYUvq8DnnxpQvaN3UoIvsAB8ixfyM6FNe72PEH3pbFdpu1d3p+BlvussV gOqgI/ji9SXvzqPE+4ribiy6VHOgC3wpSo4hIpBm8sT8ltPowbraZJgwz/Mu0B77+60iumfu/g8Hk RdhOMdzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPmo7-0000000FJtT-02Ah; Sat, 07 Nov 2026 20:14:35 +0000 Received: from mail-oa1-f43.google.com ([209.85.160.43]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPmnc-0000000FJ49-0k0I for linux-amlogic@lists.infradead.org; Sat, 07 Nov 2026 20:14:08 +0000 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-4adae187d94so3268fac.3 for ; Sat, 07 Nov 2026 12:14:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794082443; x=1794687243; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7Q5e5yIGTXK7xHQdIJMFEChTgYJAM4yLdAHkjKqEUeE=; b=FPWQ+9SUNj2LwVX87BZHHb1+pcAPx9gppce/TutatHUvQtvXKx15cUhItQFE6Nwp6g HJTGeMi6hw1Eipp1OPnbHTzR3+6lvDirhzMCjCRwChlMPxtXDEXnr7KvPFSW9eiagsv8 8oY4EzFJYpnQISkS6a/z40kRs1rSQjSDcheIMx3zE1OdQMlLOQJ3lKbNnOHWqLATzZm8 5V0dHkwFX7p2VbtvBIqCYzsk/jssia+dKSLQhJRHkojLSiqzo37Kw2eZEXZ0zlHfyCJ9 mIrrishpxu6BzS9390s6CA/ixdYoxT3Jlki1HzYnB6W8NMF0nWxSohs8aAluNbejsBi0 qGQA== X-Forwarded-Encrypted: i=1; AL+hErE++bWb1YFpiOGrhqsekFL4YFIAyq2oKn5hB0b+SqFRap6FEl6G+5+P3kzzlf4XABFKC1nE9inSZedRU7+d@lists.infradead.org X-Gm-Message-State: APuU4Z+GufBLv7iKjup4wRyjAz3lhmdIqmq8Q7Q28Wza6SWZC7v7m/w/ ASp6yyUFJshtqLTVjYIIcNKvR7WxfezRBZ4A8gWR3+D9CtcN8kmTo6auFfIq0/USBAM= X-Gm-Gg: AYBFou1i0rCSrcUbNFG3WIKJ0Tk7/nYTqdUBdjp1/HBjZUg3uYfKWakaFXNHWS1F6Yq 6vpeqXr1VYL402mkVHS0CFz9fvb8ZnvbLUcF3q+jHl/y/LSoKVGMDKjTF0SC/H9QoC1dVbQghRi 37XW1u8V9Fb1ce3e5j41YSCHGaUh4/Vt7TGkLX4DbelZU6ok6+NNcKdc+gSeZwntFYjVrf9GruU BqpA9mdpQAS6PVuqSg8gqRqinmQ3D8FJysK2t7pepjOPqxxHvlfM+910mRhiAcS9grhJsi71ey6 a3W6efz6bw9CfD296DXdW8AM42hgbPkrWGXt4rcHhNVhHbRWyfqX23LZMmZ/NTUc0sNEcbi4bnv ZQ+ymh/djgUoIk7yvh2BO4fCooCvQ2ZwikXKYmsufKTqodWyR8hZwBS5jgmY/Ftvti2IHiru+GF ftj3kKAWRhh7MarWO9hWi2y+hgJ3Sz2Vx5Hfga6jD9/PVVgChZkdR/vr0+RRTtB8Z2gYNcSTcyw JzFfE9wypajnDE6h8E+tsENBqHmwG5+BERXvmQ2gMImDXDlR4Q6Svs+etwE/REkmxxKPWbL7ckN 3LvmmgZXdjI7XSAzwUkbp972ToPkjvKejj0CnRCLf7MnZBcufsYhj+xT2h07 X-Received: by 2002:a05:6871:3a10:b0:459:fe2:ef54 with SMTP id 586e51a60fabf-4ad984fa6famr4620570fac.1.1794082442478; Sat, 07 Nov 2026 12:14:02 -0800 (PST) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4ade68aa561sm226096fac.5.2026.11.07.12.13.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2026 12:14:01 -0800 (PST) From: James Hilliard Date: Sat, 07 Nov 2026 03:16:48 -0700 Subject: [PATCH 51/58] mtd: rawnand: mpc5121: retain chip state across removal X-Archived-By: MIME-Version: 1.0 Message-Id: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-51-0181ef0cc4c8@gmail.com> References: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> In-Reply-To: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Brian Norris , Boris Brezillon , Arseniy Krasnov , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thomas Gleixner , Vitaly Wool , David Woodhouse , Russell King , David Woodhouse , Mike Rapoport , Maxime Coquelin , Alexandre Torgue , Christophe Kerello , Jason Roberts , Michal Simek , Boris Brezillon , Mason Yang , Ramuthevar Vadivel Murugan , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Dmitry Osipenko , Matthias Brugger , AngeloGioacchino Del Regno , Jorge Ramirez-Ortiz , Heiko Stuebner , Yifeng Zhao , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Keguang Zhang , Jacky Huang , Shan-Chun Hung , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Liang Yang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Manivannan Sadhasivam , Kamal Dasu , Broadcom internal kernel review list , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Cercueil , Harvey Hunt , Maxim Levitsky , Michael Walle , Srinivas Kandagatla Cc: Tze Yee Ng , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_121404_423053_5470179D X-CRM114-Status: GOOD ( 15.36 ) X-Spam-Score: 1.7 (+) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Drain NAND access before unmapping the external chip-select registers. Keep the embedded chip and controller alive until the final MTD reference, and unwind scanned NAND state on unsupported geometry and publication failure. Signed-off-by: James Hilliard --- drivers/mtd/nand/raw/mpc5121_nfc.c | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/raw/mpc5121_nfc.c b/drivers/mtd/nand/raw/mpc5121_nfc.c index e6594548b7e0..1618f46f69df 100644 --- a/drivers/mtd/nand/raw/mpc5121_nfc.c +++ b/drivers/mtd/nand/raw/mpc5121_nfc.c @@ -611,6 +611,11 @@ static const struct nand_controller_ops mpc5121_nfc_ops = { .attach_chip = mpc5121_nfc_attach_chip, }; +static void mpc5121_nfc_release(struct nand_controller *controller) +{ + kfree(container_of(controller, struct mpc5121_nfc_prv, controller)); +} + static int mpc5121_nfc_probe(struct platform_device *op) { struct device_node *dn = op->dev.of_node; @@ -636,6 +641,13 @@ static int mpc5121_nfc_probe(struct platform_device *op) return -ENXIO; } + prv = kzalloc_obj(*prv); + if (!prv) + return -ENOMEM; + retval = devm_nand_controller_init(dev, &prv->controller, mpc5121_nfc_release); + if (retval) + return retval; + regs = devm_platform_ioremap_resource(op, 0); if (IS_ERR(regs)) return PTR_ERR(regs); @@ -644,14 +656,9 @@ static int mpc5121_nfc_probe(struct platform_device *op) if (irq < 0) return irq; - prv = devm_kzalloc(dev, sizeof(*prv), GFP_KERNEL); - if (!prv) - return -ENOMEM; - chip = &prv->chip; mtd = nand_to_mtd(chip); - nand_controller_init(&prv->controller); prv->controller.ops = &mpc5121_nfc_ops; chip->controller = &prv->controller; @@ -782,19 +789,26 @@ static int mpc5121_nfc_probe(struct platform_device *op) default: dev_err(dev, "Unsupported NAND flash!\n"); retval = -ENXIO; - goto error; + goto cleanup_nand; } dev_set_drvdata(dev, mtd); /* Register device in MTD */ + retval = nand_set_release(chip, NULL); + if (retval) + goto cleanup_nand; retval = mtd_device_register(mtd, NULL, 0); if (retval) { dev_err(dev, "Error adding MTD device!\n"); + nand_disconnect(chip); + mtd_put_master(mtd); goto error; } return 0; +cleanup_nand: + nand_cleanup(chip); error: mpc5121_nfc_free(dev, mtd); return retval; @@ -808,8 +822,9 @@ static void mpc5121_nfc_remove(struct platform_device *op) ret = mtd_device_unregister(mtd); WARN_ON(ret); - nand_cleanup(mtd_to_nand(mtd)); + nand_disconnect(mtd_to_nand(mtd)); mpc5121_nfc_free(dev, mtd); + mtd_put_master(mtd); } static const struct of_device_id mpc5121_nfc_match[] = { -- 2.53.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic