From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51FFC606A322 for ; Sun, 8 Nov 2026 23:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Jfby+eXb; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=jpGUSey5 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=ZHY9nvZ8WE/EHrMe39V8rGCu1pOEGA/IE+TQFkFdDpg=; b=Jfby+eXbDVvOQLaYe7mar6lXnJ WF/G4T8T35vZjIahSj53nyrxsbGecBb8ZKH93TZLiBUrdSV+pDt+utYSDukAEPBoXDh8uALdDW77R 1nyT718jmgo7Qu8cAc5SCV5G/npzg4EfHLo3qnH72M8/ceq0VGiq1lAZgEmZw/gGDPr+Rvp6FpUEm ElSr9+SEwmkug2rt9uBSGHLKVb8tIAiVNcB6+hdnphJYHSDVOMO6KheKNDzXIypC+jV6MeWdMwkxq haQxFJ7hIsdVJhjLkxmam4x335hz2DlPXXpEEYAihAnXbtsLtyRMNAMBaQPD8ePKE4NdlN4nHVc8a 1maT7bZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQC8S-0000000GsoA-0AXB; Sun, 08 Nov 2026 23:17:16 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQC8Q-0000000Gso1-4B2y; Sun, 08 Nov 2026 23:17:15 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5A69761184; Sun, 8 Nov 2026 23:17:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC3A21F0089F; Sun, 8 Nov 2026 23:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794179833; bh=C2reihoSd8+x5X3GrAOxEQiq3mx4R4XS9zazh7fb3Us=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=jpGUSey5vvxY92S+HSf4OjpfJZrKayxou0qil8Xw8HI0KUYAGMdJ8qvI5skRIcVqJ V5OeCHHEYJ3Vf7jlLwQ00IKnbUyWU+PCNZ5C14m/P6TfbC4CerkGeqUBMWvt/9CSU3 vOzZ1fPI7/x4s7fTfR07RFmFucr1tUU/gKar+9Xx92BCNdmPpYjJV2UMvcEC5enA99 Jx1lPLuRKGwGKwbC2/W88g1DCeh6wsi5yzGUV/QN8NRyP61gx6Tuvw15s+PLAYb0jk qoWrt82mORcGdsnMmq+Iuo9quSFeAd3RLRtXGLGwClBr0T9S2hIDA3ZcbAEC6UE+kw AHaXbFVtg0DeA== Date: Sun, 8 Nov 2026 23:17:07 +0000 From: Conor Dooley To: Carlo Caione Cc: Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Kevin Hilman , Martin Blumenstingl , Jian Hu , Chuan Liu , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/7] dt-bindings: clock: Add Amlogic S7 peripherals clock controller Message-ID: <20261108-resurrect-mumbo-10daa7ac0cf0@spud> References: <20261106-upstream-s7-clk-v1-0-7d501d62621f@baylibre.com> <20261106-upstream-s7-clk-v1-6-7d501d62621f@baylibre.com> <20261106-unwilling-preoccupy-156dbb310448@spud> <20261106-headband-buckwheat-fecbd459ee85@spud> X-Archived-By: MIME-Version: 1.0 In-Reply-To: X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============9212971801864693308==" Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 --===============9212971801864693308== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hSqhUowhvI7bmoOF" Content-Disposition: inline --hSqhUowhvI7bmoOF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 06, 2026 at 11:27:38PM +0100, Carlo Caione wrote: > On Fri, Nov 06, 2026 at 20:48:01 +0100, Conor Dooley wrote: > > On Fri, Nov 06, 2026 at 08:34:37PM +0100, Carlo Caione wrote: > > > On Fri, Nov 06, 2026 at 17:34:14 +0100, Conor Dooley wrote: > > >=20 > > > > > + #include > > > > > + #include > > > > > + > > > > > + soc { > > > > > + #address-cells =3D <2>; > > > > > + #size-cells =3D <2>; > > > > > + > > > > > + clock-controller@0 { > > > > > + compatible =3D "amlogic,s7-peripherals-clkc"; > > > > > + reg =3D <0x0 0x0 0x0 0x49c>; > > > >=20 > > > > What's with the weird numbers in this example? > > > >=20 > > > > Examples don't have to be real, but when it looks like this the > > > > immediate thought is that the modelling of the device might be > > > > incorrec.t > > >=20 > > > The numbers are actually real, but the example simply lost their cont= ext > > > because I copied the node from the S7 dtsi (not yet submitted), where > > > the controller sits under the APB bus node (bus@fe000000) and the bus > > > ranges make the addresses relative to it. > > >=20 > > > apb: bus@fe000000 { > > > compatible =3D "simple-bus"; > > > reg =3D <0x0 0xfe000000 0x0 0x480000>; > > > #address-cells =3D <2>; > > > #size-cells =3D <2>; > > > ranges =3D <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; > > >=20 > > > clkc_periphs: clock-controller@0 { > > > compatible =3D "amlogic,s7-peripherals-clkc"; > > > reg =3D <0x0 0x0 0x0 0x49c>; > > > #clock-cells =3D <1>; > > > ... > > >=20 > > > In V2 I'll use an absolute address for the sake of clarity (PLL has t= he > > > same issue). > >=20 > > Before you do that, can you please share with me the s7 dtsi? Cos surely > > you've got it in some git repo online somewhere. >=20 > The S7 dtsi is already upstream at [0], the peripheral clock controller > and PLL will be enabled in that DTSI with a following series after the > bindings and the drivers in this set are acked, following the diffs that > will be submitted: Right. The device does seem to have nodes of odd sizes and start addresses, so this at least is not making anything worse. Acked-by: Conor Dooley pw-bot: not-applicable --hSqhUowhvI7bmoOF Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCavEC8wAKCRB4tDGHoIJi 0kSzAP9D+07DueUyQidEmOTviYikdTVwB4OjYhIW3eDHUkvnNAEAw27P7rZuFiZP JlFXjpIzLkFe/xvXdJ5/TibIL+soSAc= =F15I -----END PGP SIGNATURE----- --hSqhUowhvI7bmoOF-- --===============9212971801864693308== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============9212971801864693308==--