mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Igor Velkov <iav@iav.lv>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Linus Walleij <linusw@kernel.org>,
	Shawn Guo <shengchao.guo@oss.qualcomm.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org,
	regressions@lists.linux.dev
Subject: [REGRESSION] gpio: shared-proxy: open-drain regulators on ODROID-HC4 fail with -EPERM
Date: Sun, 15 Nov 2026 04:55:00 +0200	[thread overview]
Message-ID: <20261115-hc4-gpio-shared-od-1@iav.lv> (raw)

Since f918e3804498 ("arm64: enable HAVE_SHARED_GPIOS for all ARM64
platforms"), two of the three fixed regulators sharing GPIOH_8
(GPIO_OPEN_DRAIN) on ODROID-HC4 fail on every boot:

  reg-fixed-voltage regulator-p12v-0: setup of GPIO (default) failed: -1
  reg-fixed-voltage regulator-p12v-0: error -EPERM: can't get GPIO

The first user (vcc_5v) sets the line to output high in
gpiod_configure_flags(). Its enable then goes through
gpio_set_open_drain_value_commit(), which emulates high by calling
direction_input on the proxy, and the proxy switches the shared line to
input. The next users hit "Shared GPIO's direction already set to input,
refusing to change" in gpio_shared_proxy_direction_output(). Stack from
trace_trigger=gpio_direction.stacktrace:

  gpiod_direction_input <- gpio_shared_proxy_direction_input
  <- gpio_set_open_drain_value_commit <- gpiod_set_value_cansleep
  <- _regulator_do_enable <- set_machine_constraints <- regulator_register

Armbian v7.4-rc2 (its patches don't touch gpiolib or these nodes); same
with the five shared-proxy fixes from the v7.4-rc3 pull. The winner
depends on probe order: without the fixes vcc_5v lost in 2 of 4 boots,
leaving the SD card unpowered and no rootfs.

#regzbot introduced: f918e3804498

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

             reply	other threads:[~2026-11-15  2:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15  2:55 Igor Velkov [this message]
2026-11-16 15:33 ` Bartosz Golaszewski
2026-11-17 13:35 ` Bartosz Golaszewski
2026-11-17 18:15   ` Igor Velkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261115-hc4-gpio-shared-od-1@iav.lv \
    --to=iav@iav.lv \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=regressions@lists.linux.dev \
    --cc=shengchao.guo@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®